libxl: open logs with O_APPEND
authorIan Jackson <Ian.Jackson@eu.citrix.com>
Mon, 28 Nov 2011 17:19:28 +0000 (17:19 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Mon, 28 Nov 2011 17:19:28 +0000 (17:19 +0000)
Logfiles should always be opened for append.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/libxl_dm.c
tools/libxl/xl_cmdimpl.c

index bf38877de10bc62f1711a31bbefcb4bf38b824e9..cef80be5945cfe7d755fb04f03baf4a4c4d2b1f7 100644 (file)
@@ -830,7 +830,7 @@ int libxl__create_device_model(libxl__gc *gc,
     libxl__xs_write(gc, XBT_NULL, libxl__sprintf(gc, "%s/disable_pf", path), "%d", !info->xen_platform_pci);
 
     libxl_create_logfile(ctx, libxl__sprintf(gc, "qemu-dm-%s", info->dom_name), &logfile);
-    logfile_w = open(logfile, O_WRONLY|O_CREAT, 0644);
+    logfile_w = open(logfile, O_WRONLY|O_CREAT|O_APPEND, 0644);
     free(logfile);
     null = open("/dev/null", O_RDONLY);
 
index 080aa2bb0fcba4ccfd9585003fc2b60ebb02aa71..a9b7ef2e39b0760c162db3ba26df131ec9530c9b 100644 (file)
@@ -1597,7 +1597,8 @@ start:
             exit(-1);
         }
 
-        CHK_ERRNO(( logfile = open(fullname, O_WRONLY|O_CREAT, 0644) )<0);
+        CHK_ERRNO(( logfile = open(fullname, O_WRONLY|O_CREAT|O_APPEND,
+                                   0644) )<0);
         free(fullname);
         free(name);