build: Divide mit-krb5-gssapi link flags between LDFLAGS and LIBS
authorSimon McVittie <smcv@collabora.com>
Tue, 22 Nov 2022 20:43:41 +0000 (20:43 +0000)
committerPeter Michael Green <plugwash@raspbian.org>
Fri, 24 Jan 2025 04:39:00 +0000 (04:39 +0000)
From the comments nearby about not having --libs-only-L, it looks as
though the intention was to apply a split like this to all dependency
libraries where possible, and the only reason it was not done for
Kerberos is that krb5-config doesn't have that feature and pkg-config
was originally not supported here. For example, zlib, libssh and librtmp
all have their flags from pkg-config split in this way.

Now that pkg-config is supported here, we can do the intended split.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Gbp-Pq: Name build-Divide-mit-krb5-gssapi-link-flags-between-LDFLAGS-a.patch

configure.ac

index b645bb72d02f9ac9c94bf6fb802db0496599ef8d..d1b2d79a33689987f33c2ee5143d593c8cb15601 100644 (file)
@@ -2050,7 +2050,8 @@ if test x"$want_gss" = xyes; then
           gss_libs=`$GSSAPI_ROOT/bin/$host_alias-krb5-config --libs gssapi`
           LIBS="$gss_libs $LIBS"
         elif test "$PKGCONFIG" != "no"; then
-          gss_libs=`$PKGCONFIG --libs mit-krb5-gssapi`
+          LDFLAGS="$LDFLAGS `$PKGCONFIG --libs-only-L mit-krb5-gssapi`"
+          gss_libs=`$PKGCONFIG --libs-only-l mit-krb5-gssapi`
           LIBS="$gss_libs $LIBS"
           link_pkgconfig=1
         elif test -f "$KRB5CONFIG"; then