tools: libxl: check errors from libxl_create_logfile for stubdom log
authorIan Campbell <ian.campbell@citrix.com>
Wed, 15 Jul 2015 12:14:41 +0000 (13:14 +0100)
committerIan Campbell <ian.campbell@citrix.com>
Thu, 16 Jul 2015 15:26:10 +0000 (16:26 +0100)
Spotted by Coverity after the recent similar fix to
libxl__create_qemu_logfile.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
tools/libxl/libxl_dm.c

index 19fb2e408d425de5d7464fef20f714c8842dad4f..634b8d2d660bd5154879ca37728c80e055ec8d03 100644 (file)
@@ -1258,7 +1258,8 @@ static void spawn_stub_launch_dm(libxl__egc *egc,
             case STUBDOM_CONSOLE_LOGGING:
                 name = libxl__sprintf(gc, "qemu-dm-%s",
                                       libxl_domid_to_name(ctx, guest_domid));
-                libxl_create_logfile(ctx, name, &filename);
+                ret = libxl_create_logfile(ctx, name, &filename);
+                if (ret) goto out;
                 console[i].output = libxl__sprintf(gc, "file:%s", filename);
                 free(filename);
                 break;