vfs: Don't assume suffix mode for old folders

That would break with old folders that use selective sync.

diff --git a/src/gui/folder.cpp b/src/gui/folder.cpp
index 46d65b9820aaa77341a6b033754c88114869b818..7f7bc4110c65c94de24b018820a6e62940c6d577 100644 (file)
--- a/src/gui/folder.cpp
+++ b/src/gui/folder.cpp
@@ -1277,16 +1277,19 @@ bool FolderDefinition::load(QSettings &settings, const QString &alias,
     folder->ignoreHiddenFiles = settings.value(QLatin1String("ignoreHiddenFiles"), QVariant(true)).toBool();
     folder->navigationPaneClsid = settings.value(QLatin1String("navigationPaneClsid")).toUuid();
 
-    folder->virtualFilesMode = Vfs::WithSuffix;
+    folder->virtualFilesMode = Vfs::Off;
     QString vfsModeString = settings.value(QStringLiteral("virtualFilesMode")).toString();
     if (!vfsModeString.isEmpty()) {
         if (auto mode = Vfs::modeFromString(vfsModeString)) {
             folder->virtualFilesMode = *mode;
         } else {
-            qCWarning(lcFolder) << "Unknown virtualFilesMode:" << vfsModeString << "assuming 'suffix'";
+            qCWarning(lcFolder) << "Unknown virtualFilesMode:" << vfsModeString << "assuming 'off'";
         }
     } else {
-        folder->upgradeVfsMode = true;
+        if (settings.value(QLatin1String("usePlaceholders")).toBool()) {
+            folder->virtualFilesMode = Vfs::WithSuffix;
+            folder->upgradeVfsMode = true; // maybe winvfs is available?
+        }
     }
 
     // Old settings can contain paths with native separators. In the rest of the