firmware: Remove redundant log messages from drivers
authorBen Hutchings <ben@decadent.org.uk>
Sun, 9 Dec 2012 16:40:31 +0000 (16:40 +0000)
committerSalvatore Bonaccorso <carnil@debian.org>
Tue, 29 Mar 2022 20:46:53 +0000 (21:46 +0100)
Forwarded: no

Now that firmware_class logs every success and failure consistently,
many other log messages can be removed from drivers.

This will probably need to be split up into multiple patches prior to
upstream submission.

Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name firmware-remove-redundant-log-messages-from-drivers.patch

147 files changed:
arch/x86/kernel/cpu/microcode/amd.c
drivers/atm/ambassador.c
drivers/atm/fore200e.c
drivers/bluetooth/ath3k.c
drivers/bluetooth/bcm203x.c
drivers/bluetooth/bfusb.c
drivers/bluetooth/bt3c_cs.c
drivers/bluetooth/btmrvl_sdio.c
drivers/char/dsp56k.c
drivers/dma/imx-sdma.c
drivers/gpu/drm/mga/mga_warp.c
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
drivers/gpu/drm/r128/r128_cce.c
drivers/gpu/drm/radeon/ni.c
drivers/gpu/drm/radeon/r100.c
drivers/gpu/drm/radeon/r600.c
drivers/infiniband/hw/qib/qib_sd7220.c
drivers/input/touchscreen/atmel_mxt_ts.c
drivers/isdn/hardware/mISDN/speedfax.c
drivers/media/common/siano/smscoreapi.c
drivers/media/dvb-frontends/af9013.c
drivers/media/dvb-frontends/bcm3510.c
drivers/media/dvb-frontends/cx24116.c
drivers/media/dvb-frontends/drxd_hard.c
drivers/media/dvb-frontends/drxk_hard.c
drivers/media/dvb-frontends/ds3000.c
drivers/media/dvb-frontends/nxt200x.c
drivers/media/dvb-frontends/or51132.c
drivers/media/dvb-frontends/or51211.c
drivers/media/dvb-frontends/sp887x.c
drivers/media/dvb-frontends/tda10048.c
drivers/media/dvb-frontends/tda1004x.c
drivers/media/dvb-frontends/tda10071.c
drivers/media/i2c/cx25840/cx25840-firmware.c
drivers/media/pci/bt8xx/bttv-cards.c
drivers/media/pci/cx18/cx18-av-firmware.c
drivers/media/pci/cx18/cx18-dvb.c
drivers/media/pci/cx18/cx18-firmware.c
drivers/media/pci/cx23885/cx23885-417.c
drivers/media/pci/cx23885/cx23885-cards.c
drivers/media/pci/cx88/cx88-blackbird.c
drivers/media/pci/ivtv/ivtv-firmware.c
drivers/media/pci/ngene/ngene-core.c
drivers/media/pci/saa7164/saa7164-fw.c
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
drivers/media/radio/radio-wl1273.c
drivers/media/radio/wl128x/fmdrv_common.c
drivers/media/tuners/tuner-xc2028.c
drivers/media/usb/cpia2/cpia2_core.c
drivers/media/usb/cx231xx/cx231xx-417.c
drivers/media/usb/dvb-usb/dib0700_devices.c
drivers/media/usb/dvb-usb/dvb-usb-firmware.c
drivers/media/usb/dvb-usb/gp8psk.c
drivers/media/usb/dvb-usb/opera1.c
drivers/media/usb/go7007/go7007-driver.c
drivers/media/usb/go7007/go7007-fw.c
drivers/media/usb/go7007/go7007-loader.c
drivers/media/usb/gspca/vicam.c
drivers/media/usb/pvrusb2/pvrusb2-hdw.c
drivers/media/usb/s2255/s2255drv.c
drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c
drivers/media/usb/ttusb-dec/ttusb_dec.c
drivers/misc/ti-st/st_kim.c
drivers/net/can/softing/softing_fw.c
drivers/net/ethernet/3com/typhoon.c
drivers/net/ethernet/adaptec/starfire.c
drivers/net/ethernet/alacritech/slicoss.c
drivers/net/ethernet/alteon/acenic.c
drivers/net/ethernet/broadcom/bnx2.c
drivers/net/ethernet/broadcom/tg3.c
drivers/net/ethernet/brocade/bna/cna_fwimg.c
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
drivers/net/ethernet/intel/e100.c
drivers/net/ethernet/myricom/myri10ge/myri10ge.c
drivers/net/ethernet/smsc/smc91c92_cs.c
drivers/net/ethernet/sun/cassini.c
drivers/net/hamradio/yam.c
drivers/net/usb/kaweth.c
drivers/net/wireless/ath/ath9k/hif_usb.c
drivers/net/wireless/ath/carl9170/usb.c
drivers/net/wireless/atmel/at76c50x-usb.c
drivers/net/wireless/atmel/atmel.c
drivers/net/wireless/broadcom/b43/main.c
drivers/net/wireless/broadcom/b43legacy/main.c
drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c
drivers/net/wireless/intel/ipw2x00/ipw2100.c
drivers/net/wireless/intel/ipw2x00/ipw2200.c
drivers/net/wireless/intel/iwlegacy/3945-mac.c
drivers/net/wireless/intel/iwlwifi/iwl-drv.c
drivers/net/wireless/intersil/orinoco/fw.c
drivers/net/wireless/intersil/orinoco/orinoco_usb.c
drivers/net/wireless/intersil/p54/p54pci.c
drivers/net/wireless/intersil/p54/p54spi.c
drivers/net/wireless/intersil/p54/p54usb.c
drivers/net/wireless/marvell/libertas_tf/if_usb.c
drivers/net/wireless/marvell/mwifiex/main.c
drivers/net/wireless/marvell/mwl8k.c
drivers/net/wireless/ralink/rt2x00/rt2x00firmware.c
drivers/net/wireless/realtek/rtlwifi/core.c
drivers/net/wireless/realtek/rtlwifi/rtl8192se/sw.c
drivers/net/wireless/ti/wl1251/main.c
drivers/net/wireless/ti/wlcore/main.c
drivers/net/wireless/zydas/zd1201.c
drivers/net/wireless/zydas/zd1211rw/zd_usb.c
drivers/scsi/advansys.c
drivers/scsi/aic94xx/aic94xx_init.c
drivers/scsi/aic94xx/aic94xx_seq.c
drivers/scsi/bfa/bfad.c
drivers/scsi/ipr.c
drivers/scsi/pm8001/pm8001_ctl.c
drivers/scsi/qla1280.c
drivers/scsi/qla2xxx/qla_init.c
drivers/scsi/qla2xxx/qla_nx.c
drivers/scsi/qla2xxx/qla_os.c
drivers/scsi/qlogicpti.c
drivers/staging/rtl8192u/r819xU_firmware.c
drivers/staging/rtl8712/hal_init.c
drivers/staging/vt6656/main_usb.c
drivers/tty/moxa.c
drivers/tty/serial/icom.c
drivers/tty/serial/ucc_uart.c
drivers/usb/atm/cxacru.c
drivers/usb/atm/ueagle-atm.c
drivers/usb/misc/emi26.c
drivers/usb/misc/ezusb.c
drivers/usb/misc/isight_firmware.c
drivers/usb/serial/io_edgeport.c
drivers/usb/serial/io_ti.c
drivers/usb/serial/ti_usb_3410_5052.c
drivers/video/fbdev/broadsheetfb.c
drivers/video/fbdev/metronomefb.c
sound/drivers/vx/vx_hwdep.c
sound/isa/msnd/msnd_pinnacle.c
sound/isa/sscape.c
sound/isa/wavefront/wavefront_synth.c
sound/pci/asihpi/hpidspcd.c
sound/pci/cs46xx/cs46xx_lib.c
sound/pci/echoaudio/echoaudio.c
sound/pci/emu10k1/emu10k1_main.c
sound/pci/hda/hda_intel.c
sound/pci/korg1212/korg1212.c
sound/pci/mixart/mixart_hwdep.c
sound/pci/pcxhr/pcxhr_hwdep.c
sound/pci/riptide/riptide.c
sound/pci/rme9652/hdsp.c
sound/soc/codecs/wm2000.c
sound/usb/6fire/firmware.c

index 8b2fcdfa6d316816d0db2b1f46cd1f9cc8120ff4..f406885d4cf5e75f30d2fa88d9f1e96e87195c37 100644 (file)
@@ -906,10 +906,8 @@ static enum ucode_state request_microcode_amd(int cpu, struct device *device,
        if (c->x86 >= 0x15)
                snprintf(fw_name, sizeof(fw_name), "amd-ucode/microcode_amd_fam%.2xh.bin", c->x86);
 
-       if (request_firmware_direct(&fw, (const char *)fw_name, device)) {
-               pr_debug("failed to load file %s\n", fw_name);
+       if (request_firmware_direct(&fw, (const char *)fw_name, device))
                goto out;
-       }
 
        ret = UCODE_ERROR;
        if (!verify_container(fw->data, fw->size, false))
index c039b8a4fefed1697add7cf53d4ef9fe240e4669..e28b965059c002301a18d682d85754de3cfe4d28 100644 (file)
@@ -1914,10 +1914,8 @@ static int ucode_init(loader_block *lb, amb_dev *dev)
   int res;
 
   res = request_ihex_firmware(&fw, "atmsar11.fw", &dev->pci_dev->dev);
-  if (res) {
-    PRINTK (KERN_ERR, "Cannot load microcode data");
+  if (res)
     return res;
-  }
 
   /* First record contains just the start address */
   rec = (const struct ihex_binrec *)fw->data;
index fb2be3574c26a85e79478b6d319077b7008d25cd..c0e1e507fbfd02b9c1571dbfe3fa9c2c052699da 100644 (file)
@@ -2398,10 +2398,9 @@ static int fore200e_load_and_start_fw(struct fore200e *fore200e)
     int err;
 
     sprintf(buf, "%s%s", fore200e->bus->proc_name, FW_EXT);
-    if ((err = request_firmware(&firmware, buf, fore200e->dev)) < 0) {
-       printk(FORE200E "problem loading firmware image %s\n", fore200e->bus->model_name);
+    err = request_firmware(&firmware, buf, fore200e->dev);
+    if (err)
        return err;
-    }
 
     fw_data = (const __le32 *)firmware->data;
     fw_size = firmware->size / sizeof(u32);
index 759d7828931d9f68ebd20474cec8a284fafd36d6..4e759e90e53d41fdbe69a97e7cc7b590d1a1fb53 100644 (file)
@@ -382,10 +382,8 @@ static int ath3k_load_patch(struct usb_device *udev)
                 le32_to_cpu(fw_version.rom_version));
 
        ret = request_firmware(&firmware, filename, &udev->dev);
-       if (ret < 0) {
-               BT_ERR("Patch file not found %s", filename);
+       if (ret)
                return ret;
-       }
 
        pt_rom_version = get_unaligned_le32(firmware->data +
                                            firmware->size - 8);
@@ -445,10 +443,8 @@ static int ath3k_load_syscfg(struct usb_device *udev)
                le32_to_cpu(fw_version.rom_version), clk_value, ".dfu");
 
        ret = request_firmware(&firmware, filename, &udev->dev);
-       if (ret < 0) {
-               BT_ERR("Configuration file not found %s", filename);
+       if (ret)
                return ret;
-       }
 
        ret = ath3k_load_fwfile(udev, firmware);
        release_firmware(firmware);
index e667933c3d703b7fb7955caee554a461f4f0171b..7737bcc3caed78bbb007b3817a7d9bfeedd0eeab 100644 (file)
@@ -174,7 +174,6 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id
                return -ENOMEM;
 
        if (request_firmware(&firmware, "BCM2033-MD.hex", &udev->dev) < 0) {
-               BT_ERR("Mini driver request failed");
                usb_free_urb(data->urb);
                return -EIO;
        }
@@ -199,7 +198,6 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id
        release_firmware(firmware);
 
        if (request_firmware(&firmware, "BCM2033-FW.bin", &udev->dev) < 0) {
-               BT_ERR("Firmware request failed");
                usb_free_urb(data->urb);
                kfree(data->buffer);
                return -EIO;
index cab93935cc7f16aabb2688dad98fe2065940b622..7de21e11aeaeee43a185eb227ab70b70ac20ec2c 100644 (file)
@@ -639,10 +639,8 @@ static int bfusb_probe(struct usb_interface *intf, const struct usb_device_id *i
        skb_queue_head_init(&data->pending_q);
        skb_queue_head_init(&data->completed_q);
 
-       if (request_firmware(&firmware, "bfubase.frm", &udev->dev) < 0) {
-               BT_ERR("Firmware request failed");
+       if (request_firmware(&firmware, "bfubase.frm", &udev->dev))
                goto done;
-       }
 
        BT_DBG("firmware data %p size %zu", firmware->data, firmware->size);
 
index 54713833951a9ddd6fa34780a263942863e242a2..341ed2d9be1e2625561087c3471c50967b8d953b 100644 (file)
@@ -569,10 +569,8 @@ static int bt3c_open(struct bt3c_info *info)
 
        /* Load firmware */
        err = request_firmware(&firmware, "BT3CPCC.bin", &info->p_dev->dev);
-       if (err < 0) {
-               BT_ERR("Firmware request failed");
+       if (err)
                goto error;
-       }
 
        err = bt3c_load_firmware(info, firmware->data, firmware->size);
 
index 68378b42ea7fdde1bc705f5fc9238bbba9b6e227..9ccc0d5a529d4b0b30e5d1da5e4f83851acfa0b2 100644 (file)
@@ -483,8 +483,6 @@ static int btmrvl_sdio_download_helper(struct btmrvl_sdio_card *card)
        ret = request_firmware(&fw_helper, card->helper,
                                                &card->func->dev);
        if ((ret < 0) || !fw_helper) {
-               BT_ERR("request_firmware(helper) failed, error code = %d",
-                                                                       ret);
                ret = -ENOENT;
                goto done;
        }
@@ -583,8 +581,6 @@ static int btmrvl_sdio_download_fw_w_helper(struct btmrvl_sdio_card *card)
        ret = request_firmware(&fw_firmware, card->firmware,
                                                        &card->func->dev);
        if ((ret < 0) || !fw_firmware) {
-               BT_ERR("request_firmware(firmware) failed, error code = %d",
-                                                                       ret);
                ret = -ENOENT;
                goto done;
        }
index 06749e295adaff06e2770c296a5f2aeaa28a00d4..27cd3e4121a15908e58cff910a78d1197e9ae065 100644 (file)
@@ -140,11 +140,8 @@ static int dsp56k_upload(u_char __user *bin, int len)
        }
        err = request_firmware(&fw, fw_name, &pdev->dev);
        platform_device_unregister(pdev);
-       if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fw_name, err);
+       if (err)
                return err;
-       }
        if (fw->size % 3) {
                printk(KERN_ERR "Bogus length %d in image \"%s\"\n",
                       fw->size, fw_name);
index 75ec0754d4ad4e643d81f1a8076fedd9ecf2b783..10dd1cc2a1ca6484f39d91d409368211f09b66e5 100644 (file)
@@ -1800,11 +1800,8 @@ static void sdma_load_firmware(const struct firmware *fw, void *context)
        const struct sdma_script_start_addrs *addr;
        unsigned short *ram_code;
 
-       if (!fw) {
-               dev_info(sdma->dev, "external firmware not found, using ROM firmware\n");
-               /* In this case we just use the ROM firmware. */
+       if (!fw)
                return;
-       }
 
        if (fw->size < sizeof(*header))
                goto err_firmware;
index b5ef1d2c8b1c1044df0f2893330f84125b049787..cb0d2fa4c2a892b0eb662825406909b3d03cf9ed 100644 (file)
@@ -77,11 +77,8 @@ int mga_warp_install_microcode(drm_mga_private_t *dev_priv)
        }
        rc = request_ihex_firmware(&fw, firmware_name, &pdev->dev);
        platform_device_unregister(pdev);
-       if (rc) {
-               DRM_ERROR("mga: Failed to load microcode \"%s\"\n",
-                         firmware_name);
+       if (rc)
                return rc;
-       }
 
        size = 0;
        where = 0;
index 397ff4fe9df89fac4b6b01d1e19a2c03409fc442..ad959da8af1ddaa910caadd48e6beb1eaf36d4af 100644 (file)
@@ -2445,10 +2445,8 @@ gf100_gr_load_fw(struct gf100_gr *gr, const char *name,
        if (ret) {
                snprintf(f, sizeof(f), "nouveau/%s", name);
                ret = request_firmware(&fw, f, device->dev);
-               if (ret) {
-                       nvkm_error(subdev, "failed to load %s\n", name);
+               if (ret)
                        return ret;
-               }
        }
 
        blob->size = fw->size;
index c04d84a69dd29e1387040fe06709fc0c05c997a1..ba2cb6e4b7d3093882a68af0eb0bc4dbbb9a5ba4 100644 (file)
@@ -161,11 +161,8 @@ static int r128_cce_load_microcode(drm_r128_private_t *dev_priv)
        }
        rc = request_firmware(&fw, FIRMWARE_NAME, &pdev->dev);
        platform_device_unregister(pdev);
-       if (rc) {
-               pr_err("r128_cce: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_NAME);
+       if (rc)
                return rc;
-       }
 
        if (fw->size != 256 * 8) {
                pr_err("r128_cce: Bogus length %zu in firmware \"%s\"\n",
index 4a364ca7a1be71ae07beaa7de875e511a64272c8..eef8dea6dc1490f062be581fad37c26719133feb 100644 (file)
@@ -820,9 +820,6 @@ int ni_init_microcode(struct radeon_device *rdev)
 
 out:
        if (err) {
-               if (err != -EINVAL)
-                       pr_err("ni_cp: Failed to load firmware \"%s\"\n",
-                              fw_name);
                release_firmware(rdev->pfp_fw);
                rdev->pfp_fw = NULL;
                release_firmware(rdev->me_fw);
index 2dd85ba1faa27e0af711d38fc952916f0927b272..e179189a45edd70375ea9448082f18b627e63d80 100644 (file)
@@ -1056,9 +1056,7 @@ static int r100_cp_init_microcode(struct radeon_device *rdev)
        }
 
        err = request_firmware(&rdev->me_fw, fw_name, rdev->dev);
-       if (err) {
-               pr_err("radeon_cp: Failed to load firmware \"%s\"\n", fw_name);
-       } else if (rdev->me_fw->size % 8) {
+       if (err == 0 && rdev->me_fw->size % 8) {
                pr_err("radeon_cp: Bogus length %zu in firmware \"%s\"\n",
                       rdev->me_fw->size, fw_name);
                err = -EINVAL;
index ca3fcae2adb537539042b3e906659f8bd973a1e9..25418a75a13a1a4bf6744df3c61f20e518c3a84e 100644 (file)
@@ -2600,9 +2600,6 @@ int r600_init_microcode(struct radeon_device *rdev)
 
 out:
        if (err) {
-               if (err != -EINVAL)
-                       pr_err("r600_cp: Failed to load firmware \"%s\"\n",
-                              fw_name);
                release_firmware(rdev->pfp_fw);
                rdev->pfp_fw = NULL;
                release_firmware(rdev->me_fw);
index 81b810d006c0a4e15e22cfa96370fc76e01a2f6f..3214a65db381e28b9084ca37637c136b792c91a9 100644 (file)
@@ -406,10 +406,8 @@ int qib_sd7220_init(struct qib_devdata *dd)
        }
 
        ret = request_firmware(&fw, SD7220_FW_NAME, &dd->pcidev->dev);
-       if (ret) {
-               qib_dev_err(dd, "Failed to load IB SERDES image\n");
+       if (ret)
                goto done;
-       }
 
        /* Substitute our deduced value for was_reset */
        ret = qib_ibsd_ucode_loaded(dd->pport, fw);
index eb66cd2689b7c64487910cacc75a97f231e804ef..b0e31870b3d651d0478120e42d27df2a9da2c697 100644 (file)
@@ -2870,10 +2870,8 @@ static int mxt_load_fw(struct device *dev, const char *fn)
        int ret;
 
        ret = request_firmware(&fw, fn, dev);
-       if (ret) {
-               dev_err(dev, "Unable to open firmware %s\n", fn);
+       if (ret)
                return ret;
-       }
 
        /* Check for incorrect enc file */
        ret = mxt_check_firmware_format(dev, fw);
index b530c78eca8ee6128a0be626a1fb5735cd1af61b..a336db7a81355a550b1bb6e9213bcaf22eeee7ab 100644 (file)
@@ -379,11 +379,8 @@ setup_instance(struct sfax_hw *card)
        card->isar.owner = THIS_MODULE;
 
        err = request_firmware(&firmware, "isdn/ISAR.BIN", &card->pdev->dev);
-       if (err < 0) {
-               pr_info("%s: firmware request failed %d\n",
-                       card->name, err);
+       if (err)
                goto error_fw;
-       }
        if (debug & DEBUG_HW)
                pr_notice("%s: got firmware %zu bytes\n",
                          card->name, firmware->size);
index 7d4bc2733f2b074e0d2cba7157ee297bc4110a55..dbbee0640a30f6e0b5fb18796e4c211fc9c60c15 100644 (file)
@@ -1152,10 +1152,8 @@ static int smscore_load_firmware_from_file(struct smscore_device_t *coredev,
                return -EINVAL;
 
        rc = request_firmware(&fw, fw_filename, coredev->device);
-       if (rc < 0) {
-               pr_err("failed to open firmware file '%s'\n", fw_filename);
+       if (rc < 0)
                return rc;
-       }
        pr_debug("read fw %s, buffer size=0x%zx\n", fw_filename, fw->size);
        fw_buf = kmalloc(ALIGN(fw->size + sizeof(struct sms_firmware),
                         SMS_ALLOC_ALIGNMENT), GFP_KERNEL | coredev->gfp_buf_flags);
index 7d7c341b2bd84067bd9d8b0c4911540e4fde7055..7c4d7403ee9bd73ed921b85664e677f120bc8745 100644 (file)
@@ -1049,14 +1049,8 @@ static int af9013_download_firmware(struct af9013_state *state)
 
        /* Request the firmware, will block and timeout */
        ret = request_firmware(&firmware, name, &client->dev);
-       if (ret) {
-               dev_info(&client->dev, "firmware file '%s' not found %d\n",
-                        name, ret);
+       if (ret)
                goto err;
-       }
-
-       dev_info(&client->dev, "downloading firmware from file '%s'\n",
-                name);
 
        /* Write firmware checksum & size */
        for (i = 0; i < firmware->size; i++)
index da0ff7b44da41aed330693d1d947e1e553856ff5..9c5ba32ae02e9ae9d5ead8e527436051d83edb97 100644 (file)
@@ -636,10 +636,9 @@ static int bcm3510_download_firmware(struct dvb_frontend* fe)
        int ret,i;
 
        deb_info("requesting firmware\n");
-       if ((ret = st->config->request_firmware(fe, &fw, BCM3510_DEFAULT_FIRMWARE)) < 0) {
-               err("could not load firmware (%s): %d",BCM3510_DEFAULT_FIRMWARE,ret);
+       ret = st->config->request_firmware(fe, &fw, BCM3510_DEFAULT_FIRMWARE);
+       if (ret)
                return ret;
-       }
        deb_info("got firmware: %zu\n", fw->size);
 
        b = fw->data;
index ea8264ccbb4e841c448f783ccec5327075124162..becc7dc68477d38eb115681b99989bba2382c538 100644 (file)
@@ -479,13 +479,8 @@ static int cx24116_firmware_ondemand(struct dvb_frontend *fe)
                        __func__, CX24116_DEFAULT_FIRMWARE);
                ret = request_firmware(&fw, CX24116_DEFAULT_FIRMWARE,
                        state->i2c->dev.parent);
-               printk(KERN_INFO "%s: Waiting for firmware upload(2)...\n",
-                       __func__);
-               if (ret) {
-                       printk(KERN_ERR "%s: No firmware uploaded (timeout or file not found?)\n",
-                              __func__);
+               if (ret)
                        return ret;
-               }
 
                /* Make sure we don't recurse back through here
                 * during loading */
index a7eb81df88c2c15b1831e8aa877a0dffdb5878e7..51605149474b3a3c6754a84b92966ac2a01f947a 100644 (file)
@@ -891,10 +891,8 @@ static int load_firmware(struct drxd_state *state, const char *fw_name)
 {
        const struct firmware *fw;
 
-       if (request_firmware(&fw, fw_name, state->dev) < 0) {
-               printk(KERN_ERR "drxd: firmware load failure [%s]\n", fw_name);
+       if (request_firmware(&fw, fw_name, state->dev))
                return -EIO;
-       }
 
        state->microcode = kmemdup(fw->data, fw->size, GFP_KERNEL);
        if (!state->microcode) {
index d7fc2595f15b8caaa0a673ad21ec026e41906309..087a016eeb1a82c47f8f35193bbc4cf62e56b193 100644 (file)
@@ -6260,10 +6260,6 @@ static void load_firmware_cb(const struct firmware *fw,
 
        dprintk(1, ": %s\n", fw ? "firmware loaded" : "firmware not loaded");
        if (!fw) {
-               pr_err("Could not load firmware file %s.\n",
-                       state->microcode_name);
-               pr_info("Copy %s to your hotplug directory!\n",
-                       state->microcode_name);
                state->microcode_name = NULL;
 
                /*
index 20fcf31af1658b77aef94b1f193345d98602233c..d8008d58285455f31fc79f980fa3e30ba5206a1c 100644 (file)
@@ -348,12 +348,8 @@ static int ds3000_firmware_ondemand(struct dvb_frontend *fe)
                                DS3000_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, DS3000_DEFAULT_FIRMWARE,
                                state->i2c->dev.parent);
-       printk(KERN_INFO "%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               printk(KERN_ERR "%s: No firmware uploaded (timeout or file not found?)\n",
-                      __func__);
+       if (ret)
                return ret;
-       }
 
        ret = ds3000_load_firmware(fe, fw);
        if (ret)
index 200b6dbc75f814794b6953788000e910b6ec362d..da3b7550a8b6770729197d324187b317bdafffbf 100644 (file)
@@ -861,12 +861,8 @@ static int nxt2002_init(struct dvb_frontend* fe)
                 __func__, NXT2002_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, NXT2002_DEFAULT_FIRMWARE,
                               state->i2c->dev.parent);
-       pr_debug("%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               pr_err("%s: No firmware uploaded (timeout or file not found?)\n",
-                      __func__);
+       if (ret)
                return ret;
-       }
 
        ret = nxt2002_load_firmware(fe, fw);
        release_firmware(fw);
@@ -928,12 +924,8 @@ static int nxt2004_init(struct dvb_frontend* fe)
                 __func__, NXT2004_DEFAULT_FIRMWARE);
        ret = request_firmware(&fw, NXT2004_DEFAULT_FIRMWARE,
                               state->i2c->dev.parent);
-       pr_debug("%s: Waiting for firmware upload(2)...\n", __func__);
-       if (ret) {
-               pr_err("%s: No firmware uploaded (timeout or file not found?)\n",
-                      __func__);
+       if (ret)
                return ret;
-       }
 
        ret = nxt2004_load_firmware(fe, fw);
        release_firmware(fw);
index 24de1b115158387e298a307ec52b1b5a0c461c95..66c57a596173b92eb5f9ade02194eec533855566 100644 (file)
@@ -326,10 +326,8 @@ static int or51132_set_parameters(struct dvb_frontend *fe)
                printk("or51132: Waiting for firmware upload(%s)...\n",
                       fwname);
                ret = request_firmware(&fw, fwname, state->i2c->dev.parent);
-               if (ret) {
-                       printk(KERN_WARNING "or51132: No firmware uploaded(timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
                ret = or51132_load_firmware(fe, fw);
                release_firmware(fw);
                if (ret) {
index ddcaea5c9941f41c2c0e5d2edcc676e1f0ed2f63..fb198eb3181a56c18abc804b3db469c45b9adcb3 100644 (file)
@@ -361,11 +361,8 @@ static int or51211_init(struct dvb_frontend* fe)
                        OR51211_DEFAULT_FIRMWARE);
                ret = config->request_firmware(fe, &fw,
                                               OR51211_DEFAULT_FIRMWARE);
-               pr_info("Got Hotplug firmware\n");
-               if (ret) {
-                       pr_warn("No firmware uploaded (timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
 
                ret = or51211_load_firmware(fe, fw);
                release_firmware(fw);
index c89a91a3daf404cb15130443e9e9788da8bcbcd3..9fdf51248c29704dbb3a5a77203bf0adb51ad2c4 100644 (file)
@@ -527,10 +527,8 @@ static int sp887x_init(struct dvb_frontend* fe)
                /* request the firmware, this will block until someone uploads it */
                printk("sp887x: waiting for firmware upload (%s)...\n", SP887X_DEFAULT_FIRMWARE);
                ret = state->config->request_firmware(fe, &fw, SP887X_DEFAULT_FIRMWARE);
-               if (ret) {
-                       printk("sp887x: no firmware upload (timeout or file not found?)\n");
+               if (ret)
                        return ret;
-               }
 
                ret = sp887x_initial_setup(fe, fw);
                release_firmware(fw);
index d1d206ebdedd79e5f161f3d1811f63f1ac02212c..110961be6a0c86b61d0e3566db854d8167db450c 100644 (file)
@@ -483,8 +483,6 @@ static int tda10048_firmware_upload(struct dvb_frontend *fe)
        ret = request_firmware(&fw, TDA10048_DEFAULT_FIRMWARE,
                state->i2c->dev.parent);
        if (ret) {
-               printk(KERN_ERR "%s: Upload failed. (file not found?)\n",
-                       __func__);
                return -EIO;
        } else {
                printk(KERN_INFO "%s: firmware read %zu bytes.\n",
index 83a798ca9b00290d03a39d3514b5280ad1750859..f36cc486edf7ffe56698c03dcfb0318f6f58d1d9 100644 (file)
@@ -388,10 +388,8 @@ static int tda10045_fwupload(struct dvb_frontend* fe)
        /* request the firmware, this will block until someone uploads it */
        printk(KERN_INFO "tda1004x: waiting for firmware upload (%s)...\n", TDA10045_DEFAULT_FIRMWARE);
        ret = state->config->request_firmware(fe, &fw, TDA10045_DEFAULT_FIRMWARE);
-       if (ret) {
-               printk(KERN_ERR "tda1004x: no firmware upload (timeout or file not found?)\n");
+       if (ret)
                return ret;
-       }
 
        /* reset chip */
        tda1004x_write_mask(state, TDA1004X_CONFC4, 0x10, 0);
@@ -532,7 +530,6 @@ static int tda10046_fwupload(struct dvb_frontend* fe)
                        /* remain compatible to old bug: try to load with tda10045 image name */
                        ret = state->config->request_firmware(fe, &fw, TDA10045_DEFAULT_FIRMWARE);
                        if (ret) {
-                               printk(KERN_ERR "tda1004x: no firmware upload (timeout or file not found?)\n");
                                return ret;
                        } else {
                                printk(KERN_INFO "tda1004x: please rename the firmware file to %s\n",
index 685c0ac71819e917d9c010c11313dbd67bcc12f5..60ee1f6ed146805617c97b1331a853b7a048441f 100644 (file)
@@ -838,12 +838,8 @@ static int tda10071_init(struct dvb_frontend *fe)
 
                /* request the firmware, this will block and timeout */
                ret = request_firmware(&fw, fw_file, &client->dev);
-               if (ret) {
-                       dev_err(&client->dev,
-                               "did not find the firmware file '%s' (status %d). You can use <kernel_dir>/scripts/get_dvb_firmware to get the firmware\n",
-                               fw_file, ret);
+               if (ret)
                        goto error;
-               }
 
                /* init */
                for (i = 0; i < ARRAY_SIZE(tab2); i++) {
index 02df45ccf57c3abe8eb6ae308da6d7552bd113ad..9ce75298c6ec8a7c3f2ae9c4cd3c558d4926386d 100644 (file)
@@ -113,10 +113,8 @@ int cx25840_loadfw(struct i2c_client *client)
        if (is_cx231xx(state) && max_buf_size > 16)
                max_buf_size = 16;
 
-       if (request_firmware(&fw, fwname, FWDEV(client)) != 0) {
-               v4l_err(client, "unable to open firmware %s\n", fwname);
+       if (request_firmware(&fw, fwname, FWDEV(client)) != 0)
                return -EINVAL;
-       }
 
        start_fw_load(client);
 
index c2b5ab287dd74e51c5680deef844f37b2792d3a9..2762a5d16494f73b535c2bc5df80df62764d5068 100644 (file)
@@ -3904,10 +3904,8 @@ static int pvr_boot(struct bttv *btv)
        int rc;
 
        rc = request_firmware(&fw_entry, "hcwamc.rbf", &btv->c.pci->dev);
-       if (rc != 0) {
-               pr_warn("%d: no altera firmware [via hotplug]\n", btv->c.nr);
+       if (rc != 0)
                return rc;
-       }
        rc = pvr_altera_load(btv, fw_entry->data, fw_entry->size);
        pr_info("%d: altera firmware upload %s\n",
                btv->c.nr, (rc < 0) ? "failed" : "ok");
index 61aeb8c9af7f835195be56db17605f804f299db9..b93b04885e0aff4559a09ede1c1a14ca70ba25f9 100644 (file)
@@ -70,10 +70,8 @@ int cx18_av_loadfw(struct cx18 *cx)
        int i;
        int retries1 = 0;
 
-       if (request_firmware(&fw, FWFILE, &cx->pci_dev->dev) != 0) {
-               CX18_ERR_DEV(sd, "unable to open firmware %s\n", FWFILE);
+       if (request_firmware(&fw, FWFILE, &cx->pci_dev->dev) != 0)
                return -EINVAL;
-       }
 
        /* The firmware load often has byte errors, so allow for several
           retries, both at byte level and at the firmware load level. */
index 4c57a294b9fa73301d1cc9efae5239132ecc2df8..5d4a00c8e2891c37379cdf3fd2258ac19b2ec885 100644 (file)
@@ -127,9 +127,7 @@ static int yuan_mpc718_mt352_reqfw(struct cx18_stream *stream,
        int ret;
 
        ret = request_firmware(fw, fn, &cx->pci_dev->dev);
-       if (ret)
-               CX18_ERR("Unable to open firmware file %s\n", fn);
-       else {
+       if (!ret) {
                size_t sz = (*fw)->size;
                if (sz < 2 || sz > 64 || (sz % 2) != 0) {
                        CX18_ERR("Firmware %s has a bad size: %lu bytes\n",
index fdac310d74775de52542db0771c318ce88a045c9..f674c05437c114ca74ef0487f9361075ab8eeb79 100644 (file)
@@ -92,11 +92,8 @@ static int load_cpu_fw_direct(const char *fn, u8 __iomem *mem, struct cx18 *cx)
        u32 __iomem *dst = (u32 __iomem *)mem;
        const u32 *src;
 
-       if (request_firmware(&fw, fn, &cx->pci_dev->dev)) {
-               CX18_ERR("Unable to open firmware %s\n", fn);
-               CX18_ERR("Did you put the firmware in the hotplug firmware directory?\n");
+       if (request_firmware(&fw, fn, &cx->pci_dev->dev))
                return -ENOMEM;
-       }
 
        src = (const u32 *)fw->data;
 
@@ -137,8 +134,6 @@ static int load_apu_fw_direct(const char *fn, u8 __iomem *dst, struct cx18 *cx,
        int sz;
 
        if (request_firmware(&fw, fn, &cx->pci_dev->dev)) {
-               CX18_ERR("unable to open firmware %s\n", fn);
-               CX18_ERR("did you put the firmware in the hotplug firmware directory?\n");
                cx18_setup_page(cx, 0);
                return -ENOMEM;
        }
index 434677bd4ad17d88a380e23b04adfe9acf731516..ccf477b778b50d5f8f7dcabab97e89720ced5680 100644 (file)
@@ -920,12 +920,8 @@ static int cx23885_load_firmware(struct cx23885_dev *dev)
        retval = request_firmware(&firmware, CX23885_FIRM_IMAGE_NAME,
                                  &dev->pci->dev);
 
-       if (retval != 0) {
-               pr_err("ERROR: Hotplug firmware request failed (%s).\n",
-                      CX23885_FIRM_IMAGE_NAME);
-               pr_err("Please fix your hotplug setup, the board will not work without firmware loaded!\n");
+       if (retval != 0)
                return -1;
-       }
 
        if (firmware->size != CX23885_FIRM_IMAGE_SIZE) {
                pr_err("ERROR: Firmware size mismatch (have %zu, expected %d)\n",
index 0160f909f38c2ddb0ac85c038e03b3e1a13c043b..3ba0494fd37abc2f9abbd0ce90f2410bf83df53f 100644 (file)
@@ -2480,10 +2480,7 @@ void cx23885_card_setup(struct cx23885_dev *dev)
                        cinfo.rev, filename);
 
                ret = request_firmware(&fw, filename, &dev->pci->dev);
-               if (ret != 0)
-                       pr_err("did not find the firmware file '%s'. You can use <kernel_dir>/scripts/get_dvb_firmware to get the firmware.",
-                              filename);
-               else
+               if (ret == 0)
                        altera_init(&netup_config, fw);
 
                release_firmware(fw);
index d5da3bd5695d734b6673be2311641e77621cd6f4..380cc33b3721aac2a42dc7bd72cc78bd1a7203ca 100644 (file)
@@ -462,12 +462,8 @@ static int blackbird_load_firmware(struct cx8802_dev *dev)
        retval = request_firmware(&firmware, CX2341X_FIRM_ENC_FILENAME,
                                  &dev->pci->dev);
 
-       if (retval != 0) {
-               pr_err("Hotplug firmware request failed (%s).\n",
-                      CX2341X_FIRM_ENC_FILENAME);
-               pr_err("Please fix your hotplug setup, the board will not work without firmware loaded!\n");
+       if (retval != 0)
                return -EIO;
-       }
 
        if (firmware->size != BLACKBIRD_FIRM_IMAGE_SIZE) {
                pr_err("Firmware size mismatch (have %zd, expected %d)\n",
index 56b25255faf5eb27ee42d71465438aedb4791791..ee9c227c4ec3b1352ed63707c210e421f6c9eed7 100644 (file)
@@ -68,8 +68,6 @@ retry:
                release_firmware(fw);
                return size;
        }
-       IVTV_ERR("Unable to open firmware %s (must be %ld bytes)\n", fn, size);
-       IVTV_ERR("Did you put the firmware in the hotplug firmware directory?\n");
        return -ENOMEM;
 }
 
index 7481f553f95958c4eaea090a374e22021fcceaa1..9cebe2188b9d23c6818fedc2830d09aa43017aba 100644 (file)
@@ -1236,19 +1236,14 @@ static int ngene_load_firm(struct ngene *dev)
                break;
        }
 
-       if (request_firmware(&fw, fw_name, &dev->pci_dev->dev) < 0) {
-               dev_err(pdev, "Could not load firmware file %s.\n", fw_name);
-               dev_info(pdev, "Copy %s to your hotplug directory!\n",
-                        fw_name);
+       if (request_firmware(&fw, fw_name, &dev->pci_dev->dev))
                return -1;
-       }
        if (size == 0)
                size = fw->size;
        if (size != fw->size) {
                dev_err(pdev, "Firmware %s has invalid size!", fw_name);
                err = -1;
        } else {
-               dev_info(pdev, "Loading firmware file %s.\n", fw_name);
                ngene_fw = (u8 *) fw->data;
                err = ngene_command_load_firmware(dev, ngene_fw, size);
        }
index 363689484c54a32d6892e78d808c72713d58f536..447fa2dab1b5d364236bb8cb67d9e0c714345571 100644 (file)
@@ -406,11 +406,8 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
                        __func__, fwname);
 
                ret = request_firmware(&fw, fwname, &dev->pci->dev);
-               if (ret) {
-                       printk(KERN_ERR "%s() Upload failed. (file not found?)\n",
-                              __func__);
+               if (ret)
                        return -ENOMEM;
-               }
 
                printk(KERN_INFO "%s() firmware read %zu bytes.\n",
                        __func__, fw->size);
index da138c314963aba04eac10a5dc908675aadd73b6..226a1a2ecfbd77a7d23039c1085a5bc9d4c87e5e 100644 (file)
@@ -65,10 +65,8 @@ int s5p_mfc_load_firmware(struct s5p_mfc_dev *dev)
                }
        }
 
-       if (err != 0) {
-               mfc_err("Firmware is not present in the /lib/firmware directory nor compiled in kernel\n");
+       if (err != 0)
                return -EINVAL;
-       }
        if (fw_blob->size > dev->fw_buf.size) {
                mfc_err("MFC firmware is too big to be loaded\n");
                release_firmware(fw_blob);
index 484046471c03f8c1b1defe24006793e538221e4d..2a0f0e17d67cf68cfa2ab4cd487268c6c6665436 100644 (file)
@@ -502,11 +502,8 @@ static int wl1273_fm_upload_firmware_patch(struct wl1273_device *radio)
         * Uploading the firmware patch is not always necessary,
         * so we only print an info message.
         */
-       if (request_firmware(&fw_p, fw_name, dev)) {
-               dev_info(dev, "%s - %s not found\n", __func__, fw_name);
-
+       if (request_firmware(&fw_p, fw_name, dev))
                return 0;
-       }
 
        ptr = (__u8 *) fw_p->data;
        packet_num = ptr[0];
index 6142484d5cb4ef7a386ccfd149ef535632b945f1..9ea7fab318d43eef968a08da1a6ad62a4022657f 100644 (file)
@@ -1240,10 +1240,8 @@ static int fm_download_firmware(struct fmdev *fmdev, const u8 *fw_name)
 
        ret = request_firmware(&fw_entry, fw_name,
                                &fmdev->radio_dev->dev);
-       if (ret < 0) {
-               fmerr("Unable to read firmware(%s) content\n", fw_name);
+       if (ret)
                return ret;
-       }
        fmdbg("Firmware(%s) length : %zu bytes\n", fw_name, fw_entry->size);
 
        fw_data = (void *)fw_entry->data;
index 574c3bb135d7250f8c10144d8cf3f2b0ac8e8ab3..16ce85a02480ff44f4b0f8180b36dcbd73783adc 100644 (file)
@@ -1366,7 +1366,6 @@ static void load_firmware_cb(const struct firmware *fw,
 
        tuner_dbg("request_firmware_nowait(): %s\n", fw ? "OK" : "error");
        if (!fw) {
-               tuner_err("Could not load firmware %s.\n", priv->fname);
                priv->state = XC2028_NODEV;
                return;
        }
index b5a2d06fb356b302479fd32f5e03b4e6f10ac531..84c54e212c8bfca2c3fc9d8d4f883335e94a6269 100644 (file)
@@ -912,11 +912,8 @@ static int apply_vp_patch(struct camera_data *cam)
        struct cpia2_command cmd;
 
        ret = request_firmware(&fw, fw_name, &cam->dev->dev);
-       if (ret) {
-               printk(KERN_ERR "cpia2: failed to load VP patch \"%s\"\n",
-                      fw_name);
+       if (ret)
                return ret;
-       }
 
        cmd.req_mode = CAMERAACCESS_TYPE_REPEAT | CAMERAACCESS_VP;
        cmd.direction = TRANSFER_WRITE;
index c5e21785fafe286501597ab385fa941cbc8015e7..ec45e60189fb78d9a4fc8b5f95393a3891417b3b 100644 (file)
@@ -983,11 +983,6 @@ static int cx231xx_load_firmware(struct cx231xx *dev)
                                  dev->dev);
 
        if (retval != 0) {
-               dev_err(dev->dev,
-                       "ERROR: Hotplug firmware request failed (%s).\n",
-                       CX231xx_FIRM_IMAGE_NAME);
-               dev_err(dev->dev,
-                       "Please fix your hotplug setup, the board will not work without firmware loaded!\n");
                vfree(p_current_fw);
                vfree(p_buffer);
                return retval;
index 710c1afe3e85c25e994882cdf6d0513bc4dee5e1..6b437242027c1f5c5684ec905438afe2325fe8aa 100644 (file)
@@ -2408,12 +2408,9 @@ static int stk9090m_frontend_attach(struct dvb_usb_adapter *adap)
 
        dib9000_i2c_enumeration(&adap->dev->i2c_adap, 1, 0x10, 0x80);
 
-       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev)) {
-               deb_info("%s: Upload failed. (file not found?)\n", __func__);
+       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev))
                return -ENODEV;
-       } else {
-               deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
-       }
+       deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
        stk9090m_config.microcode_B_fe_size = state->frontend_firmware->size;
        stk9090m_config.microcode_B_fe_buffer = state->frontend_firmware->data;
 
@@ -2478,12 +2475,9 @@ static int nim9090md_frontend_attach(struct dvb_usb_adapter *adap)
        msleep(20);
        dib0700_set_gpio(adap->dev, GPIO0, GPIO_OUT, 1);
 
-       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev)) {
-               deb_info("%s: Upload failed. (file not found?)\n", __func__);
+       if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev))
                return -EIO;
-       } else {
-               deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
-       }
+       deb_info("%s: firmware read %zu bytes.\n", __func__, state->frontend_firmware->size);
        nim9090md_config[0].microcode_B_fe_size = state->frontend_firmware->size;
        nim9090md_config[0].microcode_B_fe_buffer = state->frontend_firmware->data;
        nim9090md_config[1].microcode_B_fe_size = state->frontend_firmware->size;
index 0fb3fa6100e4aa3867f581275c729d2402ff5b30..9788f48f99f22d76b264c4c3e90c40096186f43b 100644 (file)
@@ -90,13 +90,9 @@ int dvb_usb_download_firmware(struct usb_device *udev,
        int ret;
        const struct firmware *fw = NULL;
 
-       if ((ret = request_firmware(&fw, props->firmware, &udev->dev)) != 0) {
-               err("did not find the firmware file '%s' (status %d). You can use <kernel_dir>/scripts/get_dvb_firmware to get the firmware",
-                       props->firmware,ret);
+       ret = request_firmware(&fw, props->firmware, &udev->dev);
+       if (ret)
                return ret;
-       }
-
-       info("downloading firmware from file '%s'",props->firmware);
 
        switch (props->usb_ctrl) {
                case CYPRESS_AN2135:
index b4f661bb56481689ce3d6ca21d303205c5f15a70..f866b6ad0579a5fd06e3af2050437880c150e7b9 100644 (file)
@@ -131,19 +131,14 @@ static int gp8psk_load_bcm4500fw(struct dvb_usb_device *d)
        const u8 *ptr;
        u8 *buf;
        if ((ret = request_firmware(&fw, bcm4500_firmware,
-                                       &d->udev->dev)) != 0) {
-               err("did not find the bcm4500 firmware file '%s' (status %d). You can use <kernel_dir>/scripts/get_dvb_firmware to get the firmware",
-                       bcm4500_firmware,ret);
+                                       &d->udev->dev)) != 0)
                return ret;
-       }
 
        ret = -EINVAL;
 
        if (gp8psk_usb_out_op(d, LOAD_BCM4500,1,0,NULL, 0))
                goto out_rel_fw;
 
-       info("downloading bcm4500 firmware from file '%s'",bcm4500_firmware);
-
        ptr = fw->data;
        buf = kmalloc(64, GFP_KERNEL);
        if (!buf) {
index e8d784b9d1194b1677812bc3047bc307bf5df5fc..d11fefab842fb8d7b81185c8a35f2025f281f877 100644 (file)
@@ -450,8 +450,6 @@ static int opera1_xilinx_load_firmware(struct usb_device *dev,
        info("start downloading fpga firmware %s",filename);
 
        if ((ret = request_firmware(&fw, filename, &dev->dev)) != 0) {
-               err("did not find the firmware file '%s'. You can use <kernel_dir>/scripts/get_dvb_firmware to get the firmware",
-                       filename);
                return ret;
        } else {
                p = kmalloc(fw->size, GFP_KERNEL);
index 6650eab913d815567c9963daec605fa2f9ca0d81..28eb5b0b3266bdd8321ffd88efdb05d567f62d6a 100644 (file)
@@ -84,10 +84,8 @@ static int go7007_load_encoder(struct go7007 *go)
        u16 intr_val, intr_data;
 
        if (go->boot_fw == NULL) {
-               if (request_firmware(&fw_entry, fw_name, go->dev)) {
-                       v4l2_err(go, "unable to load firmware from file \"%s\"\n", fw_name);
+               if (request_firmware(&fw_entry, fw_name, go->dev))
                        return -1;
-               }
                if (fw_entry->size < 16 || memcmp(fw_entry->data, "WISGO7007FW", 11)) {
                        v4l2_err(go, "file \"%s\" does not appear to be go7007 firmware\n", fw_name);
                        release_firmware(fw_entry);
index 018019ba47d46e9638a33dbc135e333e3b48c79a..2226047843c7b1d3b0c2ca06fbadc828c3d180b2 100644 (file)
@@ -1565,12 +1565,8 @@ int go7007_construct_fw_image(struct go7007 *go, u8 **fw, int *fwlen)
        default:
                return -1;
        }
-       if (request_firmware(&fw_entry, GO7007_FW_NAME, go->dev)) {
-               dev_err(go->dev,
-                       "unable to load firmware from file \"%s\"\n",
-                       GO7007_FW_NAME);
+       if (request_firmware(&fw_entry, GO7007_FW_NAME, go->dev))
                return -1;
-       }
        code = kcalloc(codespace, 2, GFP_KERNEL);
        if (code == NULL)
                goto fw_failed;
index 243aa0ad074c8527002f3656022b6647967bc0a8..575bddaa61db1ce9620748fcf4ebb69347146baf 100644 (file)
@@ -67,11 +67,8 @@ static int go7007_loader_probe(struct usb_interface *interface,
 
        dev_info(&interface->dev, "loading firmware %s\n", fw1);
 
-       if (request_firmware(&fw, fw1, &usbdev->dev)) {
-               dev_err(&interface->dev,
-                       "unable to load firmware from file \"%s\"\n", fw1);
+       if (request_firmware(&fw, fw1, &usbdev->dev))
                goto failed2;
-       }
        ret = cypress_load_firmware(usbdev, fw, CYPRESS_FX2);
        release_firmware(fw);
        if (0 != ret) {
@@ -82,11 +79,8 @@ static int go7007_loader_probe(struct usb_interface *interface,
        if (fw2 == NULL)
                return 0;
 
-       if (request_firmware(&fw, fw2, &usbdev->dev)) {
-               dev_err(&interface->dev,
-                       "unable to load firmware from file \"%s\"\n", fw2);
+       if (request_firmware(&fw, fw2, &usbdev->dev))
                goto failed2;
-       }
        ret = cypress_load_firmware(usbdev, fw, CYPRESS_FX2);
        release_firmware(fw);
        if (0 != ret) {
index d98343fd33fe34b59b91eaba7229f2ee7fd78628..4dd7558390a1b56b08a78a7e1151079398abbe16 100644 (file)
@@ -230,10 +230,8 @@ static int sd_init(struct gspca_dev *gspca_dev)
 
        ret = request_ihex_firmware(&fw, VICAM_FIRMWARE,
                                    &gspca_dev->dev->dev);
-       if (ret) {
-               pr_err("Failed to load \"vicam/firmware.fw\": %d\n", ret);
+       if (ret)
                return ret;
-       }
 
        firmware_buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
        if (!firmware_buf) {
index 3915d551d59e7b2f564a2d222d5ee9d21cf1028b..e838191b96b10d4ff0878b72a78fcdc2607a524a 100644 (file)
@@ -1370,25 +1370,6 @@ static int pvr2_locate_firmware(struct pvr2_hdw *hdw,
                           "request_firmware fatal error with code=%d",ret);
                return ret;
        }
-       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                  "***WARNING*** Device %s firmware seems to be missing.",
-                  fwtypename);
-       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                  "Did you install the pvrusb2 firmware files in their proper location?");
-       if (fwcount == 1) {
-               pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                          "request_firmware unable to locate %s file %s",
-                          fwtypename,fwnames[0]);
-       } else {
-               pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                          "request_firmware unable to locate one of the following %s files:",
-                          fwtypename);
-               for (idx = 0; idx < fwcount; idx++) {
-                       pvr2_trace(PVR2_TRACE_ERROR_LEGS,
-                                  "request_firmware: Failed to find %s",
-                                  fwnames[idx]);
-               }
-       }
        return ret;
 }
 
index acf18e2251a5228b5085266bccc60175a8ecac52..ef66901c563a08ad9ac2bc4e96d1ca3f0c90dfda 100644 (file)
@@ -2276,10 +2276,8 @@ static int s2255_probe(struct usb_interface *interface,
        }
        /* load the first chunk */
        if (request_firmware(&dev->fw_data->fw,
-                            FIRMWARE_FILE_NAME, &dev->udev->dev)) {
-               dev_err(&interface->dev, "sensoray 2255 failed to get firmware\n");
+                            FIRMWARE_FILE_NAME, &dev->udev->dev))
                goto errorREQFW;
-       }
        /* check the firmware is valid */
        fw_size = dev->fw_data->fw->size;
        pdata = (__le32 *) &dev->fw_data->fw->data[fw_size - 8];
index 9e016b71aa9124fc70b40a409dc8f51682c9b512..e258ad3ad43d34940e21df560873d0856150db38 100644 (file)
@@ -282,10 +282,8 @@ static int ttusb_boot_dsp(struct ttusb *ttusb)
 
        err = request_firmware(&fw, "ttusb-budget/dspbootcode.bin",
                               &ttusb->dev->dev);
-       if (err) {
-               pr_err("failed to request firmware\n");
+       if (err)
                return err;
-       }
 
        /* BootBlock */
        b[0] = 0xaa;
index 38822cedd93a97c23486de57fa8931f9723f92fa..7380ed5fc59ac412c77bddd7faeab27488b51bab 100644 (file)
@@ -1317,11 +1317,8 @@ static int ttusb_dec_boot_dsp(struct ttusb_dec *dec)
        dprintk("%s\n", __func__);
 
        result = request_firmware(&fw_entry, dec->firmware_name, &dec->udev->dev);
-       if (result) {
-               printk(KERN_ERR "%s: Firmware (%s) unavailable.\n",
-                      __func__, dec->firmware_name);
+       if (result)
                return result;
-       }
 
        firmware = fw_entry->data;
        firmware_size = fw_entry->size;
index f2f6cab97c086445a10126ad92b6f7a052e86208..1f2c7fae797a89484c33c4f61f5a98f1b09abc4e 100644 (file)
@@ -295,11 +295,8 @@ static long download_firmware(struct kim_data_s *kim_gdata)
            request_firmware(&kim_gdata->fw_entry, bts_scr_name,
                             &kim_gdata->kim_pdev->dev);
        if (unlikely((err != 0) || (kim_gdata->fw_entry->data == NULL) ||
-                    (kim_gdata->fw_entry->size == 0))) {
-               pr_err(" request_firmware failed(errno %ld) for %s", err,
-                          bts_scr_name);
+                    (kim_gdata->fw_entry->size == 0)))
                return -EINVAL;
-       }
        ptr = (void *)kim_gdata->fw_entry->data;
        len = kim_gdata->fw_entry->size;
        /*
index 32286f861a19561ef6ca8e52c71b2eb8cfc66811..eaa76d033bce0259d5f4fe9d6e7fdc0c0657cddd 100644 (file)
@@ -226,11 +226,8 @@ int softing_load_app_fw(const char *file, struct softing *card)
        int8_t type_end = 0, type_entrypoint = 0;
 
        ret = request_firmware(&fw, file, &card->pdev->dev);
-       if (ret) {
-               dev_alert(&card->pdev->dev, "request_firmware(%s) got %i\n",
-                       file, ret);
+       if (ret)
                return ret;
-       }
        dev_dbg(&card->pdev->dev, "firmware(%s) got %lu bytes\n",
                file, (unsigned long)fw->size);
        /* parse the firmware */
index 05e15b6e5e2c728e54c48aa113572433a3e0b6f1..56b3d64243cda5ffbd26ad354e043917b04459c2 100644 (file)
@@ -1282,11 +1282,8 @@ typhoon_request_firmware(struct typhoon *tp)
                return 0;
 
        err = request_firmware(&typhoon_fw, FIRMWARE_NAME, &tp->pdev->dev);
-       if (err) {
-               netdev_err(tp->dev, "Failed to load firmware \"%s\"\n",
-                          FIRMWARE_NAME);
+       if (err)
                return err;
-       }
 
        image_data = typhoon_fw->data;
        remaining = typhoon_fw->size;
index c6982f7caf9b47c4ccb0ed1436fa110e9a40308f..ab6ecdd7c5147f126b99cd6446f69fe50af4fc32 100644 (file)
@@ -1004,11 +1004,8 @@ static int netdev_open(struct net_device *dev)
 #endif /* VLAN_SUPPORT */
 
        retval = request_firmware(&fw_rx, FIRMWARE_RX, &np->pci_dev->dev);
-       if (retval) {
-               printk(KERN_ERR "starfire: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_RX);
+       if (retval)
                goto out_init;
-       }
        if (fw_rx->size % 4) {
                printk(KERN_ERR "starfire: bogus length %zu in \"%s\"\n",
                       fw_rx->size, FIRMWARE_RX);
@@ -1016,11 +1013,8 @@ static int netdev_open(struct net_device *dev)
                goto out_rx;
        }
        retval = request_firmware(&fw_tx, FIRMWARE_TX, &np->pci_dev->dev);
-       if (retval) {
-               printk(KERN_ERR "starfire: Failed to load firmware \"%s\"\n",
-                      FIRMWARE_TX);
+       if (retval)
                goto out_rx;
-       }
        if (fw_tx->size % 4) {
                printk(KERN_ERR "starfire: bogus length %zu in \"%s\"\n",
                       fw_tx->size, FIRMWARE_TX);
index 1fc9a1cd3ef8f7bd59c0b1919ec50fd767b166e3..58a388693ceb414271803b2cc30bd1990c6111b9 100644 (file)
@@ -1051,11 +1051,8 @@ static int slic_load_rcvseq_firmware(struct slic_device *sdev)
        file = (sdev->model == SLIC_MODEL_OASIS) ?  SLIC_RCV_FIRMWARE_OASIS :
                                                    SLIC_RCV_FIRMWARE_MOJAVE;
        err = request_firmware(&fw, file, &sdev->pdev->dev);
-       if (err) {
-               dev_err(&sdev->pdev->dev,
-                       "failed to load receive sequencer firmware %s\n", file);
+       if (err)
                return err;
-       }
        /* Do an initial sanity check concerning firmware size now. A further
         * check follows below.
         */
@@ -1126,10 +1123,8 @@ static int slic_load_firmware(struct slic_device *sdev)
        file = (sdev->model == SLIC_MODEL_OASIS) ?  SLIC_FIRMWARE_OASIS :
                                                    SLIC_FIRMWARE_MOJAVE;
        err = request_firmware(&fw, file, &sdev->pdev->dev);
-       if (err) {
-               dev_err(&sdev->pdev->dev, "failed to load firmware %s\n", file);
+       if (err)
                return err;
-       }
        /* Do an initial sanity check concerning firmware size now. A further
         * check follows below.
         */
index 732da15a382743e79aa358f01bd0c8cab76bb986..dcc9aebd5d3a97425a4565a164b3c917aac9479d 100644 (file)
@@ -2883,11 +2883,8 @@ static int ace_load_firmware(struct net_device *dev)
                fw_name = "acenic/tg1.bin";
 
        ret = request_firmware(&fw, fw_name, &ap->pdev->dev);
-       if (ret) {
-               printk(KERN_ERR "%s: Failed to load firmware \"%s\"\n",
-                      ap->name, fw_name);
+       if (ret)
                return ret;
-       }
 
        fw_data = (void *)fw->data;
 
index b47a8237c6dd811028f8f9e255c444324b0a7ca8..f0a18e15d4fdd993e72315f20ea7ca11f14d9777 100644 (file)
@@ -3712,16 +3712,13 @@ static int bnx2_request_uncached_firmware(struct bnx2 *bp)
        }
 
        rc = request_firmware(&bp->mips_firmware, mips_fw_file, &bp->pdev->dev);
-       if (rc) {
-               pr_err("Can't load firmware file \"%s\"\n", mips_fw_file);
+       if (rc)
                goto out;
-       }
 
        rc = request_firmware(&bp->rv2p_firmware, rv2p_fw_file, &bp->pdev->dev);
-       if (rc) {
-               pr_err("Can't load firmware file \"%s\"\n", rv2p_fw_file);
+       if (rc)
                goto err_release_mips_firmware;
-       }
+
        mips_fw = (const struct bnx2_mips_fw_file *) bp->mips_firmware->data;
        rv2p_fw = (const struct bnx2_rv2p_fw_file *) bp->rv2p_firmware->data;
        if (bp->mips_firmware->size < sizeof(*mips_fw) ||
index 85ca3909859d2d4f5d8f08f030c7d0b811af1bf6..fba8cd256f5c9af0b25ca64d9efffb22630917fe 100644 (file)
@@ -11398,11 +11398,8 @@ static int tg3_request_firmware(struct tg3 *tp)
 {
        const struct tg3_firmware_hdr *fw_hdr;
 
-       if (request_firmware(&tp->fw, tp->fw_needed, &tp->pdev->dev)) {
-               netdev_err(tp->dev, "Failed to load firmware \"%s\"\n",
-                          tp->fw_needed);
+       if (request_firmware(&tp->fw, tp->fw_needed, &tp->pdev->dev))
                return -ENOENT;
-       }
 
        fw_hdr = (struct tg3_firmware_hdr *)tp->fw->data;
 
index 824eaef307043883a4ad9fca175f503ef1dc79d7..17b9de83a281b7aaeac3e79185fc91ec45e8dcfb 100644 (file)
@@ -24,10 +24,8 @@ cna_read_firmware(struct pci_dev *pdev, u32 **bfi_image,
        const struct firmware *fw;
        u32 n;
 
-       if (request_firmware(&fw, fw_name, &pdev->dev)) {
-               dev_alert(&pdev->dev, "can't load firmware %s\n", fw_name);
+       if (request_firmware(&fw, fw_name, &pdev->dev))
                goto error;
-       }
 
        *bfi_image = (u32 *)fw->data;
        *bfi_image_size = fw->size/sizeof(u32);
index bfffcaeee62413ad64fc0060fd5fce5e0d49fbd0..5f1c01ac271f7ac71c8d935805417f9628389b25 100644 (file)
@@ -1036,12 +1036,8 @@ int t3_get_edc_fw(struct cphy *phy, int edc_idx, int size)
        fw_name = get_edc_fw_name(edc_idx);
        if (fw_name)
                ret = request_firmware(&fw, fw_name, &adapter->pdev->dev);
-       if (ret < 0) {
-               dev_err(&adapter->pdev->dev,
-                       "could not upgrade firmware: unable to load %s\n",
-                       fw_name);
+       if (ret)
                return ret;
-       }
 
        /* check size, take checksum in account */
        if (fw->size > size + 4) {
@@ -1078,11 +1074,8 @@ static int upgrade_fw(struct adapter *adap)
        struct device *dev = &adap->pdev->dev;
 
        ret = request_firmware(&fw, FW_FNAME, dev);
-       if (ret < 0) {
-               dev_err(dev, "could not upgrade firmware: unable to load %s\n",
-                       FW_FNAME);
+       if (ret)
                return ret;
-       }
        ret = t3_load_fw(adap, fw->data, fw->size);
        release_firmware(fw);
 
@@ -1127,11 +1120,8 @@ static int update_tpsram(struct adapter *adap)
        snprintf(buf, sizeof(buf), TPSRAM_NAME, rev);
 
        ret = request_firmware(&tpsram, buf, dev);
-       if (ret < 0) {
-               dev_err(dev, "could not load TP SRAM: unable to load %s\n",
-                       buf);
+       if (ret)
                return ret;
-       }
 
        ret = t3_check_tpsram(adap, tpsram->data, tpsram->size);
        if (ret)
index 0bf3d47bb90dc9a8919d45c47cc498ba70d4826a..3e88e11fec74ae793e8020e7011925521776e878 100644 (file)
@@ -1262,9 +1262,6 @@ static const struct firmware *e100_request_firmware(struct nic *nic)
 
        if (err) {
                if (required) {
-                       netif_err(nic, probe, nic->netdev,
-                                 "Failed to load firmware \"%s\": %d\n",
-                                 fw_name, err);
                        return ERR_PTR(err);
                } else {
                        netif_info(nic, probe, nic->netdev,
index 5736fcdafd7a02f62834ec9b153b4165761625a1..36ebaba04c3ba87ede6dc200cedd556199b1a155 100644 (file)
@@ -580,8 +580,6 @@ static int myri10ge_load_hotplug_firmware(struct myri10ge_priv *mgp, u32 * size)
        unsigned i;
 
        if ((status = request_firmware(&fw, mgp->fw_name, dev)) < 0) {
-               dev_err(dev, "Unable to load %s firmware image via hotplug\n",
-                       mgp->fw_name);
                status = -EINVAL;
                goto abort_with_nothing;
        }
index 37c822e27207a000e81e5ae9c6349a4bdaa78b77..042fc454df14d6aaae11567fcaf155f0117a4573 100644 (file)
@@ -651,10 +651,8 @@ static int osi_load_firmware(struct pcmcia_device *link)
        int i, err;
 
        err = request_firmware(&fw, FIRMWARE_NAME, &link->dev);
-       if (err) {
-               pr_err("Failed to load firmware \"%s\"\n", FIRMWARE_NAME);
+       if (err)
                return err;
-       }
 
        /* Download the Seven of Diamonds firmware */
        for (i = 0; i < fw->size; i++) {
index d2d4f47c7e28477d605980870266f16121fa374a..31202f2f8f8d40a82eae688498a2ee1047253609 100644 (file)
@@ -793,11 +793,8 @@ static void cas_saturn_firmware_init(struct cas *cp)
                return;
 
        err = request_firmware(&fw, fw_name, &cp->pdev->dev);
-       if (err) {
-               pr_err("Failed to load firmware \"%s\"\n",
-                      fw_name);
+       if (err)
                return;
-       }
        if (fw->size < 2) {
                pr_err("bogus length %zu in \"%s\"\n",
                       fw->size, fw_name);
index 980f2be32f05a1974c13aba7d44f257901ed8cd6..c1b39babd7fd0323e93b26990cabe401eb76f11e 100644 (file)
@@ -357,11 +357,8 @@ static unsigned char *add_mcs(unsigned char *bits, int bitrate,
                }
                err = request_firmware(&fw, fw_name[predef], &pdev->dev);
                platform_device_unregister(pdev);
-               if (err) {
-                       printk(KERN_ERR "Failed to load firmware \"%s\"\n",
-                              fw_name[predef]);
+               if (err)
                        return NULL;
-               }
                if (fw->size != YAM_FPGA_SIZE) {
                        printk(KERN_ERR "Bogus length %zu in firmware \"%s\"\n",
                               fw->size, fw_name[predef]);
index 9b2bc1993ece20f9cb1fed9b255dcf7025a4c6a0..1add54a39eb9dba99b6af2d3f4bb2c7a6aed573c 100644 (file)
@@ -305,10 +305,8 @@ static int kaweth_download_firmware(struct kaweth_device *kaweth,
        int ret;
 
        ret = request_firmware(&fw, fwname, &kaweth->dev->dev);
-       if (ret) {
-               dev_err(&kaweth->intf->dev, "Firmware request failed\n");
+       if (ret)
                return ret;
-       }
 
        if (fw->size > KAWETH_FIRMWARE_BUF_SIZE) {
                dev_err(&kaweth->intf->dev, "Firmware too big: %zu\n",
index f06eec99de688c87e42fb8379d339b7a7aa1d4d8..1e0827c30efb5fbbfd196eb3058054a895929088 100644 (file)
@@ -1223,9 +1223,6 @@ static void ath9k_hif_usb_firmware_cb(const struct firmware *fw, void *context)
                if (!ret)
                        return;
 
-               dev_err(&hif_dev->udev->dev,
-                       "ath9k_htc: Failed to get firmware %s\n",
-                       hif_dev->fw_name);
                goto err_fw;
        }
 
index e4eb666c6eea41ab51c5cf8c0c5e60a9db5f4ad7..84967b4f86f3b08e40d40eb59dc3b19166b281fe 100644 (file)
@@ -1029,7 +1029,6 @@ static void carl9170_usb_firmware_step2(const struct firmware *fw,
                return;
        }
 
-       dev_err(&ar->udev->dev, "firmware not found.\n");
        carl9170_usb_firmware_failed(ar);
 }
 
index 7582761c61e2c98165936ced97803f361767a1a7..79d071ec9102198866a78ca9a3bec87055289fc3 100644 (file)
@@ -1616,13 +1616,8 @@ static struct fwentry *at76_load_firmware(struct usb_device *udev,
 
        at76_dbg(DBG_FW, "downloading firmware %s", fwe->fwname);
        ret = request_firmware(&fwe->fw, fwe->fwname, &udev->dev);
-       if (ret < 0) {
-               dev_err(&udev->dev, "firmware %s not found!\n",
-                       fwe->fwname);
-               dev_err(&udev->dev,
-                       "you may need to download the firmware from http://developer.berlios.de/projects/at76c503a/\n");
+       if (ret)
                goto exit;
-       }
 
        at76_dbg(DBG_FW, "got it.");
        fwh = (struct at76_fw_header *)(fwe->fw->data);
index 35c2e798d98bd14a92c142cbf355a63bcffccfe7..5dadc061d3d4a1a17b1b8a8e55a7cd47fb78481b 100644 (file)
@@ -3896,12 +3896,8 @@ static int reset_atmel_card(struct net_device *dev)
                                        strcpy(priv->firmware_id, "atmel_at76c502.bin");
                                }
                                err = request_firmware(&fw_entry, priv->firmware_id, priv->sys_dev);
-                               if (err != 0) {
-                                       printk(KERN_ALERT
-                                              "%s: firmware %s is missing, cannot continue.\n",
-                                              dev->name, priv->firmware_id);
+                               if (err != 0)
                                        return err;
-                               }
                        } else {
                                int fw_index = 0;
                                int success = 0;
index 17bcec5f3ff752dfc41f4fa72877d530e032adda..92f8916c500160ed1643760d2548460c1ac1add7 100644 (file)
@@ -2245,19 +2245,8 @@ int b43_do_request_fw(struct b43_request_fw_context *ctx,
        }
        err = request_firmware(&ctx->blob, ctx->fwname,
                               ctx->dev->dev->dev);
-       if (err == -ENOENT) {
-               snprintf(ctx->errors[ctx->req_type],
-                        sizeof(ctx->errors[ctx->req_type]),
-                        "Firmware file \"%s\" not found\n",
-                        ctx->fwname);
-               return err;
-       } else if (err) {
-               snprintf(ctx->errors[ctx->req_type],
-                        sizeof(ctx->errors[ctx->req_type]),
-                        "Firmware file \"%s\" request failed (err=%d)\n",
-                        ctx->fwname, err);
+       if (err)
                return err;
-       }
 fw_ready:
        if (ctx->blob->size < sizeof(struct b43_fw_header))
                goto err_format;
index eec3af9c37451012b3483690e3445a42a073c8a9..db5a368c26fc9898e5a49cb2013f34e4483c66b8 100644 (file)
@@ -1524,11 +1524,8 @@ static int do_request_fw(struct b43legacy_wldev *dev,
        } else {
                err = request_firmware(fw, path, dev->dev->dev);
        }
-       if (err) {
-               b43legacyerr(dev->wl, "Firmware file \"%s\" not found "
-                      "or load failed.\n", path);
+       if (err)
                return err;
-       }
        if ((*fw)->size < sizeof(struct b43legacy_fw_header))
                goto err_format;
        hdr = (struct b43legacy_fw_header *)((*fw)->data);
index eadac0f5590fc823fcb077cd946f540e8ee758c8..d23b6d4d6b6264cc1aab983bcf91995247c9f3cb 100644 (file)
@@ -376,19 +376,13 @@ static int brcms_request_fw(struct brcms_info *wl, struct bcma_device *pdev)
                sprintf(fw_name, "%s-%d.fw", brcms_firmwares[i],
                        UCODE_LOADER_API_VER);
                status = request_firmware(&wl->fw.fw_bin[i], fw_name, device);
-               if (status) {
-                       wiphy_err(wl->wiphy, "%s: fail to load firmware %s\n",
-                                 KBUILD_MODNAME, fw_name);
+               if (status)
                        return status;
-               }
                sprintf(fw_name, "%s_hdr-%d.fw", brcms_firmwares[i],
                        UCODE_LOADER_API_VER);
                status = request_firmware(&wl->fw.fw_hdr[i], fw_name, device);
-               if (status) {
-                       wiphy_err(wl->wiphy, "%s: fail to load firmware %s\n",
-                                 KBUILD_MODNAME, fw_name);
+               if (status)
                        return status;
-               }
                wl->fw.hdr_num_entries[i] =
                    wl->fw.fw_hdr[i]->size / (sizeof(struct firmware_hdr));
        }
index 2ace2b27ecad280b77578bf62d93d572ffe02903..731fa60ab3f339361d260f17ba129261de796de7 100644 (file)
@@ -8370,12 +8370,8 @@ static int ipw2100_get_firmware(struct ipw2100_priv *priv,
 
        rc = request_firmware(&fw->fw_entry, fw_name, &priv->pci_dev->dev);
 
-       if (rc < 0) {
-               printk(KERN_ERR DRV_NAME ": "
-                      "%s: Firmware '%s' not available or load failed.\n",
-                      priv->net_dev->name, fw_name);
+       if (rc)
                return rc;
-       }
        IPW_DEBUG_INFO("firmware data %p size %zd\n", fw->fw_entry->data,
                       fw->fw_entry->size);
 
index 23037bfc9e4cbfb5183114610fb6701e4cd41fd3..dea23582881ed8a268d151e6dd4d45aefff76278 100644 (file)
@@ -3396,10 +3396,8 @@ static int ipw_get_fw(struct ipw_priv *priv,
 
        /* ask firmware_class module to get the boot firmware off disk */
        rc = request_firmware(raw, name, &priv->pci_dev->dev);
-       if (rc < 0) {
-               IPW_ERROR("%s request_firmware failed: Reason %d\n", name, rc);
+       if (rc)
                return rc;
-       }
 
        if ((*raw)->size < sizeof(*fw)) {
                IPW_ERROR("%s is too small (%zd)\n", name, (*raw)->size);
index bd4e7d75295836a7d15290a60296255e37e73050..a4874e54a9f21c03321e00626020d808660bb3a5 100644 (file)
@@ -1835,7 +1835,6 @@ il3945_read_ucode(struct il_priv *il)
                sprintf(buf, "%s%u%s", name_pre, idx, ".ucode");
                ret = request_firmware(&ucode_raw, buf, &il->pci_dev->dev);
                if (ret < 0) {
-                       IL_ERR("%s firmware file req failed: %d\n", buf, ret);
                        if (ret == -ENOENT)
                                continue;
                        else
index 506d05953314dc20365a661095b9daa1c1c1ec73..131bbba4b4ac61815eaf16df08b0c6fb9970be78 100644 (file)
@@ -183,8 +183,6 @@ static int iwl_request_firmware(struct iwl_drv *drv, bool first)
        }
 
        if (drv->fw_index < cfg->ucode_api_min) {
-               IWL_ERR(drv, "no suitable firmware found!\n");
-
                if (cfg->ucode_api_min == cfg->ucode_api_max) {
                        IWL_ERR(drv, "%s%d is required\n", cfg->fw_name_pre,
                                cfg->ucode_api_max);
index 015af782881bfdb959a702a8c3376b41c050a254..b8727000c415882617559f398701b5a0a87da7a0 100644 (file)
@@ -132,7 +132,6 @@ orinoco_dl_firmware(struct orinoco_private *priv,
                err = request_firmware(&fw_entry, firmware, priv->dev);
 
                if (err) {
-                       dev_err(dev, "Cannot find firmware %s\n", firmware);
                        err = -ENOENT;
                        goto free;
                }
@@ -292,10 +291,8 @@ symbol_dl_firmware(struct orinoco_private *priv,
        const struct firmware *fw_entry;
 
        if (!orinoco_cached_fw_get(priv, true)) {
-               if (request_firmware(&fw_entry, fw->pri_fw, priv->dev) != 0) {
-                       dev_err(dev, "Cannot find firmware: %s\n", fw->pri_fw);
+               if (request_firmware(&fw_entry, fw->pri_fw, priv->dev) != 0)
                        return -ENOENT;
-               }
        } else
                fw_entry = orinoco_cached_fw_get(priv, true);
 
@@ -311,10 +308,8 @@ symbol_dl_firmware(struct orinoco_private *priv,
        }
 
        if (!orinoco_cached_fw_get(priv, false)) {
-               if (request_firmware(&fw_entry, fw->sta_fw, priv->dev) != 0) {
-                       dev_err(dev, "Cannot find firmware: %s\n", fw->sta_fw);
+               if (request_firmware(&fw_entry, fw->sta_fw, priv->dev) != 0)
                        return -ENOENT;
-               }
        } else
                fw_entry = orinoco_cached_fw_get(priv, false);
 
index dd31929261ab9f280c4f5d38bb799df5b2b0481e..ad16ea7dec47c7dedb045dbb503cecd572951fc8 100644 (file)
@@ -1708,7 +1708,6 @@ static int ezusb_probe(struct usb_interface *interface,
                if (ezusb_firmware_download(upriv, &firmware) < 0)
                        goto error;
        } else {
-               err("No firmware to download");
                goto error;
        }
 
index e97ee547b9f39b0d1c6ab02bb5063f45523853fd..5e6fa6933cce2894e074060c2fe0708613d1eae7 100644 (file)
@@ -502,7 +502,6 @@ static void p54p_firmware_step2(const struct firmware *fw,
        int err;
 
        if (!fw) {
-               dev_err(&pdev->dev, "Cannot find firmware (isl3886pci)\n");
                err = -ENOENT;
                goto out;
        }
index ab0fe85658518120dfaf066c9b1293b0e8064583..9c57aab8a224f282346e18dca7b2043328f4badd 100644 (file)
@@ -157,10 +157,8 @@ static int p54spi_request_firmware(struct ieee80211_hw *dev)
        /* FIXME: should driver use it's own struct device? */
        ret = request_firmware(&priv->firmware, "3826.arm", &priv->spi->dev);
 
-       if (ret < 0) {
-               dev_err(&priv->spi->dev, "request_firmware() failed: %d", ret);
+       if (ret)
                return ret;
-       }
 
        ret = p54_parse_firmware(dev, priv->firmware);
        if (ret) {
index cae47663b17bc6e68ed60aa488fb0737ac66833c..9c2976b6352a38f04351bae1c8d437e86eecb506 100644 (file)
@@ -929,7 +929,6 @@ static void p54u_load_firmware_cb(const struct firmware *firmware,
                err = p54u_start_ops(priv);
        } else {
                err = -ENOENT;
-               dev_err(&udev->dev, "Firmware not found.\n");
        }
 
        complete(&priv->fw_wait_load);
index 75b5319d033f33577c9813a55973bf3cd325b5ed..07f45c537565e0e6e5add8a404f156843fdfdf22 100644 (file)
@@ -820,8 +820,6 @@ static int if_usb_prog_firmware(struct lbtf_private *priv)
        kernel_param_lock(THIS_MODULE);
        ret = request_firmware(&cardp->fw, lbtf_fw_name, &cardp->udev->dev);
        if (ret < 0) {
-               pr_err("request_firmware() failed with %#x\n", ret);
-               pr_err("firmware %s not found\n", lbtf_fw_name);
                kernel_param_unlock(THIS_MODULE);
                goto done;
        }
index 19b996c6a2605af90416d979f599636ba9bac630..47a5818ce2cb427064bcdb54e9325525f8c314fc 100644 (file)
@@ -543,11 +543,8 @@ static int _mwifiex_fw_dpc(const struct firmware *firmware, void *context)
        struct wireless_dev *wdev;
        struct completion *fw_done = adapter->fw_done;
 
-       if (!firmware) {
-               mwifiex_dbg(adapter, ERROR,
-                           "Failed to get firmware %s\n", adapter->fw_name);
+       if (!firmware)
                goto err_dnld_fw;
-       }
 
        memset(&fw, 0, sizeof(struct mwifiex_fw_image));
        adapter->firmware = firmware;
index 529e325498cdb00702a0adc1868aa18ab94bd980..c750c821e4e777100f648a645a93a324c8dda58a 100644 (file)
@@ -5732,16 +5732,12 @@ static int mwl8k_firmware_load_success(struct mwl8k_priv *priv);
 static void mwl8k_fw_state_machine(const struct firmware *fw, void *context)
 {
        struct mwl8k_priv *priv = context;
-       struct mwl8k_device_info *di = priv->device_info;
        int rc;
 
        switch (priv->fw_state) {
        case FW_STATE_INIT:
-               if (!fw) {
-                       printk(KERN_ERR "%s: Error requesting helper fw %s\n",
-                              pci_name(priv->pdev), di->helper_image);
+               if (!fw)
                        goto fail;
-               }
                priv->fw_helper = fw;
                rc = mwl8k_request_fw(priv, priv->fw_pref, &priv->fw_ucode,
                                      true);
@@ -5776,11 +5772,8 @@ static void mwl8k_fw_state_machine(const struct firmware *fw, void *context)
                break;
 
        case FW_STATE_LOADING_ALT:
-               if (!fw) {
-                       printk(KERN_ERR "%s: Error requesting alt fw %s\n",
-                              pci_name(priv->pdev), di->helper_image);
+               if (!fw)
                        goto fail;
-               }
                priv->fw_ucode = fw;
                rc = mwl8k_firmware_load_success(priv);
                if (rc)
@@ -5818,10 +5811,8 @@ retry:
 
        /* Ask userland hotplug daemon for the device firmware */
        rc = mwl8k_request_firmware(priv, fw_image, nowait);
-       if (rc) {
-               wiphy_err(hw->wiphy, "Firmware files not found\n");
+       if (rc)
                return rc;
-       }
 
        if (nowait)
                return rc;
index c20886b02e6446141c048243a31168b643341d75..e7ec16d56b4bc719f9037ec2fcf6a4888a092f24 100644 (file)
@@ -38,10 +38,8 @@ static int rt2x00lib_request_firmware(struct rt2x00_dev *rt2x00dev)
        rt2x00_info(rt2x00dev, "Loading firmware file '%s'\n", fw_name);
 
        retval = request_firmware(&fw, fw_name, device);
-       if (retval) {
-               rt2x00_err(rt2x00dev, "Failed to request Firmware\n");
+       if (retval)
                return retval;
-       }
 
        if (!fw || !fw->size || !fw->data) {
                rt2x00_err(rt2x00dev, "Failed to read Firmware\n");
index 8efe2f5e5b9f32a8b9f99d6a6576782aff017112..3566e2fbfe0abea931357433ead6008d4494b5cf 100644 (file)
@@ -88,7 +88,6 @@ static void rtl_fw_do_work(const struct firmware *firmware, void *context,
                        if (!err)
                                goto found_alt;
                }
-               pr_err("Selected firmware is not available\n");
                rtlpriv->max_fw_size = 0;
                goto exit;
        }
index 6d352a3161b8f79822708e5cd5f513e27075ef06..763ada6c6ba0ee3c72699d8453e23cfd133f0674 100644 (file)
@@ -63,13 +63,11 @@ static void rtl92se_fw_cb(const struct firmware *firmware, void *context)
        struct ieee80211_hw *hw = context;
        struct rtl_priv *rtlpriv = rtl_priv(hw);
        struct rt_firmware *pfirmware = NULL;
-       char *fw_name = "rtlwifi/rtl8192sefw.bin";
 
        rtl_dbg(rtlpriv, COMP_ERR, DBG_LOUD,
                "Firmware callback routine entered!\n");
        complete(&rtlpriv->firmware_loading_complete);
        if (!firmware) {
-               pr_err("Firmware %s not available\n", fw_name);
                rtlpriv->max_fw_size = 0;
                return;
        }
index 136a0d3b23c94e2620329425675fc9011ee8872b..bfc8be4537ef9ee8977a1fe864129d0aec8e2c7a 100644 (file)
@@ -57,10 +57,8 @@ static int wl1251_fetch_firmware(struct wl1251 *wl)
 
        ret = request_firmware(&fw, WL1251_FW_NAME, dev);
 
-       if (ret < 0) {
-               wl1251_error("could not get firmware: %d", ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1251_error("firmware size is not multiple of 32 bits: %zu",
@@ -96,10 +94,8 @@ static int wl1251_fetch_nvs(struct wl1251 *wl)
 
        ret = request_firmware(&fw, WL1251_NVS_NAME, dev);
 
-       if (ret < 0) {
-               wl1251_error("could not get nvs file: %d", ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1251_error("nvs size is not multiple of 32 bits: %zu",
index 5669f17b395f3aa117df84d4723ee782f13639fc..7933cceff414ec9647c873309c044ef7a96a4eb6 100644 (file)
@@ -764,10 +764,8 @@ static int wl12xx_fetch_firmware(struct wl1271 *wl, bool plt)
 
        ret = request_firmware(&fw, fw_name, wl->dev);
 
-       if (ret < 0) {
-               wl1271_error("could not get firmware %s: %d", fw_name, ret);
+       if (ret)
                return ret;
-       }
 
        if (fw->size % 4) {
                wl1271_error("firmware size is not multiple of 32 bits: %zu",
index e64e4e5795186c89d3e00ca2afd8b8f0bd24c084..fbffa9072060a75a163a7ea0496ce94ea2e61e69 100644 (file)
@@ -62,8 +62,6 @@ static int zd1201_fw_upload(struct usb_device *dev, int apfw)
 
        err = request_firmware(&fw_entry, fwfile, &dev->dev);
        if (err) {
-               dev_err(&dev->dev, "Failed to load %s firmware file!\n", fwfile);
-               dev_err(&dev->dev, "Make sure the hotplug firmware loader is installed.\n");
                dev_err(&dev->dev, "Goto http://linux-lc100020.sourceforge.net for more info.\n");
                return err;
        }
index 850c26bc952470319118bdedf8073342a72b485c..9bde6bda1b0f911902a11a6d1939ccf89e68ad2c 100644 (file)
@@ -107,16 +107,9 @@ static void int_urb_complete(struct urb *urb);
 static int request_fw_file(
        const struct firmware **fw, const char *name, struct device *device)
 {
-       int r;
-
        dev_dbg_f(device, "fw name %s\n", name);
 
-       r = request_firmware(fw, name, device);
-       if (r)
-               dev_err(device,
-                      "Could not load firmware file %s. Error number %d\n",
-                      name, r);
-       return r;
+       return request_firmware(fw, name, device);
 }
 
 static inline u16 get_bcdDevice(const struct usb_device *udev)
index ace5eff828e96acba509994790974531cb87e2f1..b0f05492f4d5ec63320a7392284405398b885f8f 100644 (file)
@@ -4045,8 +4045,6 @@ static int AscInitAsc1000Driver(ASC_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code |= ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -4411,8 +4409,6 @@ static int AdvInitAsc3550Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -4911,8 +4907,6 @@ static int AdvInitAsc38C0800Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
@@ -5399,8 +5393,6 @@ static int AdvInitAsc38C1600Driver(ADV_DVC_VAR *asc_dvc)
 
        err = request_firmware(&fw, fwname, asc_dvc->drv_ptr->dev);
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                asc_dvc->err_code = ASC_IERR_MCODE_CHKSUM;
                return err;
        }
index 7a78606598c4bfc42184291b88bdd742ea32044b..6a3e993aa54c61dd1f7851a8491c112d18e400ae 100644 (file)
@@ -370,8 +370,6 @@ static ssize_t asd_store_update_bios(struct device *dev,
                                   filename_ptr,
                                   &asd_ha->pcidev->dev);
        if (err) {
-               asd_printk("Failed to load bios image file %s, error %d\n",
-                          filename_ptr, err);
                err = FAIL_OPEN_BIOS_FILE;
                goto out1;
        }
index c0f685c86851b8901c38209b23d4b452b4c80310..a348fac71ec02b57a8ed06fa30e31fe8de5a0b28 100644 (file)
@@ -1302,11 +1302,8 @@ int asd_init_seqs(struct asd_ha_struct *asd_ha)
 
        err = asd_request_firmware(asd_ha);
 
-       if (err) {
-               asd_printk("Failed to load sequencer firmware file %s, error %d\n",
-                          SAS_RAZOR_SEQUENCER_FW_FILE, err);
+       if (err)
                return err;
-       }
 
        err = asd_seq_download_seqs(asd_ha);
        if (err) {
index 440ef32be048fee51aad6c7380d72778b09fe6ed..7c1a4ef2aab6dd14f7d96866854b105a3f16fdad 100644 (file)
@@ -1749,7 +1749,6 @@ bfad_read_firmware(struct pci_dev *pdev, u32 **bfi_image,
        const struct firmware *fw;
 
        if (request_firmware(&fw, fw_name, &pdev->dev)) {
-               printk(KERN_ALERT "Can't locate firmware %s\n", fw_name);
                *bfi_image = NULL;
                goto out;
        }
index 104bee9b3a9dc80bfe171bebd8d96c9cb9d3aa27..212ee7d6ac3b439bb73c5f7bbba2384a86bf11e4 100644 (file)
@@ -4102,10 +4102,8 @@ static ssize_t ipr_store_update_fw(struct device *dev,
        if (endline)
                *endline = '\0';
 
-       if (request_firmware(&fw_entry, fname, &ioa_cfg->pdev->dev)) {
-               dev_err(&ioa_cfg->pdev->dev, "Firmware file %s not found\n", fname);
+       if (request_firmware(&fw_entry, fname, &ioa_cfg->pdev->dev))
                return -EIO;
-       }
 
        image_hdr = (struct ipr_ucode_image_header *)fw_entry->data;
 
index 397eb9f6a1dd58953154f148ad5d1c754ccf71fe..26a297ecfa462c1d7b3b329fc1123cf1da4ebed1 100644 (file)
@@ -844,9 +844,6 @@ static ssize_t pm8001_store_update_fw(struct device *cdev,
                               pm8001_ha->dev);
 
        if (ret) {
-               pm8001_dbg(pm8001_ha, FAIL,
-                          "Failed to load firmware image file %s, error %d\n",
-                          filename_ptr, ret);
                pm8001_ha->fw_status = FAIL_OPEN_BIOS_FILE;
                goto out;
        }
index 1dc56f4c89d83d8598cad03b146c100420190f73..7267a99f76e42dae6e7f8b2ad1c27e63b75cbf49 100644 (file)
@@ -1511,8 +1511,6 @@ qla1280_request_firmware(struct scsi_qla_host *ha)
        err = request_firmware(&fw, fwname, &ha->pdev->dev);
 
        if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
                fw = ERR_PTR(err);
                goto unlock;
        }
index 070b636802d041445d597776384d5a402c79c483..702ae7b27bd755e0a273ab33081fba067c4a7ed6 100644 (file)
@@ -8248,10 +8248,6 @@ qla2x00_load_risc(scsi_qla_host_t *vha, uint32_t *srisc_addr)
        /* Load firmware blob. */
        blob = qla2x00_request_firmware(vha);
        if (!blob) {
-               ql_log(ql_log_info, vha, 0x0083,
-                   "Firmware image unavailable.\n");
-               ql_log(ql_log_info, vha, 0x0084,
-                   "Firmware images can be retrieved from: "QLA_FW_URL ".\n");
                return QLA_FUNCTION_FAILED;
        }
 
@@ -8354,9 +8350,6 @@ qla24xx_load_risc_blob(scsi_qla_host_t *vha, uint32_t *srisc_addr)
 
        blob = qla2x00_request_firmware(vha);
        if (!blob) {
-               ql_log(ql_log_warn, vha, 0x0092,
-                   "-> Firmware file not found.\n");
-
                return QLA_FUNCTION_FAILED;
        }
 
index 11aad97dfca8c7e5f3d75237e677c75160349e05..61e654247e8797b4f80046a520b90639f7449222 100644 (file)
@@ -2427,11 +2427,8 @@ try_blob_fw:
 
        /* Load firmware blob. */
        blob = ha->hablob = qla2x00_request_firmware(vha);
-       if (!blob) {
-               ql_log(ql_log_fatal, vha, 0x00a3,
-                   "Firmware image not present.\n");
+       if (!blob)
                goto fw_load_failed;
-       }
 
        /* Validating firmware blob */
        if (qla82xx_validate_firmware_blob(vha,
index abcd309172638067849313930cdc290a9f76a308..962800427e7506a964258c31eca9018ac7adb52d 100644 (file)
@@ -7529,8 +7529,6 @@ qla2x00_request_firmware(scsi_qla_host_t *vha)
                goto out;
 
        if (request_firmware(&blob->fw, blob->name, &ha->pdev->dev)) {
-               ql_log(ql_log_warn, vha, 0x0063,
-                   "Failed to load firmware image (%s).\n", blob->name);
                blob->fw = NULL;
                blob = NULL;
        }
index 57f2f4135a060557d34486d1e0fba2b21c1284ec..1c2ab2d72aaea7b29b3456844d4a04813da56f4b 100644 (file)
@@ -486,11 +486,8 @@ static int qlogicpti_load_firmware(struct qlogicpti *qpti)
        int i, timeout;
 
        err = request_firmware(&fw, fwname, &qpti->op->dev);
-       if (err) {
-               printk(KERN_ERR "Failed to load image \"%s\" err %d\n",
-                      fwname, err);
+       if (err)
                return err;
-       }
        if (fw->size % 2) {
                printk(KERN_ERR "Bogus length %zu in image \"%s\"\n",
                       fw->size, fwname);
index 4f8629e47e824c4efd76cfe2bbaa8415c3047d46..1033dca60be96a9eecc7359b09a8baeb5ccae89b 100644 (file)
@@ -240,10 +240,8 @@ bool init_firmware(struct net_device *dev)
                 */
                if (rst_opt == OPT_SYSTEM_RESET) {
                        rc = request_firmware(&fw_entry, fw_name[init_step], &priv->udev->dev);
-                       if (rc < 0) {
-                               RT_TRACE(COMP_ERR, "request firmware fail!\n");
+                       if (rc)
                                goto download_firmware_fail;
-                       }
 
                        if (fw_entry->size > sizeof(pfirmware->firmware_buf)) {
                                RT_TRACE(COMP_ERR, "img file size exceed the container buffer fail!\n");
index 1148075f0cd64c5045c6df8bf5a228031f8bfe98..dc8a6b1c5c80b3ecebb31c58309e60a5bc737c9e 100644 (file)
@@ -72,8 +72,6 @@ int rtl871x_load_fw(struct _adapter *padapter)
        dev_info(dev, "r8712u: Loading firmware from \"%s\"\n", firmware_file);
        rc = request_firmware_nowait(THIS_MODULE, 1, firmware_file, dev,
                                     GFP_KERNEL, padapter, rtl871x_load_fw_cb);
-       if (rc)
-               dev_err(dev, "r8712u: Firmware request error %d\n", rc);
        return rc;
 }
 MODULE_FIRMWARE("rtlwifi/rtl8712u.bin");
index ae7f5916d4d69710fac912685ceab1d148c2d0cb..66b3ab85f2350bc0be1f8fd6b907be2500c2b886 100644 (file)
@@ -107,11 +107,8 @@ static int vnt_download_firmware(struct vnt_private *priv)
        dev_dbg(dev, "---->Download firmware\n");
 
        ret = request_firmware(&fw, FIRMWARE_NAME, dev);
-       if (ret) {
-               dev_err(dev, "firmware file %s request failed (%d)\n",
-                       FIRMWARE_NAME, ret);
+       if (ret)
                goto end;
-       }
 
        for (ii = 0; ii < fw->size; ii += FIRMWARE_CHUNK_SIZE) {
                length = min_t(int, fw->size - ii, FIRMWARE_CHUNK_SIZE);
index e37683e250555e19757b81861cec26170a2450b7..6060d986e3a9b8d4f44dc4e22bb0ce4b3372ebe0 100644 (file)
@@ -1154,13 +1154,8 @@ static int moxa_init_board(struct moxa_board_conf *brd, struct device *dev)
        }
 
        ret = request_firmware(&fw, file, dev);
-       if (ret) {
-               printk(KERN_ERR "MOXA: request_firmware failed. Make sure "
-                               "you've placed '%s' file into your firmware "
-                               "loader directory (e.g. /lib/firmware)\n",
-                               file);
+       if (ret)
                goto err_free;
-       }
 
        ret = moxa_load_fw(brd, fw);
 
index 03a2fe9f4c9a9d02fdd45de946460d6c3ad78d74..8fc410fff452de8ad4ebe07f0bf881495aef3e25 100644 (file)
@@ -362,7 +362,6 @@ static void load_code(struct icom_port *icom_port)
 
        /* Load Call Setup into Adapter */
        if (request_firmware(&fw, "icom_call_setup.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_call_setup.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
@@ -382,7 +381,6 @@ static void load_code(struct icom_port *icom_port)
 
        /* Load Resident DCE portion of Adapter */
        if (request_firmware(&fw, "icom_res_dce.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_res_dce.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
@@ -427,7 +425,6 @@ static void load_code(struct icom_port *icom_port)
        }
 
        if (request_firmware(&fw, "icom_asc.bin", &dev->dev) < 0) {
-               dev_err(&dev->dev,"Unable to load icom_asc.bin firmware image\n");
                status = -1;
                goto load_code_exit;
        }
index 6000853973c108c97aee1db428129b9d915d986e..5ae44501d235b3ad2e18affa0723aec055e7af50 100644 (file)
@@ -1161,10 +1161,8 @@ static void uart_firmware_cont(const struct firmware *fw, void *context)
        struct device *dev = context;
        int ret;
 
-       if (!fw) {
-               dev_err(dev, "firmware not found\n");
+       if (!fw)
                return;
-       }
 
        firmware = (struct qe_firmware *) fw->data;
 
index 4ce7cba2b48aa324bcde74575fbbadd3a2e5075c..db4a20c73528a65c976a489b7946d3f7f3dfde10 100644 (file)
@@ -1084,8 +1084,6 @@ static int cxacru_find_firmware(struct cxacru_data *instance,
                return -ENOENT;
        }
 
-       usb_info(usbatm, "found firmware %s\n", buf);
-
        return 0;
 }
 
index 786299892c7f46e8948825d194b91e433518c24b..2eb9911ba362ac7689a6facd1d96ca4a02d96dbe 100644 (file)
@@ -606,10 +606,8 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry,
        int ret, size;
 
        uea_enters(usb);
-       if (!fw_entry) {
-               uea_err(usb, "firmware is not available\n");
+       if (!fw_entry)
                goto err;
-       }
 
        pfw = fw_entry->data;
        size = fw_entry->size;
@@ -704,10 +702,6 @@ static int uea_load_firmware(struct usb_device *usb, unsigned int ver)
        ret = request_firmware_nowait(THIS_MODULE, 1, fw_name, &usb->dev,
                                        GFP_KERNEL, usb,
                                        uea_upload_pre_firmware);
-       if (ret)
-               uea_err(usb, "firmware %s is not available\n", fw_name);
-       else
-               uea_info(usb, "loading firmware %s\n", fw_name);
 
        uea_leaves(usb);
        return ret;
@@ -869,12 +863,8 @@ static int request_dsp(struct uea_softc *sc)
        }
 
        ret = request_firmware(&sc->dsp_firm, dsp_name, &sc->usb_dev->dev);
-       if (ret < 0) {
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                       dsp_name, ret);
+       if (ret)
                return ret;
-       }
 
        if (UEA_CHIP_VERSION(sc) == EAGLE_IV)
                ret = check_dsp_e4(sc->dsp_firm->data, sc->dsp_firm->size);
@@ -1587,12 +1577,8 @@ static int request_cmvs_old(struct uea_softc *sc,
 
        cmvs_file_name(sc, cmv_name, 1);
        ret = request_firmware(fw, cmv_name, &sc->usb_dev->dev);
-       if (ret < 0) {
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                      cmv_name, ret);
+       if (ret)
                return ret;
-       }
 
        data = (u8 *) (*fw)->data;
        size = (*fw)->size;
@@ -1629,9 +1615,6 @@ static int request_cmvs(struct uea_softc *sc,
                                "try to get older cmvs\n", cmv_name);
                        return request_cmvs_old(sc, cmvs, fw);
                }
-               uea_err(INS_TO_USBDEV(sc),
-                      "requesting firmware %s failed with error %d\n",
-                      cmv_name, ret);
                return ret;
        }
 
@@ -1914,11 +1897,8 @@ static int load_XILINX_firmware(struct uea_softc *sc)
        uea_enters(INS_TO_USBDEV(sc));
 
        ret = request_firmware(&fw_entry, fw_name, &sc->usb_dev->dev);
-       if (ret) {
-               uea_err(INS_TO_USBDEV(sc), "firmware %s is not available\n",
-                      fw_name);
+       if (ret)
                goto err0;
-       }
 
        pfw = fw_entry->data;
        size = fw_entry->size;
index 24d841850e0561cb8ccf52fc9fcc896eccdeaffa..84e62e60c8a51e479d46bfa994e6d54430356aea 100644 (file)
@@ -85,21 +85,17 @@ static int emi26_load_firmware (struct usb_device *dev)
 
        err = request_ihex_firmware(&loader_fw, "emi26/loader.fw", &dev->dev);
        if (err)
-               goto nofw;
+               goto wraperr;
 
        err = request_ihex_firmware(&bitstream_fw, "emi26/bitstream.fw",
                                    &dev->dev);
        if (err)
-               goto nofw;
+               goto wraperr;
 
        err = request_ihex_firmware(&firmware_fw, "emi26/firmware.fw",
                                    &dev->dev);
-       if (err) {
-       nofw:
-               dev_err(&dev->dev, "%s - request_firmware() failed\n",
-                       __func__);
+       if (err)
                goto wraperr;
-       }
 
        /* Assert reset (stop the CPU in the EMI) */
        err = emi26_set_reset(dev,1);
index 78aaee56c2b78335c6121051196dc79aa199ad44..840ba48f074ad35db30614ed157eba10d3a1966b 100644 (file)
@@ -64,12 +64,8 @@ static int ezusb_ihex_firmware_download(struct usb_device *dev,
        const struct ihex_binrec *record;
 
        if (request_ihex_firmware(&firmware, firmware_path,
-                                 &dev->dev)) {
-               dev_err(&dev->dev,
-                       "%s - request \"%s\" failed\n",
-                       __func__, firmware_path);
+                                 &dev->dev))
                goto out;
-       }
 
        ret = ezusb_set_reset(dev, fx.cpucs_reg, 0);
        if (ret < 0)
index 4d30095d6ad2193a6d6064891b67dda2a19ebb75..e217999b192385be1edbb6bf7101845b8a840369 100644 (file)
@@ -45,7 +45,6 @@ static int isight_firmware_load(struct usb_interface *intf,
                return -ENOMEM;
 
        if (request_firmware(&firmware, "isight.fw", &dev->dev) != 0) {
-               printk(KERN_ERR "Unable to load isight firmware\n");
                ret = -ENODEV;
                goto out;
        }
index bdee78cc4a072aa0c27e79e33457d5d18aac7612..c2a68000cbf9324fcdbcf51eaf07fdb6916638d4 100644 (file)
@@ -332,11 +332,8 @@ static void update_edgeport_E2PROM(struct edgeport_serial *edge_serial)
 
        response = request_ihex_firmware(&fw, fw_name,
                                         &edge_serial->serial->dev->dev);
-       if (response) {
-               dev_err(dev, "Failed to load image \"%s\" err %d\n",
-                      fw_name, response);
+       if (response)
                return;
-       }
 
        rec = (const struct ihex_binrec *)fw->data;
        BootMajorVersion = rec->data[0];
index a7b3c15957ba937f39767b94ed694b69ef21fc85..002856c799a56b0d0efe559e362baec874c8d13b 100644 (file)
@@ -1006,8 +1006,6 @@ static int download_fw(struct edgeport_serial *serial)
 
        status = request_firmware(&fw, fw_name, dev);
        if (status) {
-               dev_err(dev, "Failed to load image \"%s\" err %d\n",
-                               fw_name, status);
                return status;
        }
 
index 18c0bd8533924439b73f9579a1a5234f249e48d5..7a917b8a90b0b7ba5a06793e26eb54ce9ace675c 100644 (file)
@@ -1629,10 +1629,8 @@ static int ti_download_firmware(struct ti_device *tdev)
        }
 
 check_firmware:
-       if (status) {
-               dev_err(&dev->dev, "%s - firmware not found\n", __func__);
+       if (status)
                return -ENOENT;
-       }
        if (fw_p->size > TI_FIRMWARE_BUF_SIZE) {
                dev_err(&dev->dev, "%s - firmware too large %zu\n", __func__, fw_p->size);
                release_firmware(fw_p);
index fd66f4d4a621b754739509b334cf98b6b9990ca8..ef5a29f865b5c58ac400c64fb158370890f6be77 100644 (file)
@@ -743,10 +743,8 @@ static ssize_t broadsheet_loadstore_waveform(struct device *dev,
                return -EINVAL;
 
        err = request_firmware(&fw_entry, "broadsheet.wbf", dev);
-       if (err < 0) {
-               dev_err(dev, "Failed to get broadsheet waveform\n");
+       if (err)
                goto err_failed;
-       }
 
        /* try to enforce reasonable min max on waveform */
        if ((fw_entry->size < 8*1024) || (fw_entry->size > 64*1024)) {
index 952826557a0c7c6a1be7b31338b441662642e22a..e9f59b9251cb9a19dbbb14a297c6bb6118dd9d4c 100644 (file)
@@ -679,10 +679,8 @@ static int metronomefb_probe(struct platform_device *dev)
                a) request the waveform file from userspace
                b) process waveform and decode into metromem */
        retval = request_firmware(&fw_entry, "metronome.wbf", &dev->dev);
-       if (retval < 0) {
-               dev_err(&dev->dev, "Failed to get waveform\n");
+       if (retval)
                goto err_csum_table;
-       }
 
        retval = load_waveform((u8 *) fw_entry->data, fw_entry->size, 3, 31,
                                par);
index efbb644edba1f8b9c3f19b8d432bb93ca5c28e8f..d8b29b957f9efda2a94b48de668080f0a83df1da 100644 (file)
@@ -58,10 +58,8 @@ int snd_vx_setup_firmware(struct vx_core *chip)
                if (! fw_files[chip->type][i])
                        continue;
                sprintf(path, "vx/%s", fw_files[chip->type][i]);
-               if (request_firmware(&fw, path, chip->dev)) {
-                       snd_printk(KERN_ERR "vx: can't load firmware %s\n", path);
+               if (request_firmware(&fw, path, chip->dev))
                        return -ENOENT;
-               }
                err = chip->ops->load_dsp(chip, i, fw);
                if (err < 0) {
                        release_firmware(fw);
index 4433a92f08e7fce9f1311268da94137f82b47f17..42e4cfe5786ad28ded2707907e26d501cc0264df 100644 (file)
@@ -376,15 +376,11 @@ static int upload_dsp_code(struct snd_card *card)
        outb(HPBLKSEL_0, chip->io + HP_BLKS);
 
        err = request_firmware(&init_fw, INITCODEFILE, card->dev);
-       if (err < 0) {
-               printk(KERN_ERR LOGNAME ": Error loading " INITCODEFILE);
+       if (err)
                goto cleanup1;
-       }
        err = request_firmware(&perm_fw, PERMCODEFILE, card->dev);
-       if (err < 0) {
-               printk(KERN_ERR LOGNAME ": Error loading " PERMCODEFILE);
+       if (err)
                goto cleanup;
-       }
 
        memcpy_toio(chip->mappedbase, perm_fw->data, perm_fw->size);
        if (snd_msnd_upload_host(chip, init_fw->data, init_fw->size) < 0) {
index 0bc0025f7c199a6c678e2bf8c949b33fe882ff28..0598594dcc0e5cdac2786820c4eb58491c475473 100644 (file)
@@ -520,10 +520,8 @@ static int sscape_upload_bootblock(struct snd_card *card)
        int ret;
 
        ret = request_firmware(&init_fw, "scope.cod", card->dev);
-       if (ret < 0) {
-               snd_printk(KERN_ERR "sscape: Error loading scope.cod");
+       if (ret)
                return ret;
-       }
        ret = upload_dma_data(sscape, init_fw->data, init_fw->size);
 
        release_firmware(init_fw);
@@ -560,11 +558,8 @@ static int sscape_upload_microcode(struct snd_card *card, int version)
        snprintf(name, sizeof(name), "sndscape.co%d", version);
 
        err = request_firmware(&init_fw, name, card->dev);
-       if (err < 0) {
-               snd_printk(KERN_ERR "sscape: Error loading sndscape.co%d",
-                               version);
+       if (err)
                return err;
-       }
        err = upload_dma_data(sscape, init_fw->data, init_fw->size);
        if (err == 0)
                snd_printk(KERN_INFO "sscape: MIDI firmware loaded %zu KBs\n",
index 69cbc79fbb716a902961aedd7e383004be18985e..40e04aad63a04cff53fc49fda92ebb840a5d700c 100644 (file)
@@ -1971,10 +1971,8 @@ wavefront_download_firmware (snd_wavefront_t *dev, char *path)
        const struct firmware *firmware;
 
        err = request_firmware(&firmware, path, dev->card->dev);
-       if (err < 0) {
-               snd_printk(KERN_ERR "firmware (%s) download failed!!!\n", path);
+       if (err)
                return 1;
-       }
 
        len = 0;
        buf = firmware->data;
index 9acc0ac75ecae21f49bf4c1dc1ed8e9837ab7888..7c1ebc8ec8ec43c42db5471901987e78d9a0f678 100644 (file)
@@ -35,8 +35,6 @@ short hpi_dsp_code_open(u32 adapter, void *os_data, struct dsp_code *dsp_code,
        err = request_firmware(&firmware, fw_name, &dev->dev);
 
        if (err || !firmware) {
-               dev_err(&dev->dev, "%d, request_firmware failed for %s\n",
-                       err, fw_name);
                goto error1;
        }
        if (firmware->size < sizeof(header)) {
index 62f45847b351dd6e466730e20ecc01f3285de3ea..e68edf623436446883fa61052de38bed43304b15 100644 (file)
@@ -3199,11 +3199,8 @@ int snd_cs46xx_start_dsp(struct snd_cs46xx *chip)
 #ifdef CONFIG_SND_CS46XX_NEW_DSP
        for (i = 0; i < CS46XX_DSP_MODULES; i++) {
                err = load_firmware(chip, &chip->modules[i], module_names[i]);
-               if (err < 0) {
-                       dev_err(chip->card->dev, "firmware load error [%s]\n",
-                                  module_names[i]);
+               if (err < 0)
                        return err;
-               }
                err = cs46xx_dsp_load_module(chip, chip->modules[i]);
                if (err < 0) {
                        dev_err(chip->card->dev, "image download error [%s]\n",
index 25b012ef5c3e680f720c7da345e292c31ea5c566..5ba76f1a7c8917c75d40ab580565dfed84b971c9 100644 (file)
@@ -48,11 +48,8 @@ static int get_firmware(const struct firmware **fw_entry,
                "firmware requested: %s\n", card_fw[fw_index].data);
        snprintf(name, sizeof(name), "ea/%s", card_fw[fw_index].data);
        err = request_firmware(fw_entry, name, &chip->pci->dev);
-       if (err < 0)
-               dev_err(chip->card->dev,
-                       "get_firmware(): Firmware not available (%d)\n", err);
 #ifdef CONFIG_PM_SLEEP
-       else
+       if (!err)
                chip->fw_cache[fw_index] = *fw_entry;
 #endif
        return err;
index 86cc1ca025e403f0366752cc92e8f498c80db75e..72a60d53f4072924aa4ad78e2a3cece19bfb3d48 100644 (file)
@@ -873,10 +873,8 @@ static int snd_emu10k1_emu1010_init(struct snd_emu10k1 *emu)
        dev_info(emu->card->dev, "emu1010: EMU_HANA_ID = 0x%x\n", reg);
 
        err = snd_emu1010_load_firmware(emu, 0, &emu->firmware);
-       if (err < 0) {
-               dev_info(emu->card->dev, "emu1010: Loading Firmware failed\n");
+       if (err < 0)
                return err;
-       }
 
        /* ID, should read & 0x7f = 0x55 when FPGA programmed. */
        snd_emu1010_fpga_read(emu, EMU_HANA_ID, &reg);
index 3b6f2aacda459fc647dd235a87bcc73e804ce1bb..46f4aca454124f7450bea057dd011286a6dc039b 100644 (file)
@@ -2019,8 +2019,6 @@ static void azx_firmware_cb(const struct firmware *fw, void *context)
 
        if (fw)
                chip->fw = fw;
-       else
-               dev_err(card->dev, "Cannot load firmware, continue without patching\n");
        if (!chip->disabled) {
                /* continue probing */
                azx_probe_continue(chip);
index 5c9e240ff6a9c514658b4b905368e1857a7e980e..45149bb08b6e95b481995549b6b119bce0f7c861 100644 (file)
@@ -2258,7 +2258,6 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci)
 
        err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev);
        if (err < 0) {
-               snd_printk(KERN_ERR "firmware not available\n");
                return err;
        }
 
index 689c0f995a9cec7535170865a3d501682fb4f414..767bb83318d06e21089fe91dcb60b56295995b9f 100644 (file)
@@ -566,11 +566,8 @@ int snd_mixart_setup_firmware(struct mixart_mgr *mgr)
 
        for (i = 0; i < 3; i++) {
                sprintf(path, "mixart/%s", fw_files[i]);
-               if (request_firmware(&fw_entry, path, &mgr->pci->dev)) {
-                       dev_err(&mgr->pci->dev,
-                               "miXart: can't load firmware %s\n", path);
+               if (request_firmware(&fw_entry, path, &mgr->pci->dev))
                        return -ENOENT;
-               }
                /* fake hwdep dsp record */
                err = mixart_dsp_load(mgr, i, fw_entry);
                release_firmware(fw_entry);
index 249805065f61413d5d06899ad6b3d292cfdc1ce2..25cddf1ba4dc319e9d8fe49f9b8144c231919c10 100644 (file)
@@ -375,12 +375,8 @@ int pcxhr_setup_firmware(struct pcxhr_mgr *mgr)
                if (!fw_files[fw_set][i])
                        continue;
                sprintf(path, "pcxhr/%s", fw_files[fw_set][i]);
-               if (request_firmware(&fw_entry, path, &mgr->pci->dev)) {
-                       dev_err(&mgr->pci->dev,
-                               "pcxhr: can't load firmware %s\n",
-                                  path);
+               if (request_firmware(&fw_entry, path, &mgr->pci->dev))
                        return -ENOENT;
-               }
                /* fake hwdep dsp record */
                err = pcxhr_dsp_load(mgr, i, fw_entry);
                release_firmware(fw_entry);
index 5a987c683c41c14685674803ac0f3079d206d3b3..7b71390b501845f61fe8d9656b52fdc2b976a01a 100644 (file)
@@ -1222,11 +1222,8 @@ static int try_to_load_firmware(struct cmdif *cif, struct snd_riptide *chip)
        if (!chip->fw_entry) {
                err = request_firmware(&chip->fw_entry, "riptide.hex",
                                       &chip->pci->dev);
-               if (err) {
-                       snd_printk(KERN_ERR
-                                  "Riptide: Firmware not available %d\n", err);
+               if (err)
                        return -EIO;
-               }
        }
        err = loadfirmware(cif, chip->fw_entry->data, chip->fw_entry->size);
        if (err) {
index 96c12dfb24cf9d00cbd98d498f95d4438096415b..01db05fef71f7201795ac19f98f46679dbf2beb5 100644 (file)
@@ -5201,11 +5201,8 @@ static int hdsp_request_fw_loader(struct hdsp *hdsp)
                return -EINVAL;
        }
 
-       if (request_firmware(&fw, fwfile, &hdsp->pci->dev)) {
-               dev_err(hdsp->card->dev,
-                       "cannot load firmware %s\n", fwfile);
+       if (request_firmware(&fw, fwfile, &hdsp->pci->dev))
                return -ENOENT;
-       }
        if (fw->size < HDSP_FIRMWARE_SIZE) {
                dev_err(hdsp->card->dev,
                        "too short firmware size %d (expected %d)\n",
index 72e165cc64439750663f4857a06fd4c20a7ff38d..d73cc2abdb9a37922575366253ad17ba559a2c04 100644 (file)
@@ -894,10 +894,8 @@ static int wm2000_i2c_probe(struct i2c_client *i2c,
        }
 
        ret = request_firmware(&fw, filename, &i2c->dev);
-       if (ret != 0) {
-               dev_err(&i2c->dev, "Failed to acquire ANC data: %d\n", ret);
+       if (ret != 0)
                goto err_supplies;
-       }
 
        /* Pre-cook the concatenation of the register address onto the image */
        wm2000->anc_download_size = fw->size + 2;
index c51abc54d2f844f515aecb0a6bed16a9eba58aba..f548f3c5cc598d7319be99a32eb9860827a119d6 100644 (file)
@@ -203,8 +203,6 @@ static int usb6fire_fw_ezusb_upload(
        ret = request_firmware(&fw, fwname, &device->dev);
        if (ret < 0) {
                kfree(rec);
-               dev_err(&intf->dev,
-                       "error requesting ezusb firmware %s.\n", fwname);
                return ret;
        }
        ret = usb6fire_fw_ihex_init(fw, rec);
@@ -280,8 +278,6 @@ static int usb6fire_fw_fpga_upload(
 
        ret = request_firmware(&fw, fwname, &device->dev);
        if (ret < 0) {
-               dev_err(&intf->dev, "unable to get fpga firmware %s.\n",
-                               fwname);
                kfree(buffer);
                return -EIO;
        }