disable shared builtins when loading deps on demand

Last-Update: 2023-12-10
Forwarded: no, todo

This is to avoid preloading potentially missing files.

Gbp-Pq: Topic build
Gbp-Pq: Name builtins_module_paths_not_shareable.patch

diff --git a/src/node_builtins.cc b/src/node_builtins.cc
index 7c6b7463ddaaff275a6ced385405325b9e02c0fd..98d6b07c9cd4e12c9604412f502b4548e5081286 100644 (file)
--- a/src/node_builtins.cc
+++ b/src/node_builtins.cc
@@ -35,6 +35,7 @@ using v8::Value;
 BuiltinLoader::BuiltinLoader()
     : config_(GetConfig()), code_cache_(std::make_shared<BuiltinCodeCache>()) {
   LoadJavaScriptSource();
+#ifndef NODE_BUILTIN_MODULES_PATH
 #ifdef NODE_SHARED_BUILTIN_CJS_MODULE_LEXER_LEXER_PATH
   AddExternalizedBuiltin(
       "internal/deps/cjs-module-lexer/lexer",
@@ -76,6 +77,8 @@ BuiltinLoader::BuiltinLoader()
                          STRINGIFY(NODE_SHARED_BUILTIN_AMARO_DIST_INDEX_PATH));
 #endif  // NODE_SHARED_BUILTIN_AMARO_DIST_INDEX_PATH
 #endif  // HAVE_AMARO
+
+#endif  // NOT NODE_BUILTIN_MODULES_PATH
 }
 
 bool BuiltinLoader::Exists(const char* id) {