Upgrade liborcus to 0.16.0.
authorKohei Yoshida <kohei@libreoffice.org>
Thu, 10 Sep 2020 01:23:48 +0000 (21:23 -0400)
committerDaniel Leidert <dleidert@debian.org>
Sat, 31 May 2025 03:25:27 +0000 (05:25 +0200)
Change-Id: Iae29fb26417dfc161698a81bee84e81545969065
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102502
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
Gbp-Pq: Name liborcus-0.16.diff

13 files changed:
RepositoryExternal.mk
configure.ac
download.lst
external/liborcus/ExternalPackage_liborcus.mk
external/liborcus/ExternalProject_liborcus.mk
external/liborcus/Library_orcus-parser.mk
external/liborcus/Library_orcus.mk
external/liborcus/libtool.patch.0
external/liborcus/windows-constants-hack.patch
sc/source/filter/inc/orcusinterface.hxx
sc/source/filter/orcus/interface.cxx
sc/source/filter/orcus/xmlcontext.cxx
sc/source/ui/xmlsource/xmlsourcedlg.cxx

index f5fa682549c1c42d6af06ea0be5e33dc7626251e..56507e3983c01e8fb1e7b32b5f9cfd265fab4325 100644 (file)
@@ -3214,7 +3214,7 @@ $(call gb_LinkTarget_set_include,$(1),\
 )
 
 $(call gb_LinkTarget_add_libs,$(1),\
-       -L$(call gb_UnpackedTarball_get_dir,liborcus)/src/liborcus/.libs -lorcus-0.15 \
+       -L$(call gb_UnpackedTarball_get_dir,liborcus)/src/liborcus/.libs -lorcus-0.16 \
 )
 
 $(if $(SYSTEM_BOOST), \
@@ -3233,7 +3233,7 @@ $(call gb_LinkTarget_set_include,$(1),\
 )
 
 $(call gb_LinkTarget_add_libs,$(1),\
-       -L$(call gb_UnpackedTarball_get_dir,liborcus)/src/parser/.libs -lorcus-parser-0.15 \
+       -L$(call gb_UnpackedTarball_get_dir,liborcus)/src/parser/.libs -lorcus-parser-0.16 \
 )
 
 endef
index f724471774354b4afad0ec425f6a8040e5a18e6b..de6d4ca846895a7df29d6fec8d1d3bbc17c78ffc 100644 (file)
Binary files a/configure.ac and b/configure.ac differ
index 4a8f922fb9edd2b086bb7e52878772deee1da21f..5fda92065aedeb3d200f42146031ff6143b6dcb7 100644 (file)
@@ -204,8 +204,8 @@ export OPENLDAP_SHA256SUM := cdd6cffdebcd95161a73305ec13fc7a78e9707b46ca9f84fb89
 export OPENLDAP_TARBALL := openldap-2.4.45.tgz
 export OPENSSL_SHA256SUM := 14cb464efe7ac6b54799b34456bd69558a749a4931ecfd9cf9f71d7881cac7bc
 export OPENSSL_TARBALL := openssl-1.0.2t.tar.gz
-export ORCUS_SHA256SUM := cfb2aa60825f2a78589ed030c07f46a1ee16ef8a2d1bf2279192fbc1ae5a5f61
-export ORCUS_TARBALL := liborcus-0.15.4.tar.bz2
+export ORCUS_SHA256SUM := c700d1325f744104d9fca0d5a019434901e9d51a16eedfb05792f90a298587a4
+export ORCUS_TARBALL := liborcus-0.16.1.tar.bz2
 export OWNCLOUD_ANDROID_LIB_SHA256SUM := b18b3e3ef7fae6a79b62f2bb43cc47a5346b6330f6a383dc4be34439aca5e9fb
 export OWNCLOUD_ANDROID_LIB_TARBALL := owncloud-android-library-0.9.4-no-binary-deps.tar.gz
 export PAGEMAKER_SHA256SUM := 66adacd705a7d19895e08eac46d1e851332adf2e736c566bef1164e7a442519d
index 21dd1bfb1ce5b224ce73825e616472ebf891cd4b..747691809d2e108c70e2b60e2956185caea460c3 100644 (file)
@@ -12,11 +12,11 @@ $(eval $(call gb_ExternalPackage_ExternalPackage,liborcus,liborcus))
 $(eval $(call gb_ExternalPackage_use_external_project,liborcus,liborcus))
 
 ifeq ($(OS),MACOSX)
-$(eval $(call gb_ExternalPackage_add_file,liborcus,$(LIBO_LIB_FOLDER)/liborcus-0.15.0.dylib,src/liborcus/.libs/liborcus-0.15.0.dylib))
-$(eval $(call gb_ExternalPackage_add_file,liborcus,$(LIBO_LIB_FOLDER)/liborcus-parser-0.15.0.dylib,src/parser/.libs/liborcus-parser-0.15.0.dylib))
+$(eval $(call gb_ExternalPackage_add_file,liborcus,$(LIBO_LIB_FOLDER)/liborcus-0.16.0.dylib,src/liborcus/.libs/liborcus-0.16.0.dylib))
+$(eval $(call gb_ExternalPackage_add_file,liborcus,$(LIBO_LIB_FOLDER)/liborcus-parser-0.16.0.dylib,src/parser/.libs/liborcus-parser-0.16.0.dylib))
 else ifeq ($(DISABLE_DYNLOADING),)
-$(eval $(call gb_ExternalPackage_add_file,liborcus,$(LIBO_LIB_FOLDER)/liborcus-0.15.so.0,src/liborcus/.libs/liborcus-0.15.so.0.0.0))
-$(eval $(call gb_ExternalPackage_add_file,liborcus,$(LIBO_LIB_FOLDER)/liborcus-parser-0.15.so.0,src/parser/.libs/liborcus-parser-0.15.so.0.0.0))
+$(eval $(call gb_ExternalPackage_add_file,liborcus,$(LIBO_LIB_FOLDER)/liborcus-0.16.so.0,src/liborcus/.libs/liborcus-0.16.so.0.0.0))
+$(eval $(call gb_ExternalPackage_add_file,liborcus,$(LIBO_LIB_FOLDER)/liborcus-parser-0.16.so.0,src/parser/.libs/liborcus-parser-0.16.so.0.0.0))
 endif
 
 # vim: set noet sw=4 ts=4:
index 38658cc819082b570f99ea76fd4778f55af4041c..3671294eedec3113481feb608125ad0cd895c766 100644 (file)
@@ -123,8 +123,8 @@ $(call gb_ExternalProject_get_state_target,liborcus,build) :
                   $(MAKE) \
                $(if $(filter MACOSX,$(OS)),\
                        && $(PERL) $(SRCDIR)/solenv/bin/macosx-change-install-names.pl shl OOO \
-                               $(EXTERNAL_WORKDIR)/src/liborcus/.libs/liborcus-0.15.0.dylib \
-                               $(EXTERNAL_WORKDIR)/src/parser/.libs/liborcus-parser-0.15.0.dylib \
+                               $(EXTERNAL_WORKDIR)/src/liborcus/.libs/liborcus-0.16.0.dylib \
+                               $(EXTERNAL_WORKDIR)/src/parser/.libs/liborcus-parser-0.16.0.dylib \
                ) \
        )
        $(call gb_Trace_EndRange,liborcus,EXTERNAL)
index d3cbddbb8cec80235deec434b1e7e6d88322bce7..4e46591b98fee54696a9cff3c4558364620019cc 100644 (file)
@@ -63,6 +63,7 @@ $(eval $(call gb_Library_add_generated_exception_objects,orcus-parser,\
        UnpackedTarball/liborcus/src/parser/tokens \
        UnpackedTarball/liborcus/src/parser/types \
        UnpackedTarball/liborcus/src/parser/xml_namespace \
+       UnpackedTarball/liborcus/src/parser/xml_writer \
        UnpackedTarball/liborcus/src/parser/yaml_parser_base \
        UnpackedTarball/liborcus/src/parser/zip_archive \
        UnpackedTarball/liborcus/src/parser/zip_archive_stream \
index ea99e7509fbf014575c496ee28a8310f099eaf57..0a0ca582882ac4428833203cba456ad7125792f1 100644 (file)
@@ -85,6 +85,7 @@ $(eval $(call gb_Library_add_generated_exception_objects,orcus,\
        UnpackedTarball/liborcus/src/liborcus/odf_tokens \
        UnpackedTarball/liborcus/src/liborcus/ods_content_xml_context \
        UnpackedTarball/liborcus/src/liborcus/ods_content_xml_handler \
+       UnpackedTarball/liborcus/src/liborcus/ods_dde_links_context \
        UnpackedTarball/liborcus/src/liborcus/ods_session_data \
        UnpackedTarball/liborcus/src/liborcus/ooxml_content_types \
        UnpackedTarball/liborcus/src/liborcus/ooxml_global \
@@ -103,6 +104,7 @@ $(eval $(call gb_Library_add_generated_exception_objects,orcus,\
        UnpackedTarball/liborcus/src/liborcus/orcus_xls_xml \
        UnpackedTarball/liborcus/src/liborcus/orcus_xlsx \
        UnpackedTarball/liborcus/src/liborcus/orcus_xml \
+       UnpackedTarball/liborcus/src/liborcus/orcus_xml_impl \
        UnpackedTarball/liborcus/src/liborcus/orcus_xml_map_def \
        UnpackedTarball/liborcus/src/liborcus/session_context \
        UnpackedTarball/liborcus/src/liborcus/spreadsheet_iface_util \
@@ -134,7 +136,9 @@ $(eval $(call gb_Library_add_generated_exception_objects,orcus,\
        UnpackedTarball/liborcus/src/liborcus/xml_simple_stream_handler \
        UnpackedTarball/liborcus/src/liborcus/xml_stream_handler \
        UnpackedTarball/liborcus/src/liborcus/xml_stream_parser \
+       UnpackedTarball/liborcus/src/liborcus/xml_structure_mapper \
        UnpackedTarball/liborcus/src/liborcus/xml_structure_tree \
+       UnpackedTarball/liborcus/src/liborcus/xpath_parser \
        UnpackedTarball/liborcus/src/liborcus/yaml_document_tree \
 ))
 
index 93b677303374f7a2e356d084b7c0af75e475a2f4..02781a2040c39d24a512f2f4790bc5f83e669354 100644 (file)
@@ -1,11 +1,11 @@
---- ltmain.sh.sav      2018-09-14 23:47:13.000000000 +0200
-+++ ltmain.sh  2019-05-05 23:11:30.406904472 +0200
-@@ -7278,7 +7278,7 @@ func_mode_link ()
+--- ltmain.sh.orig     2020-09-09 21:20:23.069433984 -0400
++++ ltmain.sh  2020-09-09 21:27:13.168073996 -0400
+@@ -7373,7 +7373,7 @@
        -64|-mips[0-9]|-r[0-9][0-9]*|-xarch=*|-xtarget=*|+DA*|+DD*|-q*|-m*| \
        -t[45]*|-txscale*|-p|-pg|--coverage|-fprofile-*|-F*|@*|-tp=*|--sysroot=*| \
        -O*|-g*|-flto*|-fwhopr*|-fuse-linker-plugin|-fstack-protector*|-stdlib=*| \
--      -specs=*|-fsanitize=*)
-+      -specs=*|-fsanitize=*|-fuse-ld=*)
+-      -specs=*|-fsanitize=*|-fuse-ld=*|-static-*|-fcilkplus)
++      -specs=*|-fsanitize=*|-fuse-ld=*|-static-*|-fcilkplus)
          func_quote_for_eval "$arg"
        arg=$func_quote_for_eval_result
          func_append compile_command " $arg"
index 876bc1688a31e37f5670e823e0a0d6d3ad48fb8c..51aabfa1fb4765dc57639cb7bc35b16a458fd840 100644 (file)
@@ -8,7 +8,7 @@ index ae571f5..539ce18 100644
  
 -#include "constants.inl"
 +#define ORCUS_MAJOR_VERSION 0
-+#define ORCUS_MINOR_VERSION 11
++#define ORCUS_MINOR_VERSION 16
 +#define ORCUS_MICRO_VERSION 0
  
  namespace orcus {
index b298c711d234db520e5e143267811ca7a6594a76..00aea6764957ecc6693cf529c3ae255422462d76 100644 (file)
@@ -62,6 +62,11 @@ public:
     {
         return mnTextEncoding;
     }
+
+    ScDocumentImport& getDoc() const
+    {
+        return mrDoc;
+    }
 };
 
 class ScOrcusRefResolver : public orcus::spreadsheet::iface::import_reference_resolver
@@ -71,20 +76,28 @@ class ScOrcusRefResolver : public orcus::spreadsheet::iface::import_reference_re
 public:
     ScOrcusRefResolver( const ScOrcusGlobalSettings& rGS );
 
-    orcus::spreadsheet::address_t resolve_address(const char* p, size_t n) override;
-    orcus::spreadsheet::range_t resolve_range(const char* p, size_t n) override;
+    orcus::spreadsheet::src_address_t resolve_address(const char* p, size_t n) override;
+    orcus::spreadsheet::src_range_t resolve_range(const char* p, size_t n) override;
 };
 
 class ScOrcusNamedExpression : public orcus::spreadsheet::iface::import_named_expression
 {
     ScDocumentImport& mrDoc;
     const ScOrcusGlobalSettings& mrGlobalSettings;
-    SCTAB mnTab; //< negative if global, else >= 0 for sheet-local named expressions.
+    ScAddress maBasePos;
+    OUString maName;
+    OUString maExpr;
+    const SCTAB mnTab; //< negative if global, else >= 0 for sheet-local named expressions.
 
 public:
     ScOrcusNamedExpression( ScDocumentImport& rDoc, const ScOrcusGlobalSettings& rGS, SCTAB nTab = -1 );
 
-    virtual void define_name(const char* p_name, size_t n_name, const char* p_exp, size_t n_exp) override;
+    void reset();
+
+    virtual void set_base_position(const orcus::spreadsheet::src_address_t& pos) override;
+    virtual void set_named_expression(const char* p_name, size_t n_name, const char* p_exp, size_t n_exp) override;
+    virtual void set_named_range(const char* p_name, size_t n_name, const char* p_range, size_t n_range) override;
+    virtual void commit() override;
 };
 
 class ScOrcusSharedStrings : public orcus::spreadsheet::iface::import_shared_strings
index 220f7ce057f91a216d2d0d62274c085cce0f3064..aa96eb21d40581be0a897467388108ef8ca9618a 100644 (file)
@@ -46,6 +46,7 @@
 #include <sal/log.hxx>
 
 #include <stylesbuffer.hxx>
+#include <orcus/exception.hpp>
 
 using namespace com::sun::star;
 
@@ -158,51 +159,54 @@ orcus::spreadsheet::formula_grammar_t ScOrcusGlobalSettings::get_default_formula
 ScOrcusRefResolver::ScOrcusRefResolver( const ScOrcusGlobalSettings& rGS ) :
     mrGlobalSettings(rGS) {}
 
-os::address_t ScOrcusRefResolver::resolve_address(const char* p, size_t n)
+os::src_address_t ScOrcusRefResolver::resolve_address(const char* p, size_t n)
 {
     OUString aStr(p, n, mrGlobalSettings.getTextEncoding());
 
     ScAddress aAddr;
-    aAddr.Parse(aStr, nullptr,
+    aAddr.Parse(aStr, &mrGlobalSettings.getDoc().getDoc(),
         formula::FormulaGrammar::extractRefConvention(
             mrGlobalSettings.getCalcGrammar()));
 
-    os::address_t ret;
-    ret.column = 0;
-    ret.row = 0;
-
-    if (aAddr.IsValid())
+    if (!aAddr.IsValid())
     {
-        ret.column = aAddr.Col();
-        ret.row = aAddr.Row();
+        std::ostringstream os;
+        os << "'" << std::string(p, n) << "' is not a valid address expression.";
+        throw orcus::invalid_arg_error(os.str());
     }
 
+    os::src_address_t ret;
+    ret.sheet = aAddr.Tab();
+    ret.column = aAddr.Col();
+    ret.row = aAddr.Row();
+
     return ret;
 }
 
-os::range_t ScOrcusRefResolver::resolve_range(const char* p, size_t n)
+os::src_range_t ScOrcusRefResolver::resolve_range(const char* p, size_t n)
 {
     OUString aStr(p, n, mrGlobalSettings.getTextEncoding());
 
     ScRange aRange;
-    aRange.Parse(aStr, nullptr,
+    aRange.Parse(aStr, &mrGlobalSettings.getDoc().getDoc(),
         formula::FormulaGrammar::extractRefConvention(
             mrGlobalSettings.getCalcGrammar()));
 
-    os::range_t ret;
-    ret.first.column = 0;
-    ret.first.row = 0;
-    ret.last.column = 0;
-    ret.last.row = 0;
-
-    if (aRange.IsValid())
+    if (!aRange.IsValid())
     {
-        ret.first.column = aRange.aStart.Col();
-        ret.first.row    = aRange.aStart.Row();
-        ret.last.column  = aRange.aEnd.Col();
-        ret.last.row     = aRange.aEnd.Row();
+        std::ostringstream os;
+        os << "'" << std::string(p, n) << "' is not a valid range expression.";
+        throw orcus::invalid_arg_error(os.str());
     }
 
+    os::src_range_t ret;
+    ret.first.sheet  = aRange.aStart.Tab();
+    ret.first.column = aRange.aStart.Col();
+    ret.first.row    = aRange.aStart.Row();
+    ret.last.sheet   = aRange.aEnd.Tab();
+    ret.last.column  = aRange.aEnd.Col();
+    ret.last.row     = aRange.aEnd.Row();
+
     return ret;
 }
 
@@ -210,20 +214,46 @@ ScOrcusNamedExpression::ScOrcusNamedExpression(
     ScDocumentImport& rDoc, const ScOrcusGlobalSettings& rGS, SCTAB nTab ) :
     mrDoc(rDoc), mrGlobalSettings(rGS), mnTab(nTab) {}
 
-void ScOrcusNamedExpression::define_name(const char* p_name, size_t n_name, const char* p_exp, size_t n_exp)
+void ScOrcusNamedExpression::reset()
+{
+    maBasePos.SetTab(0);
+    maBasePos.SetCol(0);
+    maBasePos.SetRow(0);
+    maName.clear();
+    maExpr.clear();
+}
+
+void ScOrcusNamedExpression::set_base_position(const orcus::spreadsheet::src_address_t& pos)
+{
+    maBasePos.SetTab(pos.sheet);
+    maBasePos.SetCol(pos.column);
+    maBasePos.SetRow(pos.row);
+}
+
+void ScOrcusNamedExpression::set_named_expression(const char* p_name, size_t n_name, const char* p_exp, size_t n_exp)
+{
+    maName = OUString(p_name, n_name, mrGlobalSettings.getTextEncoding());
+    maExpr = OUString(p_exp, n_exp, mrGlobalSettings.getTextEncoding());
+}
+
+void ScOrcusNamedExpression::set_named_range(const char* /*p_name*/, size_t /*n_name*/, const char* /*p_range*/, size_t /*n_range*/)
 {
-    OUString aName(p_name, n_name, mrGlobalSettings.getTextEncoding());
-    OUString aExpr(p_exp, n_exp, mrGlobalSettings.getTextEncoding());
+    throw std::runtime_error("ScOrcusNamedExpression::set_named_range not implemented yet.");
+}
 
+void ScOrcusNamedExpression::commit()
+{
     ScRangeName* pNames = mnTab >= 0 ? mrDoc.getDoc().GetRangeName(mnTab) : mrDoc.getDoc().GetRangeName();
     if (!pNames)
         return;
 
     ScRangeData* pRange = new ScRangeData(
-        &mrDoc.getDoc(), aName, aExpr, ScAddress(), ScRangeData::Type::Name,
+        &mrDoc.getDoc(), maName, maExpr, maBasePos, ScRangeData::Type::Name,
         mrGlobalSettings.getCalcGrammar());
 
     pNames->insert(pRange, false);
+
+    reset(); // make sure to reset the state for the next run.
 }
 
 ScOrcusFactory::CellStoreToken::CellStoreToken(const ScAddress& rPos, Type eType)
index ab16ae66c4bad05831b57cf1ed911bccb0ff15fb..09f3ba9db19aa65227bd35c7de7a1100fdd4c459 100644 (file)
@@ -89,10 +89,9 @@ void populateTree(
        rTreeCtrl.set_image(*xEntry, rParam.maImgElementRepeat, -1);
     }
 
-    orcus::xml_structure_tree::entity_names_type aNames;
+    orcus::xml_structure_tree::entity_names_type aNames = rWalker.get_attributes();
 
     // Insert attributes.
-    rWalker.get_attributes(aNames);
     for (const orcus::xml_structure_tree::entity_name& rAttrName : aNames)
     {
         OUString sAttr(toString(rAttrName, rWalker));
@@ -106,7 +105,7 @@ void populateTree(
         rTreeCtrl.set_image(*xAttr, rParam.maImgAttribute, -1);
     }
 
-    rWalker.get_children(aNames);
+    aNames = rWalker.get_children();
 
     // Non-leaf if it has child elements, leaf otherwise.
     rEntryData.mbLeafNode = aNames.empty();
@@ -266,7 +265,7 @@ void ScOrcusXMLContextImpl::importXML(const ScOrcusImportXMLParam& rParam)
             std::for_each(rLink.maFieldPaths.begin(), rLink.maFieldPaths.end(),
                 [&filter](const OString& rFieldPath)
                 {
-                    filter.append_field_link(rFieldPath.getStr());
+                    filter.append_field_link(rFieldPath.getStr(), orcus::pstring());
                 }
             );
 
index 1eb2e4b0607736b1f47e6e4f1a08ec1c09266566..167ecae315ae5398f926251b391b4195889c2212 100644 (file)
@@ -49,8 +49,12 @@ OUString getXPath(
         if (pData)
             rNamespaces.push_back(pData->mnNamespaceID);
 
+        // element separator is '/' whereas attribute separator is '/@' in xpath.
         aBuf.insert(0, rTree.get_text(*xEntry, 0));
-        aBuf.insert(0, isAttribute(rTree, *xEntry) ? '@' : '/');
+        if (isAttribute(rTree, *xEntry))
+            aBuf.insert(0, "/@");
+        else
+            aBuf.insert(0, '/');
     }
     while (rTree.iter_parent(*xEntry));