SyncOptions: Add default placeholder suffix

Otherwise each test has to set this up anew.

diff --git a/src/libsync/syncengine.cpp b/src/libsync/syncengine.cpp
index 5770a5d3a379d5bd5df86869fada3d4917749981..93cab726f034d9dd11ec1207604ad0f6882da058 100644 (file)
--- a/src/libsync/syncengine.cpp
+++ b/src/libsync/syncengine.cpp
@@ -861,6 +861,12 @@ void SyncEngine::startSync()
     _csync_ctx->new_files_are_placeholders = _syncOptions._newFilesArePlaceholders;
     _csync_ctx->placeholder_suffix = _syncOptions._placeholderSuffix.toUtf8();
 
+    if (_csync_ctx->new_files_are_placeholders && _csync_ctx->placeholder_suffix.isEmpty()) {
+        csyncError(tr("Using placeholder files, but placeholder suffix is not set"));
+        finalize(false);
+        return;
+    }
+
     // If needed, make sure we have up to date E2E information before the
     // discovery phase, otherwise we start right away
     if (_account->capabilities().clientSideEncryptionAvailable()) {

diff --git a/src/libsync/syncoptions.h b/src/libsync/syncoptions.h
index 2e302bda94e82c6e22eb13b27699cbf54aa48c46..ea48cd83e1124bcd70cb341e51cb7057df2c125d 100644 (file)
--- a/src/libsync/syncoptions.h
+++ b/src/libsync/syncoptions.h
@@ -38,7 +38,7 @@ struct SyncOptions
 
     /** Create a placeholder for new files instead of downloading */
     bool _newFilesArePlaceholders = false;
-    QString _placeholderSuffix;
+    QString _placeholderSuffix = ".owncloud";
 
     /** The initial un-adjusted chunk size in bytes for chunked uploads, both
      * for old and new chunking algorithm, which classifies the item to be chunked