Theme: cache the QIcon::fromTheme

We are calling that every time we draw the folder delegate.
Which is a lot when the sync is runing and the progress bar is moving

diff --git a/src/libsync/theme.cpp b/src/libsync/theme.cpp
index 6cb127567512a321eb984aabe7e2fad07c1e86fa..094d6a09d912e853558c019ebf384ba09239f736 100644 (file)
--- a/src/libsync/theme.cpp
+++ b/src/libsync/theme.cpp
@@ -124,14 +124,14 @@ QIcon Theme::themeIcon( const QString& name, bool sysTray ) const
         flavor = QLatin1String("colored");
     }
 
-    if( QIcon::hasThemeIcon( name )) {
-        // use from theme
-        return QIcon::fromTheme( name );
-    }
-
     QString key = name + "," + flavor;
     QIcon & cached = _iconCache[key];
     if (cached.isNull()) {
+        if(QIcon::hasThemeIcon(name)) {
+            // use from theme
+            return cached = QIcon::fromTheme(name);
+        }
+
         QList<int> sizes;
         sizes <<16 << 22 << 32 << 48 << 64 << 128 << 256;
         foreach (int size, sizes) {