x86: Alter nmi_callback_t typedef

Drop paranthesis and function pointer on nmi_callback_t typedef.

Make it more inline with how x86 maintainers want function
typedefs to be.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

diff --git a/xen/arch/x86/alternative.c b/xen/arch/x86/alternative.c
index 26ad2b935f45f61d48b5fe23509044668db892b0..f735ff883d2cfde95c0d8f379bcec90642970652 100644 (file)
--- a/xen/arch/x86/alternative.c
+++ b/xen/arch/x86/alternative.c
@@ -192,7 +192,7 @@ static void __init apply_alternatives(struct alt_instr *start, struct alt_instr
 
 void __init alternative_instructions(void)
 {
-    nmi_callback_t saved_nmi_callback;
+    nmi_callback_t *saved_nmi_callback;
 
     arch_init_ideal_nops();
 

diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c
index 17430e544191b32c7bc1b70f101d478e139392c8..c6c92271e023e12ce0b807fc4525dba7545a91bd 100644 (file)
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -3611,7 +3611,7 @@ static int dummy_nmi_callback(const struct cpu_user_regs *regs, int cpu)
     return 0;
 }
  
-static nmi_callback_t nmi_callback = dummy_nmi_callback;
+static nmi_callback_t *nmi_callback = dummy_nmi_callback;
 
 void do_nmi(const struct cpu_user_regs *regs)
 {
@@ -3641,9 +3641,9 @@ void do_nmi(const struct cpu_user_regs *regs)
     }
 }
 
-nmi_callback_t set_nmi_callback(nmi_callback_t callback)
+nmi_callback_t *set_nmi_callback(nmi_callback_t *callback)
 {
-    nmi_callback_t old_nmi_callback = nmi_callback;
+    nmi_callback_t *old_nmi_callback = nmi_callback;
 
     nmi_callback = callback;
 

diff --git a/xen/include/asm-x86/nmi.h b/xen/include/asm-x86/nmi.h
index 2c92db97a952f29051efd81cd295c4f70cd81d35..fb0f57aa09646715efe6e82446d4ed17fe0754b7 100644 (file)
--- a/xen/include/asm-x86/nmi.h
+++ b/xen/include/asm-x86/nmi.h
@@ -12,7 +12,7 @@ extern bool_t opt_watchdog;
 /* Watchdog force parameter from the command line */
 extern bool_t watchdog_force;
  
-typedef int (*nmi_callback_t)(const struct cpu_user_regs *regs, int cpu);
+typedef int nmi_callback_t(const struct cpu_user_regs *regs, int cpu);
  
 /** 
  * set_nmi_callback
@@ -20,7 +20,7 @@ typedef int (*nmi_callback_t)(const struct cpu_user_regs *regs, int cpu);
  * Set a handler for an NMI. Only one handler may be
  * set. Return the old nmi callback handler.
  */
-nmi_callback_t set_nmi_callback(nmi_callback_t callback);
+nmi_callback_t *set_nmi_callback(nmi_callback_t *callback);
  
 /** 
  * unset_nmi_callback