Fix review comments.

Signed-off-by: alex-z <blackslayer4@gmail.com>

diff --git a/src/gui/passwordinputdialog.cpp b/src/gui/passwordinputdialog.cpp
index 36cc9ca2afe98360eec7ce5578ad13bc26fc0042..a1febe1c3b8fca1fd99152b9118f0ae4639b0a2c 100644 (file)
--- a/src/gui/passwordinputdialog.cpp
+++ b/src/gui/passwordinputdialog.cpp
@@ -19,26 +19,21 @@ namespace OCC {
 
 PasswordInputDialog::PasswordInputDialog(const QString &description, const QString &error, QWidget *parent)
     : QDialog(parent)
-    , ui(new Ui::PasswordInputDialog)
+    , _ui(new Ui::PasswordInputDialog)
 {
-    ui->setupUi(this);
+    _ui->setupUi(this);
 
-    ui->passwordLineEditLabel->setText(description);
-    ui->passwordLineEditLabel->setVisible(!description.isEmpty());
+    _ui->passwordLineEditLabel->setText(description);
+    _ui->passwordLineEditLabel->setVisible(!description.isEmpty());
 
-    ui->labelErrorMessage->setText(error);
-    ui->labelErrorMessage->setVisible(!error.isEmpty());
+    _ui->labelErrorMessage->setText(error);
+    _ui->labelErrorMessage->setVisible(!error.isEmpty());
 
     setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
 }
 
-PasswordInputDialog::~PasswordInputDialog()
-{
-    delete ui;
-}
-
 QString PasswordInputDialog::password() const
 {
-    return ui->passwordLineEdit->text();
+    return _ui->passwordLineEdit->text();
 }
 }

diff --git a/src/gui/passwordinputdialog.h b/src/gui/passwordinputdialog.h
index 151e7df7417ec987ad7be94d1d828465c848d5c8..fc7b7da6b912c2e22e681296693954b5a1ea5888 100644 (file)
--- a/src/gui/passwordinputdialog.h
+++ b/src/gui/passwordinputdialog.h
@@ -28,12 +28,11 @@ class PasswordInputDialog : public QDialog
 
 public:
     explicit PasswordInputDialog(const QString &description, const QString &error, QWidget *parent = nullptr);
-    ~PasswordInputDialog() override;
 
     QString password() const;
 
 private:
-    Ui::PasswordInputDialog *ui;
+    std::unique_ptr<Ui::PasswordInputDialog> _ui;
 };
 
 }