modelbutton: Fix a use after free when unsetting accel
authorAlice Mikhaylenko <alexm@gnome.org>
Sun, 7 May 2023 11:21:16 +0000 (15:21 +0400)
committerAlice Mikhaylenko <alexm@gnome.org>
Sun, 7 May 2023 11:21:16 +0000 (15:21 +0400)
gtk_widget_remove_controller() already destroys the controller.

gtk/gtkmodelbutton.c

index a296e6119c6b927d6dbc590051d4d5444048504f..cd8052fe849c0e1911a0649cb1e356ec13a09543 100644 (file)
@@ -877,7 +877,7 @@ update_accel (GtkModelButton *self,
       if (self->controller)
         {
           gtk_widget_remove_controller (GTK_WIDGET (self), GTK_EVENT_CONTROLLER (self->controller));
-          g_clear_object (&self->controller);
+          self->controller = NULL;
         }
     }
 }