Clean up check for equality between sharee display names

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

diff --git a/src/gui/filedetails/sharemodel.cpp b/src/gui/filedetails/sharemodel.cpp
index 96640e51e3ba3ff6bef3d61aad19c531c1a90316..c864993f9ec0a68340d7dddd34e1e4efde0b5e8f 100644 (file)
--- a/src/gui/filedetails/sharemodel.cpp
+++ b/src/gui/filedetails/sharemodel.cpp
@@ -504,16 +504,14 @@ void ShareModel::slotSharesFetched(const QList<SharePtr> &shares)
         auto hasDuplicates = false;
         for (auto j = i + 1; j < shareCount; ++j) {
             const auto otherSharee = _shares.at(j)->getShareWith();
-            if (otherSharee == nullptr) {
+            if (otherSharee == nullptr || sharee->format() != otherSharee->format()) {
                 continue;
             }
 
-            if (sharee->format() == otherSharee->format()) {
-                hasDuplicates = true; // Reassign is faster
-                _duplicateDisplayNameShareIndices.insert(j);
-                const auto targetIndex = index(j);
-                dataChanged(targetIndex, targetIndex, {Qt::DisplayRole});
-            }
+            hasDuplicates = true; // Reassign is faster
+            _duplicateDisplayNameShareIndices.insert(j);
+            const auto targetIndex = index(j);
+            dataChanged(targetIndex, targetIndex, {Qt::DisplayRole});
         }
 
         if (hasDuplicates) {