netfilter: xt_socket: fix a typo in socket_mt_destroy()
authorEric Dumazet <edumazet@google.com>
Wed, 9 Feb 2022 02:30:43 +0000 (18:30 -0800)
committerSalvatore Bonaccorso <carnil@debian.org>
Fri, 25 Feb 2022 17:15:16 +0000 (17:15 +0000)
Origin: https://git.kernel.org/linus/75063c9294fb239bbe64eb72141b6871fe526d29

Calling nf_defrag_ipv4_disable() instead of nf_defrag_ipv6_disable()
was probably not the intent.

I found this by code inspection, while chasing a possible issue in TPROXY.

Fixes: de8c12110a13 ("netfilter: disable defrag once its no longer needed")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name netfilter-xt_socket-fix-a-typo-in-socket_mt_destroy.patch

net/netfilter/xt_socket.c

index 5e6459e1160553c0a563a38b5060815e88998b4d..662e5eb1cc39e544191b3aab388c3762674d9251 100644 (file)
@@ -221,7 +221,7 @@ static void socket_mt_destroy(const struct xt_mtdtor_param *par)
        if (par->family == NFPROTO_IPV4)
                nf_defrag_ipv4_disable(par->net);
        else if (par->family == NFPROTO_IPV6)
-               nf_defrag_ipv4_disable(par->net);
+               nf_defrag_ipv6_disable(par->net);
 }
 
 static struct xt_match socket_mt_reg[] __read_mostly = {