Simplify password generation in sharemodel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

diff --git a/src/gui/filedetails/sharemodel.cpp b/src/gui/filedetails/sharemodel.cpp
index 03ce26f84c1237f202e54340387a1ad6f71f57ee..1315c69d45163a2735457fca329b330fce225daa 100644 (file)
--- a/src/gui/filedetails/sharemodel.cpp
+++ b/src/gui/filedetails/sharemodel.cpp
@@ -37,10 +37,15 @@ QString createRandomPassword()
     constexpr auto numChars = 24;
     QString passwd;
 
-    while(passwd.length() < numChars) {
-        const auto remainingChars = numChars - passwd.length();
-        unsigned char unsignedCharArray[remainingChars];
-        RAND_bytes(unsignedCharArray, remainingChars);
+    unsigned char unsignedCharArray[numChars];
+    RAND_bytes(unsignedCharArray, numChars);
+
+    for (auto i = 0; i < numChars; i++) {
+        auto byte = unsignedCharArray[i];
+        byte %= asciiRange;
+        byte += asciiMin;
+        passwd.append(byte);
+    }
 
         for (auto i = 0; i < remainingChars; i++) {
             auto byte = unsignedCharArray[i];