FolderWizard: fix crash when experimental feature are disabled
authorOlivier Goffart <ogoffart@woboq.com>
Tue, 15 May 2018 10:29:45 +0000 (12:29 +0200)
committerKevin Ottens <kevin.ottens@nextcloud.com>
Tue, 15 Dec 2020 09:57:52 +0000 (10:57 +0100)
The _placeholderCheckBox only exists if the experimental features are enabled

Found via the crash reporter
https://sentry.io/owncloud/desktop-win-and-mac/issues/556407777/

src/gui/folderwizard.cpp
src/gui/folderwizard.h

index 3365899311c639acdcb388edaca6daa9887ec131..90f750d66ea94b535576b9410a9b793e3514ab64 100644 (file)
@@ -524,7 +524,7 @@ void FolderWizardSelectiveSync::initializePage()
 bool FolderWizardSelectiveSync::validatePage()
 {
     wizard()->setProperty("selectiveSyncBlackList", QVariant(_selectiveSync->createBlackList()));
-    wizard()->setProperty("usePlaceholders", QVariant(_placeholderCheckBox->isChecked()));
+    wizard()->setProperty("usePlaceholders", QVariant(_placeholderCheckBox && _placeholderCheckBox->isChecked()));
     return true;
 }
 
index 7255e699519adb2e34c5e976b6ed06e4f3ce88ba..32e548f011312fa25eda85c0fc34d2782edf1d0e 100644 (file)
@@ -135,7 +135,7 @@ private slots:
 
 private:
     SelectiveSyncWidget *_selectiveSync;
-    QCheckBox *_placeholderCheckBox;
+    QCheckBox *_placeholderCheckBox = nullptr;
 };
 
 /**