Eliminate unneeded parent Item in FileActivityView

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

diff --git a/src/gui/filedetails/FileActivityView.qml b/src/gui/filedetails/FileActivityView.qml
index 47fbe35be5abc4bc69c5b1d5cd0b67de5d7f7f1d..002654b7955bc2abd3cf207922b652ba12ad38f0 100644 (file)
--- a/src/gui/filedetails/FileActivityView.qml
+++ b/src/gui/filedetails/FileActivityView.qml
@@ -20,28 +20,14 @@ import com.nextcloud.desktopclient 1.0
 import Style 1.0
 import "../tray"
 
-Item {
+ActivityList {
     id: root
 
-    property string localPath: ""
-    property var accountState: ({})
-    property int horizontalPadding: 0
-    property int iconSize: 32
-    property alias model: activityModel
+    property alias localPath: activityListModel.localPath
+    property alias accountState: activityListModel.accountState
 
-    FileActivityListModel {
-        id: activityModel
-        localPath: root.localPath
-        accountState: root.accountState
-    }
-
-    ActivityList {
-        anchors.fill: parent
-        anchors.leftMargin: root.horizontalPadding
-        anchors.rightMargin: root.horizontalPadding
-
-        iconSize: root.iconSize
-        isFileActivityList: true
-        model: root.model
+    isFileActivityList: true
+    model: FileActivityListModel {
+        id: activityListModel
     }
 }

diff --git a/src/gui/filedetails/FileDetailsPage.qml b/src/gui/filedetails/FileDetailsPage.qml
index 3e31f102a9e711a59129b4ad23a5aa23580facc9..fc39825a3557ca5c0b88d8206a521ec18e80615f 100644 (file)
--- a/src/gui/filedetails/FileDetailsPage.qml
+++ b/src/gui/filedetails/FileDetailsPage.qml
@@ -168,9 +168,10 @@ Page {
 
             property int swipeIndex: SwipeView.index
 
+            delegateHorizontalPadding: root.intendedPadding
+
             accountState: root.accountState
             localPath: root.localPath
-            horizontalPadding: root.intendedPadding
             iconSize: root.iconSize
         }
 

diff --git a/src/gui/tray/ActivityList.qml b/src/gui/tray/ActivityList.qml
index d01c566e1b7ab6cd6a7cb686f9cb42cc14d9a9ac..18e15e6634c790455ea38aa86facaceb8defe4a4 100644 (file)
--- a/src/gui/tray/ActivityList.qml
+++ b/src/gui/tray/ActivityList.qml
@@ -11,6 +11,7 @@ ScrollView {
 
     property bool isFileActivityList: false
     property int iconSize: Style.trayListItemIconSize
+    property int delegateHorizontalPadding: 0
 
     signal openFile(string filePath)
     signal activityItemClicked(int index)
@@ -38,8 +39,9 @@ ScrollView {
 
         highlight: Rectangle {
             id: activityHover
-            width: activityList.currentItem.width
-            height: activityList.currentItem.height
+
+            anchors.fill: activityList.currentItem
+
             color: Style.lightHover
             visible: activityList.activeFocus
         }
@@ -56,9 +58,13 @@ ScrollView {
         }
 
         delegate: ActivityItem {
+            anchors.left: parent.left
+            anchors.right: parent.right
+            anchors.leftMargin: controlRoot.delegateHorizontalPadding
+            anchors.rightMargin: controlRoot.delegateHorizontalPadding
+
             isFileActivityList: controlRoot.isFileActivityList
             iconSize: controlRoot.iconSize
-            width: activityList.contentWidth
             flickable: activityList
             onHoveredChanged: if (hovered) {
                 // When we set the currentIndex the list view will scroll...