Rename SyncFileStatus::sharedWithMe to shared
authorOlivier Goffart <ogoffart@woboq.com>
Tue, 15 Nov 2016 12:58:18 +0000 (13:58 +0100)
committerOlivier Goffart <olivier@woboq.com>
Tue, 15 Nov 2016 13:32:20 +0000 (14:32 +0100)
Last commit for issue #4788 made the meaning to be simply shared
(with the user or from the user)

src/libsync/syncfilestatus.cpp
src/libsync/syncfilestatus.h
src/libsync/syncfilestatustracker.cpp
test/testsyncfilestatustracker.cpp

index c81a647459a1a41ef1637d4399778b08e178d144..169be2bc8053bc6cdd71ee3864a672780b1e0b15 100644 (file)
 
 namespace OCC {
 SyncFileStatus::SyncFileStatus()
-    :_tag(StatusNone), _sharedWithMe(false)
+    :_tag(StatusNone), _shared(false)
 {
 }
 
 SyncFileStatus::SyncFileStatus(SyncFileStatusTag tag)
-    :_tag(tag), _sharedWithMe(false)
+    :_tag(tag), _shared(false)
 {
 
 }
@@ -37,14 +37,14 @@ SyncFileStatus::SyncFileStatusTag SyncFileStatus::tag() const
     return _tag;
 }
 
-void SyncFileStatus::setSharedWithMe(bool isShared)
+void SyncFileStatus::setShared(bool isShared)
 {
-    _sharedWithMe = isShared;
+    _shared = isShared;
 }
 
-bool SyncFileStatus::sharedWithMe() const
+bool SyncFileStatus::shared() const
 {
-    return _sharedWithMe;
+    return _shared;
 }
 
 QString SyncFileStatus::toSocketAPIString() const
@@ -72,7 +72,7 @@ QString SyncFileStatus::toSocketAPIString() const
         statusString = QLatin1String("ERROR");
         break;
     }
-    if(canBeShared && _sharedWithMe) {
+    if(canBeShared && _shared) {
         statusString += QLatin1String("+SWM");
     }
 
index 83a658ce3ccf8229d591efddaeb6458537cb3c09..6fda24c1603aafcabcca4aefbcbe46e6eedbb0ca 100644 (file)
@@ -43,18 +43,18 @@ public:
     void set(SyncFileStatusTag tag);
     SyncFileStatusTag tag() const;
 
-    void setSharedWithMe( bool isShared );
-    bool sharedWithMe() const;
+    void setShared( bool isShared );
+    bool shared() const;
 
     QString toSocketAPIString() const;
 private:
     SyncFileStatusTag _tag;
-    bool _sharedWithMe;
+    bool _shared;
 
 };
 
 inline bool operator==(const SyncFileStatus &a, const SyncFileStatus &b) {
-    return a.tag() == b.tag() && a.sharedWithMe() == b.sharedWithMe();
+    return a.tag() == b.tag() && a.shared() == b.shared();
 }
 
 inline bool operator!=(const SyncFileStatus &a, const SyncFileStatus &b) {
index 6ca41e219402647e94c36833601160f4d6a2577a..b7c26bb5c153fb9a0ca2dfbc43112fa73e5459fa 100644 (file)
@@ -272,7 +272,7 @@ SyncFileStatus SyncFileStatusTracker::resolveSyncAndErrorStatus(const QString &r
     }
 
     if (isShared)
-        status.setSharedWithMe(true);
+        status.setShared(true);
 
     return status;
 }
index 32cba399d6f69b3f51ae0e7bf21cc9d607afa9b8..897d47a97004313cc5b556de7ad86401ec9e4cef 100644 (file)
@@ -371,7 +371,7 @@ private slots:
 
     void sharedStatus() {
         SyncFileStatus sharedUpToDateStatus(SyncFileStatus::StatusUpToDate);
-        sharedUpToDateStatus.setSharedWithMe(true);
+        sharedUpToDateStatus.setShared(true);
 
         FakeFolder fakeFolder{FileInfo::A12_B12_C12_S12()};
         fakeFolder.remoteModifier().insert("S/s0");
@@ -399,7 +399,7 @@ private slots:
         QEXPECT_FAIL("", "We currently only know if a new file is shared on the second sync, after a PROPFIND.", Continue);
         QCOMPARE(statusSpy.statusOf("S/s0"), sharedUpToDateStatus);
         QCOMPARE(statusSpy.statusOf("S/s1"), sharedUpToDateStatus);
-        QCOMPARE(statusSpy.statusOf("B/b1").sharedWithMe(), false);
+        QCOMPARE(statusSpy.statusOf("B/b1").shared(), false);
         QCOMPARE(statusSpy.statusOf("B/b3"), sharedUpToDateStatus);
 
         QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());