drm/panel: rpi-touchscreen: propagate errors in rpi_touchscreen_i2c_read()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 20 Oct 2017 00:28:45 +0000 (03:28 +0300)
committerRaspbian kernel package updater <root@raspbian.org>
Sat, 31 Mar 2018 14:57:32 +0000 (15:57 +0100)
There is one caller which checks whether rpi_touchscreen_i2c_read()
returns negative error codes.  Currently it can't because negative
error codes are truncated to u8, but that's easy to fix if we change the
type to int.

Fixes: 2f733d6194bd ("drm/panel: Add support for the Raspberry Pi 7" Touchscreen.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20171020002845.kar2wg7gqxg7tzqi@mwanda
Reviewed-by: Eric Anholt <eric@anholt.net>
(cherry picked from commit 85b4587f8e94143bafb8b6a4003a5187b9a8753d)

drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c

index b57b7ad9aa4c5048186e98553af59ec912973096..128523d8d51873f7835fb95562d05aed539c06c0 100644 (file)
@@ -243,7 +243,7 @@ static struct rpi_touchscreen *panel_to_ts(struct drm_panel *panel)
        return container_of(panel, struct rpi_touchscreen, base);
 }
 
-static u8 rpi_touchscreen_i2c_read(struct rpi_touchscreen *ts, u8 reg)
+static int rpi_touchscreen_i2c_read(struct rpi_touchscreen *ts, u8 reg)
 {
        return i2c_smbus_read_byte_data(ts->bridge_i2c, reg);
 }