Remove setting connection status from fileproviderdomainmanager, this will be handled...

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

diff --git a/src/gui/macOS/fileproviderdomainmanager.h b/src/gui/macOS/fileproviderdomainmanager.h
index a788bf8ddd13643c85267b6687e5c75516fb15ab..8c5544d6235924a0b0eee544a2014393c267f5c3 100644 (file)
--- a/src/gui/macOS/fileproviderdomainmanager.h
+++ b/src/gui/macOS/fileproviderdomainmanager.h
@@ -35,7 +35,6 @@ private slots:
 
     void addFileProviderDomainForAccount(OCC::AccountState *accountState);
     void removeFileProviderDomainForAccount(OCC::AccountState *accountState);
-    void setFileProviderForAccountIsConnected(OCC::AccountState *accountState);
 
 private:
     explicit FileProviderDomainManager(QObject *parent = nullptr);

diff --git a/src/gui/macOS/fileproviderdomainmanager_mac.mm b/src/gui/macOS/fileproviderdomainmanager_mac.mm
index 2249ecab73af8d691fc782fd16a55723773c7332..64783769339177949bb8c15a58bcee6566333504 100644 (file)
--- a/src/gui/macOS/fileproviderdomainmanager_mac.mm
+++ b/src/gui/macOS/fileproviderdomainmanager_mac.mm
@@ -126,50 +126,6 @@ class FileProviderDomainManager::Private {
         }];
     }
 
-    void setFileProviderDomainConnected(const AccountState *accountState)
-    {
-        const QString accountDisplayName = accountState->account()->displayName();
-        const QString accountId = accountState->account()->id();
-        const bool accountIsConnected = accountState->isConnected();
-
-        qCDebug(lcMacFileProviderDomainManager) << "Account state for account changed: "
-                                                << accountDisplayName
-                                                << accountIsConnected;
-
-        if(!_registeredDomains.contains(accountId)) {
-            qCDebug(lcMacFileProviderDomainManager) << "File provider domain not found for id: " << accountId;
-            return;
-        }
-
-        NSFileProviderDomain* accountDomain = _registeredDomains.value(accountId);
-        NSFileProviderManager* providerManager = [NSFileProviderManager managerForDomain:accountDomain];
-
-        if(accountIsConnected) {
-            [providerManager reconnectWithCompletionHandler:^(NSError *error) {
-                if(error) {
-                    qCDebug(lcMacFileProviderDomainManager) << "Error reconnecting file provider domain: "
-                                                            << accountDisplayName
-                                                            << [error code]
-                                                            << [error localizedDescription];
-                }
-            }];
-        } else {
-            NSString* reason = @"Nextcloud account disconnected.";
-            const auto isTemporary = accountState->state() != AccountState::SignedOut &&
-                                     accountState->state() != AccountState::ConfigurationError;
-            NSFileProviderManagerDisconnectionOptions disconnectOption = isTemporary ? 0 : NSFileProviderManagerDisconnectionOptionsTemporary;
-
-            [providerManager disconnectWithReason:reason options:disconnectOption completionHandler:^(NSError *error) {
-                if(error) {
-                    qCDebug(lcMacFileProviderDomainManager) << "Error disconnecting file provider domain: "
-                                               << accountDisplayName
-                                               << [error code]
-                                               << [error localizedDescription];
-                }
-            }];
-        }
-    }
-
 private:
     QHash<QString, NSFileProviderDomain*> _registeredDomains;
 };
@@ -211,9 +167,6 @@ void FileProviderDomainManager::setupFileProviderDomains()
 void FileProviderDomainManager::addFileProviderDomainForAccount(AccountState *accountState)
 {
     d->addFileProviderDomain(accountState);
-
-    connect(accountState, &AccountState::isConnectedChanged,
-            this, [this, accountState]{ setFileProviderForAccountIsConnected(accountState); });
 }
 
 void FileProviderDomainManager::removeFileProviderDomainForAccount(AccountState* accountState)
@@ -221,11 +174,6 @@ void FileProviderDomainManager::removeFileProviderDomainForAccount(AccountState*
     d->removeFileProviderDomain(accountState);
 }
 
-void FileProviderDomainManager::setFileProviderForAccountIsConnected(AccountState *accountState)
-{
-    d->setFileProviderDomainConnected(accountState);
-}
-
 } // namespace Mac
 
 } // namespace OCC