signatures: Fix leak in _sign_detached_metadata_append()
authorAlexander Larsson <alexl@redhat.com>
Wed, 16 Sep 2020 13:54:03 +0000 (15:54 +0200)
committerAlexander Larsson <alexl@redhat.com>
Thu, 8 Oct 2020 12:10:04 +0000 (14:10 +0200)
This needs to ref_sink the returned variant, as it is used with g_autoptr
in the callers.

src/libostree/ostree-sign.c

index ee7e928d14a2f412d39f4d21c15403bc1a00205d..eeef96dd8b46cfe429c092919b2aa443a1152b36 100644 (file)
@@ -365,7 +365,7 @@ _sign_detached_metadata_append (OstreeSign *self,
                                signature_key,
                                g_variant_builder_end (signature_builder));
 
-  return  g_variant_dict_end (&metadata_dict);
+  return  g_variant_ref_sink (g_variant_dict_end (&metadata_dict));
 }
 
 /**