mediacontrols: Add tooltip text to play button
authorMaximiliano Sandoval R <msandova@gnome.org>
Thu, 6 Apr 2023 10:10:11 +0000 (12:10 +0200)
committerMatthias Clasen <mclasen@redhat.com>
Fri, 21 Apr 2023 07:06:51 +0000 (09:06 +0200)
This makes the button accessible.

gtk/gtkmediacontrols.c
gtk/ui/gtkmediacontrols.ui
po/POTFILES.in

index 20935aa69d1260e58e5dcc2025beefebb27fcfd5..e55577ffa0c901210e4ad324fa4ba83a46a1c022 100644 (file)
@@ -399,6 +399,7 @@ update_playing (GtkMediaControls *controls)
 {
   gboolean playing;
   const char *icon_name;
+  const char *tooltip_text;
 
   if (controls->stream)
     playing = gtk_media_stream_get_playing (controls->stream);
@@ -406,11 +407,18 @@ update_playing (GtkMediaControls *controls)
     playing = FALSE;
 
   if (playing)
-    icon_name = "media-playback-pause-symbolic";
+    {
+      icon_name = "media-playback-pause-symbolic";
+      tooltip_text = C_("media controls tooltip", "Stop");
+    }
   else
-    icon_name = "media-playback-start-symbolic";
+    {
+      icon_name = "media-playback-start-symbolic";
+      tooltip_text = C_("media controls tooltip", "Play");
+    }
 
   gtk_button_set_icon_name (GTK_BUTTON (controls->play_button), icon_name);
+  gtk_widget_set_tooltip_text (controls->play_button, tooltip_text);
 }
 
 static void
index 08799d64e6b65187d53889d114009e73b287f0f9..1c791437afcd0c85741147fb0ef181f5e13954cd 100644 (file)
@@ -25,6 +25,7 @@
             <property name="valign">3</property>
             <property name="has-frame">0</property>
             <property name="icon-name">media-playback-start-symbolic</property>
+            <property name="tooltip-text" context="media controls tooltip" translatable="yes">Play</property>
             <signal name="clicked" handler="play_button_clicked" object="GtkMediaControls" swapped="no"/>
           </object>
         </child>
index c0719e6fa50adebe2574c0c9effe14580cad9a47..7b3cf70e2d6399fab71f05925652e73421db5782 100644 (file)
@@ -398,6 +398,7 @@ gtk/ui/gtkfilechooserwidget.ui
 gtk/ui/gtkfontchooserdialog.ui
 gtk/ui/gtkfontchooserwidget.ui
 gtk/ui/gtklockbutton.ui
+gtk/ui/gtkmediacontrols.ui
 gtk/ui/gtkmessagedialog.ui
 gtk/ui/gtkpagesetupunixdialog.ui
 gtk/ui/gtkplacesviewrow.ui