do-not-second-guess-sonames
authorDebian OpenLDAP Maintainers <pkg-openldap-devel@lists.alioth.debian.org>
Mon, 7 Sep 2020 16:47:28 +0000 (17:47 +0100)
committerRyan Tandy <ryan@nardis.ca>
Mon, 7 Sep 2020 16:47:28 +0000 (17:47 +0100)
Rip out code that second-guesses the libsasl soname / Debian shlibs.  If
cyrus sasl upstream is breaking the ABI, this needs to be fixed upstream
there, not kludged around upstream here!

Debian bug #546885

Upstream ITS #6302 filed.

Gbp-Pq: Name do-not-second-guess-sonames

libraries/libldap/cyrus.c
servers/slapd/sasl.c

index a1b943948675a092ecdc7b9c03ce1ab6295dcb8e..68e6eb7f7c2a80758ec7b3b73dfdb6e38bacc2ec 100644 (file)
@@ -74,28 +74,6 @@ static const sasl_callback_t client_callbacks[] = {
  */
 int ldap_int_sasl_init( void )
 {
-#ifdef HAVE_SASL_VERSION
-       /* stringify the version number, sasl.h doesn't do it for us */
-#define VSTR0(maj, min, pat)   #maj "." #min "." #pat
-#define VSTR(maj, min, pat)    VSTR0(maj, min, pat)
-#define SASL_VERSION_STRING    VSTR(SASL_VERSION_MAJOR, SASL_VERSION_MINOR, \
-                               SASL_VERSION_STEP)
-       { int rc;
-       sasl_version( NULL, &rc );
-       if ( ((rc >> 16) != ((SASL_VERSION_MAJOR << 8)|SASL_VERSION_MINOR)) ||
-               (rc & 0xffff) < SASL_VERSION_STEP) {
-               char version[sizeof("xxx.xxx.xxxxx")];
-               sprintf( version, "%u.%d.%d", (unsigned)rc >> 24, (rc >> 16) & 0xff,
-                       rc & 0xffff );
-
-               Debug( LDAP_DEBUG_ANY,
-               "ldap_int_sasl_init: SASL library version mismatch:"
-               " expected " SASL_VERSION_STRING ","
-               " got %s\n", version, 0, 0 );
-               return -1;
-       }
-       }
-#endif
 
 /* SASL 2 takes care of its own memory completely internally */
 #if SASL_VERSION_MAJOR < 2 && !defined(CSRIMALLOC)
index 5df88b9c0351f4eca4935a1a64b109a263e3ecb7..c03f397b6a57666b8e97ef5ffb3acf17a949c027 100644 (file)
@@ -1158,26 +1158,6 @@ int slap_sasl_init( void )
 #endif
 
 #ifdef HAVE_CYRUS_SASL
-#ifdef HAVE_SASL_VERSION
-       /* stringify the version number, sasl.h doesn't do it for us */
-#define        VSTR0(maj, min, pat)    #maj "." #min "." #pat
-#define        VSTR(maj, min, pat)     VSTR0(maj, min, pat)
-#define        SASL_VERSION_STRING     VSTR(SASL_VERSION_MAJOR, SASL_VERSION_MINOR, \
-                               SASL_VERSION_STEP)
-
-       sasl_version( NULL, &rc );
-       if ( ((rc >> 16) != ((SASL_VERSION_MAJOR << 8)|SASL_VERSION_MINOR)) ||
-               (rc & 0xffff) < SASL_VERSION_STEP)
-       {
-               char version[sizeof("xxx.xxx.xxxxx")];
-               sprintf( version, "%u.%d.%d", (unsigned)rc >> 24, (rc >> 16) & 0xff,
-                       rc & 0xffff );
-               Debug( LDAP_DEBUG_ANY, "slap_sasl_init: SASL library version mismatch:"
-                       " expected %s, got %s\n",
-                       SASL_VERSION_STRING, version, 0 );
-               return -1;
-       }
-#endif
 
        sasl_set_mutex(
                ldap_pvt_sasl_mutex_new,