tg-single-select-timeout

commit fffcbbb0b5ff8864086f7b58fdbb8aa4c71943d0
Author: Richard Braun <rbraun@sceen.net>
Date:   Mon Dec 17 09:57:41 2012 +0000

    Fix _hurd_select for single fd sets

    The function attempts to optimize this case by performing one IPC system call
    with the timeout included among the parameters, but in the absence of a reply,
    it will call mach_msg again with the same timeout later, effectively doubling
    the total timeout of the select/poll call.

    Remove this optimization for the time being.

    * hurd/hurdselect.c (_hurd_select): Always call __io_select with no timeout.

Gbp-Pq: Topic hurd-i386
Gbp-Pq: Name tg-single-select-timeout.diff

diff --git a/hurd/hurdselect.c b/hurd/hurdselect.c
index 22aac59d688d156bbd012f275dea72975d4dbce2..2112b0f850718bd8a65d1b3c366ffb86fdf8e463 100644 (file)
--- a/hurd/hurdselect.c
+++ b/hurd/hurdselect.c
@@ -236,10 +236,7 @@ _hurd_select (int nfds,
          {
            int type = d[i].type;
            d[i].reply_port = __mach_reply_port ();
-           err = __io_select (d[i].io_port, d[i].reply_port,
-                              /* Poll only if there's a single descriptor.  */
-                              (firstfd == lastfd) ? to : 0,
-                              &type);
+           err = __io_select (d[i].io_port, d[i].reply_port, 0, &type);
            switch (err)
              {
              case MACH_RCV_TIMED_OUT: