add missing libs deps

Bug-Debian: https://bugs.debian.org/1010922

Lots of samba libraries has incomplete dependencies listed
in wscript files.  This usually is not a problem since the
link line includes dependencies of their dependencies of
their dependencies, and somewhere down that line all immediate
dependencies which are missing are actually present.  But
sometimes this becomes a problem when a library does not
declare direct dependency on at least one private library
which it actually uses: in case no private library is
listed as direct dependency, private library directory is
not put into RUNPATH of the resulting binary, so the binary
can not find its own dependencies.

Fix a few such places, including one library which is a part
of public abi (libsmbldap).

Gbp-Pq: Name add-missing-libs-deps.diff

diff --git a/lib/util/wscript_build b/lib/util/wscript_build
index b4fcfeaba07c576fcc2eee7a0f0762ab594fae0f..875c90710402b9a6c0a114a4e3571517497cabae 100644 (file)
--- a/lib/util/wscript_build
+++ b/lib/util/wscript_build
@@ -243,7 +243,7 @@ else:
 
     bld.SAMBA_LIBRARY('samba-modules',
                       source='modules.c',
-                      deps='samba-errors samba-util',
+                      deps='samba-errors samba-util samba-debug',
                       local_include=False,
                       private_library=True)
 

diff --git a/source3/wscript_build b/source3/wscript_build
index 092fa4bf796fa5542714816d794032a5bdcbe3f7..faac6f35d64ca137c1ac2a9196dc7185500b1a43 100644 (file)
--- a/source3/wscript_build
+++ b/source3/wscript_build
@@ -188,7 +188,7 @@ bld.SAMBA3_LIBRARY('smbldaphelper',
                           passdb/pdb_ldap_schema.c
                           passdb/pdb_ldap_util.c
                           ''',
-                   deps='smbldap secrets3',
+                   deps='smbldap secrets3 replace',
                    allow_undefined_symbols=True,
                    enabled=bld.CONFIG_SET('HAVE_LDAP'),
                    private_library=True)
@@ -481,7 +481,7 @@ bld.SAMBA3_LIBRARY('secrets3',
 
 bld.SAMBA3_LIBRARY('smbldap',
                     source='lib/smbldap.c',
-                    deps='ldap lber samba-util smbconf',
+                    deps='ldap lber samba-util smbconf replace samba-debug samba-security',
                     enabled=bld.CONFIG_SET("HAVE_LDAP"),
                     private_library=False,
                     abi_directory='lib/ABI',