accelgroup: Fix a buffer overrun

gtk_accelerator_parse_with_keycode can
overrun its buffer for certain inputs.

Fixes: https://gitlab.gnome.org/GNOME/gtk/issues/2325

diff --git a/gtk/gtkaccelgroup.c b/gtk/gtkaccelgroup.c
index f09764ec740e4e029adf7db5bd0ce6dad3442b73..dbf4e261af739e4d20e3e1981246f11ca251a9fe 100644 (file)
--- a/gtk/gtkaccelgroup.c
+++ b/gtk/gtkaccelgroup.c
@@ -1295,9 +1295,9 @@ gtk_accelerator_parse_with_keycode (const gchar     *accelerator,
               last_ch = *accelerator;
               while (last_ch && last_ch != '>')
                 {
-                  last_ch = *accelerator;
                   accelerator += 1;
                   len -= 1;
+                  last_ch = *accelerator;
                 }
             }
         }