VT-d: fix off-by-one error in RMRR validation
authorJan Beulich <jbeulich@suse.com>
Thu, 22 Sep 2011 17:32:34 +0000 (18:32 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 22 Sep 2011 17:32:34 +0000 (18:32 +0100)
(base_addr,end_addr) is an inclusive range, and hence there shouldn't
be a subtraction of 1 in the second invocation of page_is_ram_type().
For RMRRs covering a single page that actually resulted in the
immediately preceding page to get checked (which could have resulted
in a false warning).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
xen/drivers/passthrough/vtd/dmar.c

index 55801702756512ad2279a99d977b2694b6ae1c14..81a50f221e2ed9f75d9def9c757e011eeb13be59 100644 (file)
@@ -520,7 +520,7 @@ acpi_parse_one_rmrr(struct acpi_dmar_entry_header *header)
      * inform the user
      */
     if ( (!page_is_ram_type(paddr_to_pfn(base_addr), RAM_TYPE_RESERVED)) ||
-         (!page_is_ram_type(paddr_to_pfn(end_addr) - 1, RAM_TYPE_RESERVED)) )
+         (!page_is_ram_type(paddr_to_pfn(end_addr), RAM_TYPE_RESERVED)) )
     {
         dprintk(XENLOG_WARNING VTDPREFIX,
                 "  RMRR address range not in reserved memory "