x86,amd,microcode: fix hypercall return code
authorKeir Fraser <keir.fraser@citrix.com>
Mon, 22 Sep 2008 12:41:07 +0000 (13:41 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Mon, 22 Sep 2008 12:41:07 +0000 (13:41 +0100)
Make the hypercall return failure if the microcode didn't apply.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
xen/arch/x86/microcode_amd.c

index 77f4dd2a57e3f3c2d0224c58972c45f3917d7f2f..ca72f195af0d88686163d4b6a130ccfbf3ba579c 100644 (file)
@@ -337,10 +337,7 @@ static int cpu_request_microcode(int cpu, const void *buf, size_t size)
          * lets keep searching till the latest version
          */
         if ( error == 1 )
-        {
-            apply_microcode(cpu);
-            error = 0;
-        }
+            error = apply_microcode(cpu);
         xfree(mc);
     }
     if ( offset > 0 )