builder-tool: Don't simplify enums too much
authorBenjamin Otte <otte@redhat.com>
Sun, 21 Nov 2021 00:51:35 +0000 (01:51 +0100)
committerBenjamin Otte <otte@redhat.com>
Sun, 21 Nov 2021 01:19:57 +0000 (02:19 +0100)
Store the enum nick, not the enum value. That way the file remains
human-readable.

Updated reftests to new expected output.

testsuite/tools/simplify-data-3to4/box.expected
testsuite/tools/simplify-data-3to4/checkbutton.expected
testsuite/tools/simplify-data-3to4/grid.expected
testsuite/tools/simplify-data-3to4/gtkfilechooserdialog.expected
testsuite/tools/simplify-data-3to4/office-runner.expected
testsuite/tools/simplify-data-3to4/toolbar.expected
tools/gtk-builder-tool-simplify.c

index 54dde405b9a160a7dcf4b65da3f1f5bbbbc8418c..15b6f34c74ae7f88afd205267ebaef521098c0ef 100644 (file)
@@ -7,15 +7,15 @@
         <child>
           <object class="GtkBox">
             <property name="hexpand">1</property>
-            <property name="orientation">1</property>
+            <property name="orientation">vertical</property>
             <child>
               <object class="GtkBox">
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="hexpand">1</property>
                 <property name="vexpand">0</property>
                 <child>
                   <object class="GtkButton">
-                    <property name="halign">3</property>
+                    <property name="halign">center</property>
                     <property name="label" translatable="1">_</property>
                     <property name="focusable">1</property>
                     <property name="receives_default">1</property>
@@ -30,7 +30,7 @@
                 </child>
                 <child>
                   <object class="GtkButton">
-                    <property name="halign">3</property>
+                    <property name="halign">center</property>
                     <property name="hexpand">1</property>
                     <property name="label" translatable="1">E</property>
                     <property name="focusable">1</property>
             <child>
               <object class="GtkBox">
                 <property name="can_focus">0</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="hexpand">1</property>
                 <property name="vexpand">0</property>
                 <child>
                   <object class="GtkButton">
-                    <property name="halign">3</property>
+                    <property name="halign">center</property>
                     <property name="label" translatable="1">_</property>
                     <property name="focusable">1</property>
                     <property name="receives_default">1</property>
@@ -70,7 +70,7 @@
                 </child>
                 <child>
                   <object class="GtkButton">
-                    <property name="halign">3</property>
+                    <property name="halign">center</property>
                     <property name="hexpand">1</property>
                     <property name="label" translatable="1">E</property>
                     <property name="focusable">1</property>
         </child>
         <child>
           <object class="GtkBox">
-            <property name="halign">3</property>
-            <property name="orientation">1</property>
+            <property name="halign">center</property>
+            <property name="orientation">vertical</property>
             <property name="can_focus">0</property>
             <property name="vexpand">1</property>
             <child>
               <object class="GtkButton">
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="label" translatable="1">_</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
             </child>
             <child>
               <object class="GtkButton">
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
                 <property name="label" translatable="1">E</property>
                 <property name="focusable">1</property>
           <object class="GtkBox">
             <property name="hexpand">0</property>
             <property name="vexpand">1</property>
-            <property name="orientation">1</property>
+            <property name="orientation">vertical</property>
             <child>
               <object class="GtkButton">
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="label" translatable="1">_I</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
             </child>
             <child>
               <object class="GtkButton">
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
                 <property name="label" translatable="1">EI</property>
                 <property name="focusable">1</property>
                 <property name="label" translatable="1">_S</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">FS</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">1</property>
+                <property name="valign">start</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">ES</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">FES</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">1</property>
+                <property name="valign">start</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">_N</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">FN</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">2</property>
+                <property name="valign">end</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">EN</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">FEN</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">2</property>
+                <property name="valign">end</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">_C</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">FC</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">EC</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">FEC</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">_B</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">FB</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">4</property>
+                <property name="valign">baseline</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">EB</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
               </object>
             </child>
             <child>
                 <property name="label" translatable="1">FEB</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">4</property>
+                <property name="valign">baseline</property>
               </object>
             </child>
           </object>
           <object class="GtkBox">
             <property name="hexpand">0</property>
             <property name="vexpand">1</property>
-            <property name="orientation">1</property>
+            <property name="orientation">vertical</property>
             <child>
               <object class="GtkButton">
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="label" translatable="1">_I</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
             </child>
             <child>
               <object class="GtkButton">
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="label" translatable="1">EI</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
                 <property name="label" translatable="1">_S</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">0</property>
               </object>
             </child>
                 <property name="label" translatable="1">FS</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">1</property>
+                <property name="valign">start</property>
                 <property name="vexpand">0</property>
               </object>
             </child>
                 <property name="label" translatable="1">ES</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FES</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">1</property>
+                <property name="valign">start</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">_N</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">0</property>
               </object>
             </child>
                 <property name="label" translatable="1">FN</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">2</property>
+                <property name="valign">end</property>
                 <property name="vexpand">0</property>
               </object>
             </child>
                 <property name="label" translatable="1">EN</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FEN</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">2</property>
+                <property name="valign">end</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">_C</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">0</property>
               </object>
             </child>
                 <property name="label" translatable="1">FC</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">0</property>
               </object>
             </child>
                 <property name="label" translatable="1">EC</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FEC</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">_B</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">0</property>
               </object>
             </child>
                 <property name="label" translatable="1">FB</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">4</property>
+                <property name="valign">baseline</property>
                 <property name="vexpand">0</property>
               </object>
             </child>
                 <property name="label" translatable="1">EB</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FEB</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">4</property>
+                <property name="valign">baseline</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
           <object class="GtkBox">
             <property name="hexpand">0</property>
             <property name="vexpand">1</property>
-            <property name="orientation">1</property>
+            <property name="orientation">vertical</property>
             <child>
               <object class="GtkButton">
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="label" translatable="1">_I</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
             </child>
             <child>
               <object class="GtkButton">
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="label" translatable="1">EI</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
                 <property name="label" translatable="1">_S</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FS</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">1</property>
+                <property name="valign">start</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">ES</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FES</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">1</property>
+                <property name="valign">start</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">_N</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FN</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">2</property>
+                <property name="valign">end</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">EN</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FEN</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">2</property>
+                <property name="valign">end</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">_C</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FC</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">EC</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FEC</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">_B</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FB</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">4</property>
+                <property name="valign">baseline</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">EB</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">3</property>
+                <property name="valign">center</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
                 <property name="label" translatable="1">FEB</property>
                 <property name="focusable">1</property>
                 <property name="receives_default">1</property>
-                <property name="valign">4</property>
+                <property name="valign">baseline</property>
                 <property name="vexpand">1</property>
               </object>
             </child>
index 24ef3bcd370005fcdde3f0471e6b386c6b489a6a..c5f8ed63612b5826863996b4ee208d73b3003961 100644 (file)
@@ -4,7 +4,7 @@
   <object class="GtkWindow" id="window1">
     <property name="child">
       <object class="GtkBox" id="box1">
-        <property name="orientation">1</property>
+        <property name="orientation">vertical</property>
         <child>
           <object class="GtkCheckButton" id="checkbutton1">
             <property name="hexpand">1</property>
index 60f29728468f950c40caa8986a7da6d822604704..2d040d0f19ef7f707b5b0f556db6a2a6a9c19e5f 100644 (file)
           <object class="GtkButton" id="button8">
             <property name="focusable">1</property>
             <property name="receives_default">1</property>
-            <property name="halign">3</property>
-            <property name="valign">3</property>
+            <property name="halign">center</property>
+            <property name="valign">center</property>
             <layout>
               <property name="column">1</property>
               <property name="row">1</property>
           <object class="GtkButton" id="button9">
             <property name="focusable">1</property>
             <property name="receives_default">1</property>
-            <property name="halign">3</property>
-            <property name="valign">3</property>
+            <property name="halign">center</property>
+            <property name="valign">center</property>
             <layout>
               <property name="column">2</property>
               <property name="row">1</property>
index 9275810c547fa0e263bb020ee669fcf408296056..b96ec784d81c9dce48adb0e080fdd5f88b0c3471 100644 (file)
@@ -9,7 +9,7 @@
     <child internal-child="content_area">
       <object class="GtkBox" id="dialog-vbox1">
         <property name="visible">0</property>
-        <property name="orientation">1</property>
+        <property name="orientation">vertical</property>
         <property name="border-width">0</property>
         <child>
           <object class="GtkFileChooserWidget" id="widget">
@@ -31,6 +31,6 @@
     </child>
   </template>
   <object class="GtkSizeGroup" id="buttons">
-    <property name="mode">2</property>
+    <property name="mode">vertical</property>
   </object>
 </interface>
index b166475564a265fcd860d10b27f4406c06f2aac6..fa8453830d01af3a2b1a0bbb7491b5ceff0924af 100644 (file)
@@ -11,7 +11,7 @@
         <property name="margin-start">12</property>
         <property name="margin-end">12</property>
         <property name="margin_bottom">12</property>
-        <property name="orientation">1</property>
+        <property name="orientation">vertical</property>
         <property name="spacing">12</property>
         <child>
           <object class="GtkNotebook" id="notebook1">
@@ -34,7 +34,7 @@
                     </child>
                     <child>
                       <object class="GtkLabel" id="label5">
-                        <property name="valign">1</property>
+                        <property name="valign">start</property>
                         <property name="hexpand">1</property>
                         <property name="xalign">0</property>
                         <property name="label" translatable="1"> • Click the &quot;Run!&quot; button, and then dash to your desk or meeting.
                     </child>
                     <child>
                       <object class="GtkBox" id="box2">
-                        <property name="valign">3</property>
-                        <property name="orientation">1</property>
+                        <property name="valign">center</property>
+                        <property name="orientation">vertical</property>
                         <child>
                           <object class="GtkLabel" id="result_label">
-                            <property name="valign">1</property>
+                            <property name="valign">start</property>
                             <property name="xalign">0</property>
                             <property name="label" translatable="0">Silver Trophy!</property>
                             <property name="use_markup">1</property>
                         </child>
                         <child>
                           <object class="GtkLabel" id="current_time_label">
-                            <property name="valign">1</property>
+                            <property name="valign">start</property>
                             <property name="xalign">0</property>
                             <property name="label" translatable="0">You managed to finish the route with the 2nd best time ever, &lt;b&gt;48.15 seconds!&lt;/b&gt;     </property>
                             <property name="use_markup">1</property>
                         </child>
                         <child>
                           <object class="GtkLabel" id="better_time_label">
-                            <property name="valign">1</property>
+                            <property name="valign">start</property>
                             <property name="xalign">0</property>
                             <property name="label" translatable="0">Only &lt;b&gt;3.75 seconds&lt;/b&gt; separate you from the gold trophy!</property>
                             <property name="use_markup">1</property>
index d1bafefd5cdf072edbf79a35142514276b8e3c4a..6b5db81054179d330fb9a705bd0de6979a70e879 100644 (file)
@@ -12,7 +12,7 @@
     </child>
     <child>
       <object class="GtkSeparator">
-        <property name="orientation">1</property>
+        <property name="orientation">vertical</property>
       </object>
     </child>
     <child>
index 0f13bf7a6d6b1e24b944747d972fcbe2fe58b4be..dfa4eb70974734d2f0f88bc50e2231b1877e6c8e 100644 (file)
@@ -621,7 +621,15 @@ canonical_enum_value (MyParserData *data,
   GValue value = G_VALUE_INIT;
 
   if (gtk_builder_value_from_string_type (data->builder, type, string, &value, NULL))
-    return g_strdup_printf ("%d", g_value_get_enum (&value));
+    {
+      GEnumClass *eclass = g_type_class_ref (type);
+      GEnumValue *evalue = g_enum_get_value (eclass, g_value_get_enum (&value));
+
+      if (evalue)
+        return g_strdup (evalue->value_nick);
+      else
+        return g_strdup_printf ("%d", g_value_get_enum (&value));
+    }
 
   return NULL;
 }