build: Use Meson's gnu_symbol_visibility
authorEmmanuele Bassi <ebassi@gnome.org>
Tue, 9 May 2023 12:13:00 +0000 (13:13 +0100)
committerEmmanuele Bassi <ebassi@gnome.org>
Tue, 9 May 2023 15:43:25 +0000 (16:43 +0100)
Instead of injecting `-fvisibility=hidden` depending on a compiler check
ourselves, let Meson do it for us.

This also avoids us having to filter `-fvisibility=hidden` when reusing
the common compiler flags.

demos/gtk-demo/meson.build
gtk/meson.build
meson.build
testsuite/a11y/meson.build
testsuite/gtk/meson.build
testsuite/reftests/meson.build

index c03beb39409d18db2e93801b7d6c6d5c4eced859..53f56c1ce39dd5ebda14312a322cf6cc560906ef 100644 (file)
@@ -233,8 +233,7 @@ endif
 demo_cflags = []
 foreach flag: common_cflags
   if flag not in ['-Werror=missing-prototypes', '-Wmissing-prototypes',
-                  '-Werror=missing-declarations', '-Wmissing-declarations',
-                  '-fvisibility=hidden']
+                  '-Werror=missing-declarations', '-Wmissing-declarations']
     demo_cflags += flag
   endif
 endforeach
index b3975fb3fcd0a67eb15f0a9e6812b7c8bd44282c..13e931f63aeb064a0b5987db236417764506727f 100644 (file)
@@ -1173,6 +1173,7 @@ libgtk = shared_library('gtk-4',
   soversion: gtk_soversion,
   version: gtk_library_version,
   darwin_versions: darwin_versions,
+  gnu_symbol_visibility: 'hidden',
   install: true,
 )
 
index 0c38fcb1caecd5460076bf60200b73e9363e63c2..5023a70121ca0e3445c8315519385521338250fe 100644 (file)
@@ -344,11 +344,6 @@ common_cflags = cc.get_supported_arguments(test_cflags)
 if get_option('default_library') != 'static'
   if os_win32
     cdata.set('DLL_EXPORT', true)
-    if cc.get_id() != 'msvc'
-      common_cflags += ['-fvisibility=hidden']
-    endif
-  else
-    common_cflags += ['-fvisibility=hidden']
   endif
 endif
 
index c43465efb26b5f33b3308c7888c61367bdebcc40..733f6232176193351f54c9e21353503e6149d116 100644 (file)
@@ -38,8 +38,7 @@ test_cargs = []
 
 foreach flag: common_cflags
   if flag not in ['-Werror=missing-prototypes', '-Wmissing-prototypes',
-                  '-Werror=missing-declarations', '-Wmissing-declarations',
-                  '-fvisibility=hidden']
+                  '-Werror=missing-declarations', '-Wmissing-declarations']
     test_cargs += flag
   endif
 endforeach
index 11560a95f479df15686d7afa12c702bc375b6b42..7a27180854705bec4734dab2980baf1161062948 100644 (file)
@@ -148,8 +148,7 @@ endif
 
 foreach flag: common_cflags
   if flag not in ['-Werror=missing-prototypes', '-Wmissing-prototypes',
-                  '-Werror=missing-declarations', '-Wmissing-declarations',
-                  '-fvisibility=hidden']
+                  '-Werror=missing-declarations', '-Wmissing-declarations']
     test_cargs += flag
   endif
 endforeach
index 1cc8a4302cbe54ec2ec7d905029ea604917f3ae9..793ba19eb76dba40975c82ca111a4e18bafec6e1 100644 (file)
@@ -3,8 +3,7 @@
 reftest_cflags = []
 foreach flag: common_cflags
   if flag not in ['-Werror=missing-prototypes', '-Wmissing-prototypes',
-                  '-Werror=missing-declarations', '-Wmissing-declarations',
-                  '-fvisibility=hidden']
+                  '-Werror=missing-declarations', '-Wmissing-declarations']
     reftest_cflags += flag
   endif
 endforeach