Avoid string translation puzzle
authorNicolas Fella <nicolas.fella@gmx.de>
Fri, 9 Oct 2020 22:26:18 +0000 (00:26 +0200)
committerKevin Ottens (Rebase PR Action) <er-vin@users.noreply.github.com>
Mon, 12 Oct 2020 13:34:50 +0000 (13:34 +0000)
Combining translated strings like this makes them hard to translate since the order of words is different between languages.
Use proper placeholder strings instead.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
src/gui/tray/Window.qml

index a73b3bfad90decaf062578931b2d8b9316badf77..6c33c1c4f3a4884a216844542feef409b1a0fe26 100644 (file)
@@ -488,7 +488,7 @@ Window {
                                 }\r
 \r
                                 Accessible.role: Accessible.MenuItem\r
-                                Accessible.name: qsTr("Open") + " " + appName + " " + qsTr("in browser")\r
+                                Accessible.name: qsTr("Open %1 in browser").arg(appName)\r
                                 Accessible.onPressAction: appEntry.triggered()\r
                             }\r
                         }\r
@@ -524,7 +524,7 @@ Window {
                 spacing: 0\r
 \r
                 Accessible.role: Accessible.ListItem\r
-                Accessible.name: path !== "" ? qsTr("Open") + " " + displayPath + " " + qsTr("locally")\r
+                Accessible.name: path !== "" ? qsTr("Open %1 locally").arg(displayPath)\r
                                                     : message\r
                 Accessible.onPressAction: activityMouseArea.clicked()\r
 \r
@@ -640,7 +640,7 @@ Window {
                     onClicked: Systray.openShareDialog(displayPath,absolutePath)\r
 \r
                     Accessible.role: Accessible.Button\r
-                    Accessible.name: qsTr("Share") + " " + displayPath\r
+                    Accessible.name: qsTr("Share %1").arg(displayPath)\r
                     Accessible.onPressAction: shareButton.clicked()\r
                 }\r
 \r
@@ -666,7 +666,7 @@ Window {
                     onClicked: Qt.openUrlExternally(link)\r
 \r
                     Accessible.role: Accessible.Button\r
-                    Accessible.name: qsTr("Open Talk") + " " + link\r
+                    Accessible.name: qsTr("Open Talk %1").arg(link)\r
                     Accessible.onPressAction: replyButton.clicked()\r
                 }\r
             }\r