net: Fix OOB write in grub_net_search_config_file()

The function included a call to grub_strcpy() which copied data from an
environment variable to a buffer allocated in grub_cmd_normal(). The
grub_cmd_normal() didn't consider the length of the environment variable.
So, the copy operation could exceed the allocation and lead to an OOB
write. Fix the issue by replacing grub_strcpy() with grub_strlcpy() and
pass the underlying buffers size to the grub_net_search_config_file().

Fixes: CVE-2025-0624
Reported-by: B Horn <b@horn.uk>
Signed-off-by: B Horn <b@horn.uk>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Conflicts:
	grub-core/normal/main.c

Gbp-Pq: Topic cve-2025-jan
Gbp-Pq: Name net-Fix-OOB-write-in-grub_net_search_config_file.patch

diff --git a/grub-core/net/net.c b/grub-core/net/net.c
index 8ff99ffb90c5d300ace7e8f258e693f690941d70..bdf24459e337f9c20025e67295098208e1bec524 100644 (file)
--- a/grub-core/net/net.c
+++ b/grub-core/net/net.c
@@ -2017,14 +2017,15 @@ grub_config_search_through (char *config, char *suffix,
 }
 
 grub_err_t
-grub_net_search_config_file (char *config)
+grub_net_search_config_file (char *config, grub_size_t config_buf_len)
 {
-  grub_size_t config_len;
+  grub_size_t config_len, suffix_len;
   char *suffix;
 
   config_len = grub_strlen (config);
   config[config_len] = '-';
   suffix = config + config_len + 1;
+  suffix_len = config_buf_len - (config_len + 1);
 
   struct grub_net_network_level_interface *inf;
   FOR_NET_NETWORK_LEVEL_INTERFACES (inf)
@@ -2050,7 +2051,7 @@ grub_net_search_config_file (char *config)
 
       if (client_uuid)
         {
-          grub_strcpy (suffix, client_uuid);
+          grub_strlcpy (suffix, client_uuid, suffix_len);
           if (grub_config_search_through (config, suffix, 1, 0) == 0)
             return GRUB_ERR_NONE;
         }

diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c
index 74ed468c7418ef56b1f5610100281f152b396130..33a238c533c67fd5e61d92632eabf4c8aa0bfbcb 100644 (file)
--- a/grub-core/normal/main.c
+++ b/grub-core/normal/main.c
@@ -334,7 +334,7 @@ grub_try_normal_prefix (const char *prefix)
          return err;
 
        grub_snprintf (config, config_len, "%s/grub.cfg", prefix);
-       err = grub_net_search_config_file (config);
+       err = grub_net_search_config_file (config, config_len);
       }
 
     if (err != GRUB_ERR_NONE)

diff --git a/include/grub/net.h b/include/grub/net.h
index 3e6a43df8f530fd63e2843d296e836cb9b8538c7..33f0ce6de6d3784126d0bc9ee0b883e1f3f3498b 100644 (file)
--- a/include/grub/net.h
+++ b/include/grub/net.h
@@ -650,7 +650,7 @@ void
 grub_net_remove_dns_server (const struct grub_net_network_level_address *s);
 
 grub_err_t
-grub_net_search_config_file (char *config);
+grub_net_search_config_file (char *config, grub_size_t config_buf_len);
 
 extern char *grub_net_default_server;