entrycompletion: no need to return boolean
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Fri, 3 Jul 2015 18:48:48 +0000 (15:48 -0300)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Fri, 3 Jul 2015 18:51:06 +0000 (15:51 -0300)
The boolean _gtk_entry_completion_resize_popup's return
value is not used anywhere, and only adds more complexity
for the method.

https://bugzilla.gnome.org/show_bug.cgi?id=751913

gtk/gtkentrycompletion.c
gtk/gtkentryprivate.h

index 6a8cbf43772afbd39efd67e51ed57c2aa5724c58..fb6e5588173381ba2f8e2867dbc8a43dee9e1cd1 100644 (file)
@@ -1486,7 +1486,7 @@ gtk_entry_completion_list_motion_notify (GtkWidget      *widget,
 
 
 /* some nasty size requisition */
-gboolean
+void
 _gtk_entry_completion_resize_popup (GtkEntryCompletion *completion)
 {
   GtkAllocation allocation;
@@ -1509,10 +1509,10 @@ _gtk_entry_completion_resize_popup (GtkEntryCompletion *completion)
   window = gtk_widget_get_window (completion->priv->entry);
 
   if (!window)
-    return FALSE;
+    return;
 
   if (!completion->priv->filter_model)
-    return FALSE;
+    return;
 
   gtk_widget_get_allocation (completion->priv->entry, &allocation);
   gtk_widget_get_preferred_size (completion->priv->entry,
@@ -1604,8 +1604,6 @@ _gtk_entry_completion_resize_popup (GtkEntryCompletion *completion)
     }
 
   gtk_window_move (GTK_WINDOW (completion->priv->popup_window), x, y);
-
-  return above;
 }
 
 static void
index 7e84d06c7c3cea68b908ce11c73983c1af030dcf..6d85d8773929e6cbfe477750b5f430e371717390 100644 (file)
@@ -74,7 +74,7 @@ struct _GtkEntryCompletionPrivate
   GdkDevice *device;
 };
 
-gboolean _gtk_entry_completion_resize_popup (GtkEntryCompletion *completion);
+void     _gtk_entry_completion_resize_popup (GtkEntryCompletion *completion);
 void     _gtk_entry_completion_popdown      (GtkEntryCompletion *completion);
 void     _gtk_entry_completion_connect      (GtkEntryCompletion *completion,
                                              GtkEntry           *entry);