Fix possible overflow on lineWritten
authorClaudio Cambra <claudio.cambra@gmail.com>
Wed, 18 May 2022 14:08:12 +0000 (16:08 +0200)
committerClaudio Cambra <claudio.cambra@gmail.com>
Thu, 19 May 2022 10:40:59 +0000 (12:40 +0200)
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
shell_integration/MacOSX/OwnCloudFinderSync/FinderSyncExt/LocalSocketClient.m

index fb3c376383c7124fc382fc880ef4a8ffdac4e13c..37c39cc7b24c851875b6260ff21427b07e481b63 100644 (file)
     NSLog(@"About to write %li bytes from outbuffer to socket.", [self.outBuffer length]);
     
     long bytesWritten = write(self.sock, [self.outBuffer bytes], [self.outBuffer length]);
-    char lineWritten[4096];
+    char lineWritten[[self.outBuffer length]];
     memcpy(lineWritten, [self.outBuffer bytes], [self.outBuffer length]);
-    NSLog(@"Wrote %li bytes to socket. Line was: '%@'", bytesWritten, [NSString stringWithUTF8String:lineWritten]);
+    NSLog(@"Wrote %li bytes to socket. Line written was: '%@'", bytesWritten, [NSString stringWithUTF8String:lineWritten]);
     
     if(bytesWritten == 0) {
         // 0 means we reached "end of file" and thus the socket was closed\10. So let's restart it