winvfs: Better error reporting
authorChristian Kamm <mail@ckamm.de>
Fri, 9 Nov 2018 11:17:24 +0000 (12:17 +0100)
committerKevin Ottens <kevin.ottens@nextcloud.com>
Tue, 15 Dec 2020 09:58:22 +0000 (10:58 +0100)
- fix download and validation error reporting
- add tests

src/libsync/propagatedownload.cpp
src/libsync/propagatedownload.h

index 1573f5e699da59c6faba922788561d974e4e3fcd..a5d87effae23c39a95357af90306d2e5bfd6aad1 100644 (file)
@@ -77,7 +77,7 @@ GETFileJob::GETFileJob(AccountPtr account, const QString &path, QIODevice *devic
     , _headers(headers)
     , _expectedEtagForResume(expectedEtagForResume)
     , _expectedContentLength(-1)
-    , _contentLength(0)
+    , _contentLength(-1)
     , _resumeStart(resumeStart)
     , _errorStatus(SyncFileItem::NoStatus)
     , _bandwidthLimited(false)
@@ -98,7 +98,7 @@ GETFileJob::GETFileJob(AccountPtr account, const QUrl &url, QIODevice *device,
     , _headers(headers)
     , _expectedEtagForResume(expectedEtagForResume)
     , _expectedContentLength(-1)
-    , _contentLength(0)
+    , _contentLength(-1)
     , _resumeStart(resumeStart)
     , _errorStatus(SyncFileItem::NoStatus)
     , _directDownloadUrl(url)
index cd76a2a6a6cf2a3574005fd2c13d4c8c160df2d0..226a8b5210cb75fdbbd325bc404e7b28f220e2e3 100644 (file)
@@ -35,7 +35,7 @@ class GETFileJob : public AbstractNetworkJob
     QString _errorString;
     QByteArray _expectedEtagForResume;
     qint64 _expectedContentLength;
-    quint64 _contentLength;
+    qint64 _contentLength;
     quint64 _resumeStart;
     SyncFileItem::Status _errorStatus;
     QUrl _directDownloadUrl;
@@ -103,7 +103,7 @@ public:
     quint64 resumeStart() { return _resumeStart; }
     time_t lastModified() { return _lastModified; }
 
-    quint64 contentLength() const { return _contentLength; }
+    qint64 contentLength() const { return _contentLength; }
     qint64 expectedContentLength() const { return _expectedContentLength; }
     void setExpectedContentLength(qint64 size) { _expectedContentLength = size; }