compositor: Avoid a crash if the top window actor is finalized

Since we're not holding a reference, the top window actor might be
finalized when we paint resulting in a use after free crash.

https://bugzilla.gnome.org/show_bug.cgi?id=788493

Gbp-Pq: Name 0017-compositor-Avoid-a-crash-if-top-window-finalized.patch

diff --git a/src/compositor/compositor.c b/src/compositor/compositor.c
index a75ac12c5612d9e0afda1676c815108d8b88ba15..1d5b9ab20018fc4042457bca3d31199fbfbb43de 100644 (file)
--- a/src/compositor/compositor.c
+++ b/src/compositor/compositor.c
@@ -671,6 +671,9 @@ meta_compositor_remove_window (MetaCompositor *compositor,
   if (compositor->unredirected_window == window)
     set_unredirected_window (compositor, NULL);
 
+  if (compositor->top_window_actor == window_actor)
+    compositor->top_window_actor = NULL;
+
   meta_window_actor_destroy (window_actor);
 }