force talloc to be standalone
authorMichael Tokarev <mjt@tls.msk.ru>
Tue, 26 Nov 2024 14:28:51 +0000 (17:28 +0300)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 21 Aug 2025 17:37:38 +0000 (20:37 +0300)
Forwarded: not-needed

Upstream ships contents of lib/talloc/ as a separate
source of talloc.  Since we build samba anyway, there's
no need to have separate talloc source package, it's
enough to build it during samba build.

Always build talloc as stand-alone library
(instead of being samba-private if in a subdir).

When building as a sub-library within samba, where
libreplace is a private library, libtalloc.so will
have rpath pointing to the private samba dir.  Since
talloc actually does not use anything from libreplace,
just remove the dependency.

Gbp-Pq: Name talloc-standalone.diff

lib/talloc/wscript

index b4b89ec19933fe7fb315f776a9880656db13f572..72a86b019d05ae8e6e12cbc241f0096f0591878b 100644 (file)
@@ -27,7 +27,7 @@ def options(opt):
     opt.BUILTIN_DEFAULT('replace')
     opt.PRIVATE_EXTENSION_DEFAULT('talloc', noextension='talloc')
     opt.RECURSE('lib/replace')
-    if opt.IN_LAUNCH_DIR():
+    if opt.IN_LAUNCH_DIR() or True:
         opt.add_option('--enable-talloc-compat1',
                        help=("Build talloc 1.x.x compat library [False]"),
                        action="store_true", dest='TALLOC_COMPAT1', default=False)
@@ -36,7 +36,7 @@ def options(opt):
 def configure(conf):
     conf.RECURSE('lib/replace')
 
-    conf.env.standalone_talloc = conf.IN_LAUNCH_DIR()
+    conf.env.standalone_talloc = conf.IN_LAUNCH_DIR() or True
 
     conf.define('TALLOC_BUILD_VERSION_MAJOR', int(VERSION.split('.')[0]))
     conf.define('TALLOC_BUILD_VERSION_MINOR', int(VERSION.split('.')[1]))
@@ -113,7 +113,7 @@ def build(bld):
 
         bld.SAMBA_LIBRARY('talloc',
                           'talloc.c',
-                          deps='replace',
+                          deps='', # 'replace',
                           provide_builtin_linking=True,
                           abi_directory='ABI',
                           abi_match='talloc* _talloc*',