Replace use of magic numbers for animation durations in copy share link button with...
authorClaudio Cambra <claudio.cambra@nextcloud.com>
Wed, 10 May 2023 04:38:27 +0000 (12:38 +0800)
committerClaudio Cambra <claudio.cambra@nextcloud.com>
Tue, 16 May 2023 13:16:11 +0000 (21:16 +0800)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
src/gui/filedetails/ShareDetailsPage.qml
theme/Style/Style.qml

index 6f6ba36b92941cf6a351d836c56058beea89bb4e..17bd184bccf7e78476f072ed34d547ee53c57aa9 100644 (file)
@@ -881,11 +881,11 @@ Page {
             onClicked: copyShareLink()
 
             Behavior on bgColor {
-                ColorAnimation { duration: 200 }
+                ColorAnimation { duration: Style.shortAnimationDuration }
             }
 
             Behavior on bgHoverOpacity {
-                NumberAnimation { duration: 200 }
+                NumberAnimation { duration: Style.shortAnimationDuration }
             }
 
             TextEdit {
@@ -895,7 +895,7 @@ Page {
 
             Timer {
                 id: shareLinkCopyTimer
-                interval: 3000
+                interval: Style.veryLongAnimationDuration
                 onTriggered: copyShareLinkButton.shareLinkCopied = false
             }
         }
index ba90ed2fcd6a565c69cbefe64a9827ae39f2c1bb..21bfeb460e8837b68f4792412f0486ccd54c0d6f 100644 (file)
@@ -147,6 +147,10 @@ QtObject {
 \r
     readonly property int trayWindowMenuEntriesMargin: 6\r
 \r
+    // animation durations\r
+    readonly property int shortAnimationDuration: 200\r
+    readonly property int veryLongAnimationDuration: 3000\r
+\r
     function variableSize(size) {\r
         return size * (1 + Math.min(pixelSize / 100, 1));\r
     }\r