lib/commit: fix checking flag with bitwise OR
authorJonathan Lebon <jlebon@redhat.com>
Wed, 18 Oct 2017 13:33:58 +0000 (13:33 +0000)
committerAtomic Bot <atomic-devel@projectatomic.io>
Wed, 18 Oct 2017 14:27:20 +0000 (14:27 +0000)
Caught by Coverity.

Coverity CID: 1458339

Closes: #1290
Approved by: cgwalters

src/libostree/ostree-repo-commit.c

index eb5f92a41d4a42152ae247be8132d105d332ef41..b6fbd3d149f82f7d67990bfb03e53ea3f897e8ba 100644 (file)
@@ -2835,7 +2835,7 @@ write_directory_content_to_mtree_internal (OstreeRepo                  *self,
         file_type == G_FILE_TYPE_REGULAR
         && dfd_iter != NULL
         && delete_after_commit
-        && (writeflags | WRITE_DIR_CONTENT_FLAGS_CAN_ADOPT) > 0;
+        && ((writeflags & WRITE_DIR_CONTENT_FLAGS_CAN_ADOPT) > 0);
       gboolean can_adopt = can_adopt_basic;
       /* If basic prerquisites are met, check repo mode specific ones */
       if (can_adopt)