Fix test failures when xlsxwriter is not installed
authorDebian Science Team <debian-science-maintainers@lists.alioth.debian.org>
Tue, 28 Jan 2025 22:18:06 +0000 (22:18 +0000)
committerRebecca N. Palmer <rebecca_palmer@zoho.com>
Tue, 28 Jan 2025 22:18:06 +0000 (22:18 +0000)
Author: Rebecca N. Palmer <rebecca_palmer@zoho.com>
Forwarded: no

Gbp-Pq: Name 2p1_openpyxl_errors.patch

pandas/tests/io/excel/test_openpyxl.py
pandas/tests/io/excel/test_writers.py

index e53b5830ec6a4b315165f4896aed27bdaadfbda6..99c19638eaece3f971b97499729253587b258a13 100644 (file)
@@ -124,13 +124,14 @@ def test_engine_kwargs_append_invalid(ext):
                 DataFrame(["good"]).to_excel(writer, sheet_name="Sheet2")
 
 
+@td.skip_if_no("xlsxwriter")
 @pytest.mark.parametrize("data_only, expected", [(True, 0), (False, "=1+1")])
 def test_engine_kwargs_append_data_only(ext, data_only, expected):
     # GH 43445
     # tests whether the data_only engine_kwarg actually works well for
     # openpyxl's load_workbook
     with tm.ensure_clean(ext) as f:
-        DataFrame(["=1+1"]).to_excel(f)
+        DataFrame(["=1+1"]).to_excel(f, engine="xlsxwriter") # with openpyxl here, data_only=True gives None/np.nan not 0
         with ExcelWriter(
             f, engine="openpyxl", mode="a", engine_kwargs={"data_only": data_only}
         ) as writer:
index 292eab2d881526e6816d85f1fcd38aaa35255243..0948804586a061d06e086360f09a2934332bf18f 100644 (file)
@@ -1420,6 +1420,8 @@ class TestExcelWriterEngineTests:
                     assert isinstance(writer, _XlsxWriter)
                 else:
                     assert isinstance(writer, klass)
+                    # openpyxl raises on closing if no sheets are written
+                    DataFrame().to_excel(writer, sheet_name="Sheet1")
 
     def test_ExcelWriter_dispatch_raises(self):
         with pytest.raises(ValueError, match="No engine"):