projects
/
nextcloud-desktop.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f1ffc16
)
CloudProviders: Don't clear the _recentMenu pointer
author
Tim Klocke
<taaem@mailbox.org>
Fri, 10 Apr 2020 17:03:15 +0000
(19:03 +0200)
committer
Tim Klocke
<taaem@mailbox.org>
Fri, 10 Apr 2020 21:08:07 +0000
(23:08 +0200)
The _recentMenu pointer ref should not be freed, when building the
menu.
This fixes #1920 and #1818
src/gui/cloudproviders/cloudproviderwrapper.cpp
patch
|
blob
|
history
diff --git
a/src/gui/cloudproviders/cloudproviderwrapper.cpp
b/src/gui/cloudproviders/cloudproviderwrapper.cpp
index f4e2a7606543d049ee111a3a63faeb702020da96..421ae625a5eb69bd812592db85428257c26f2a0e 100644
(file)
--- a/
src/gui/cloudproviders/cloudproviderwrapper.cpp
+++ b/
src/gui/cloudproviders/cloudproviderwrapper.cpp
@@
-69,6
+69,7
@@
CloudProviderWrapper::~CloudProviderWrapper()
g_object_unref(_cloudProviderAccount);
g_object_unref(_mainMenu);
g_object_unref(actionGroup);
+ g_object_unref(_recentMenu);
}
CloudProvidersAccountExporter* CloudProviderWrapper::accountExporter()
@@
-258,7
+259,6
@@
GMenuModel* CloudProviderWrapper::getMenuModel() {
g_menu_append_section(_mainMenu, nullptr, G_MENU_MODEL(section));
g_clear_object (§ion);
- g_clear_object (&_recentMenu);
return G_MENU_MODEL(_mainMenu);
}