proc_reauth

===================================================================

Gbp-Pq: Topic hurd-i386
Gbp-Pq: Name proc_reauth.diff

diff --git a/hurd/hurdsig.c b/hurd/hurdsig.c
index 8b1928d1a185e52fcc4f6dbb34806f9617c8796a..c431d983da4dd6ad999814a6a2cb980c0c8a7bd6 100644 (file)
--- a/hurd/hurdsig.c
+++ b/hurd/hurdsig.c
@@ -1611,28 +1611,53 @@ _hurdsig_init (const int *intarray, size_t intarraysize)
 static void
 reauth_proc (mach_port_t new)
 {
-  mach_port_t ref, ignore;
+  error_t err;
+  mach_port_t ref, newproc;
 
   ref = __mach_reply_port ();
-  if (! HURD_PORT_USE (&_hurd_ports[INIT_PORT_PROC],
+  err = HURD_PORT_USE (&_hurd_ports[INIT_PORT_PROC],
                       __proc_reauthenticate (port, ref,
-                                             MACH_MSG_TYPE_MAKE_SEND)
-                      || __auth_user_authenticate (new, ref,
-                                                   MACH_MSG_TYPE_MAKE_SEND,
-                                                   &ignore))
-      && ignore != MACH_PORT_NULL)
-    __mach_port_deallocate (__mach_task_self (), ignore);
+                                             MACH_MSG_TYPE_MAKE_SEND));
+  if (err)
+    {
+      __mach_port_destroy (__mach_task_self (), ref);
+      return;
+    }
+
+  err = __auth_user_authenticate (new, ref,
+                                  MACH_MSG_TYPE_MAKE_SEND,
+                                  &newproc);
   __mach_port_destroy (__mach_task_self (), ref);
+  if (err)
+    return;
+
+  if (newproc == MACH_PORT_NULL)
+    {
+      /* Old versions of the proc server did not recreate the process
+         port when reauthenticating, and passed MACH_PORT_NULL through
+         the auth server.  That must be what we're dealing with.  */
+
+      /* Set the owner of the process here too. */
+      __mutex_lock (&_hurd_id.lock);
+      if (!_hurd_check_ids ())
+       HURD_PORT_USE (&_hurd_ports[INIT_PORT_PROC],
+                      __proc_setowner (port,
+                                       (_hurd_id.gen.nuids
+                                        ? _hurd_id.gen.uids[0] : 0),
+                                       !_hurd_id.gen.nuids));
+      __mutex_unlock (&_hurd_id.lock);
+
+      return;
+    }
+
+  err = __proc_reauthenticate_complete (newproc);
+  if (err)
+    {
+      __mach_port_deallocate (__mach_task_self (), newproc);
+      return;
+    }
 
-  /* Set the owner of the process here too. */
-  __mutex_lock (&_hurd_id.lock);
-  if (!_hurd_check_ids ())
-    HURD_PORT_USE (&_hurd_ports[INIT_PORT_PROC],
-                  __proc_setowner (port,
-                                   (_hurd_id.gen.nuids
-                                    ? _hurd_id.gen.uids[0] : 0),
-                                   !_hurd_id.gen.nuids));
-  __mutex_unlock (&_hurd_id.lock);
+  _hurd_port_set (&_hurd_ports[INIT_PORT_PROC], newproc);
 
   (void) &reauth_proc;         /* Silence compiler warning.  */
 }

diff --git a/sysdeps/mach/hurd/spawni.c b/sysdeps/mach/hurd/spawni.c
index b23663dee5a900e063b71bfa8e5515cad76ee06a..739f905c68692066961354a4f616c623c13e39cf 100644 (file)
--- a/sysdeps/mach/hurd/spawni.c
+++ b/sysdeps/mach/hurd/spawni.c
@@ -679,11 +679,29 @@ retry:
                                        ref, MACH_MSG_TYPE_MAKE_SEND,
                                        &newproc);
       __mach_port_destroy (__mach_task_self (), ref);
-      if (!err)
-       {
-         __mach_port_deallocate (__mach_task_self (), proc);
-         proc = newproc;
-       }
+      if (err)
+        goto out;
+      if (newproc == MACH_PORT_NULL)
+        {
+          /* Old versions of the proc server did not recreate the process
+             port when reauthenticating, and passed MACH_PORT_NULL through
+             the auth server.  That must be what we're dealing with.  Just
+             keep the existing proc port in this case.  */
+        }
+      else
+        {
+          err = __proc_reauthenticate_complete (newproc);
+          if (err)
+            {
+              __mach_port_deallocate (__mach_task_self (), newproc);
+              goto out;
+            }
+          else
+           {
+             __mach_port_deallocate (__mach_task_self (), proc);
+             proc = newproc;
+           }
+        }
 
       if (!err)
        err = reauthenticate (INIT_PORT_CRDIR, &rcrdir);