widget: Make grab_focus() fail on insensitive widgets
authorBenjamin Otte <otte@redhat.com>
Tue, 15 Oct 2019 14:07:24 +0000 (16:07 +0200)
committerBenjamin Otte <otte@redhat.com>
Tue, 15 Oct 2019 14:33:05 +0000 (16:33 +0200)
We can return FALSE early now instead of silently failing in
gtk_window_set_focus().

gtk/gtkwidget.c

index 5201785480883002840078ce854c89e808c0c3b7..592754c2679708aee4f73b02ce76a52d723da4fd 100644 (file)
@@ -5425,6 +5425,9 @@ gtk_widget_grab_focus (GtkWidget *widget)
 {
   g_return_val_if_fail (GTK_IS_WIDGET (widget), FALSE);
 
+  if (!gtk_widget_is_sensitive (widget))
+    return FALSE;
+
   return GTK_WIDGET_GET_CLASS (widget)->grab_focus (widget);
 }