Revert "Specify PUBLIC for the link targets to make them visible to windeployqt"
authorKevin Ottens <kevin.ottens@nextcloud.com>
Wed, 27 Jan 2021 18:06:13 +0000 (19:06 +0100)
committerKevin Ottens <kevin.ottens@nextcloud.com>
Wed, 27 Jan 2021 18:06:23 +0000 (19:06 +0100)
This reverts commit 002abdc38b31d98211eb329046319430768d0037.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
src/libsync/CMakeLists.txt

index 3245e2e622d5626333443f6c06591eea8f17328e..c63201dcc7af043300254593759f5c89a7cde780 100644 (file)
@@ -119,29 +119,24 @@ ENDIF(NOT APPLE)
 
 find_package(Qt5 REQUIRED COMPONENTS WebSockets)
 add_library(${synclib_NAME} SHARED ${libsync_SRCS})
-target_link_libraries(${synclib_NAME} PUBLIC
+target_link_libraries(${synclib_NAME}
     "${csync_NAME}"
     OpenSSL::Crypto
     OpenSSL::SSL
-    Qt5::Core
-    Qt5::Network
-    Qt5::WebSockets
     ${OS_SPECIFIC_LINK_LIBRARIES}
+    Qt5::Core Qt5::Network
+    Qt5::WebSockets
 )
 
 if (NOT TOKEN_AUTH_ONLY)
     find_package(Qt5 REQUIRED COMPONENTS Widgets Svg)
-    target_link_libraries(${synclib_NAME} PUBLIC
-        Qt5::Widgets
-        Qt5::Svg
-        qt5keychain
-    )
+    target_link_libraries(${synclib_NAME} Qt5::Widgets Qt5::Svg qt5keychain)
 endif()
 
 if(INOTIFY_FOUND)
     target_include_directories(${synclib_NAME} PRIVATE ${INOTIFY_INCLUDE_DIR})
     link_directories(${INOTIFY_LIBRARY_DIR})
-    target_link_libraries(${synclib_NAME} PUBLIC ${INOTIFY_LIBRARY})
+    target_link_libraries(${synclib_NAME} ${INOTIFY_LIBRARY} )
 endif()
 
 GENERATE_EXPORT_HEADER( ${synclib_NAME}