Display correct conflict part in multiple conflicts resolution dialog.
authoralex-z <blackslayer4@gmail.com>
Mon, 11 Sep 2023 14:19:42 +0000 (16:19 +0200)
committerbackportbot-nextcloud[bot] <backportbot-nextcloud[bot]@users.noreply.github.com>
Tue, 12 Sep 2023 08:47:03 +0000 (08:47 +0000)
Signed-off-by: alex-z <blackslayer4@gmail.com>
src/gui/ConflictDelegate.qml
src/gui/ResolveConflictsDialog.qml
src/gui/syncconflictsmodel.cpp

index ff6b48eb00e71ca4bf887610cc13ac24ec68162d..915173507233a040b027edd93dac383bbe9f2643 100644 (file)
@@ -57,14 +57,14 @@ Item {
             Layout.fillWidth: true
             Layout.fillHeight: true
 
-            itemSelected: root.existingSelected
-            itemPreviewUrl: root.existingPreviewUrl
+            itemSelected: root.conflictSelected
+            itemPreviewUrl: root.conflictPreviewUrl
             itemVersionLabel: qsTr('Local version')
-            itemDateLabel: root.existingDate
-            itemFileSizeLabel: root.existingSize
+            itemDateLabel: root.conflictDate
+            itemFileSizeLabel: root.conflictSize
 
             onSelectedChanged: function() {
-                model.existingSelected = itemSelected
+                model.conflictSelected = itemSelected
             }
         }
 
@@ -72,14 +72,14 @@ Item {
             Layout.fillWidth: true
             Layout.fillHeight: true
 
-            itemSelected: root.conflictSelected
-            itemPreviewUrl: root.conflictPreviewUrl
+            itemSelected: root.existingSelected
+            itemPreviewUrl: root.existingPreviewUrl
             itemVersionLabel: qsTr('Server version')
-            itemDateLabel: root.conflictDate
-            itemFileSizeLabel: root.conflictSize
+            itemDateLabel: root.existingDate
+            itemFileSizeLabel: root.existingSize
 
             onSelectedChanged: function() {
-                model.conflictSelected = itemSelected
+                model.existingSelected = itemSelected
             }
         }
     }
index 799a11034d663710a89c241151fd3a570ff5f75c..823c4d0b25db8633168884352bfc0f11283fbbf1 100644 (file)
@@ -101,9 +101,9 @@ ApplicationWindow {
 
                 font.pixelSize: Style.fontPixelSizeResolveConflictsDialog
 
-                checked: realModel.allExistingsSelected
+                checked: realModel.allConflictingSelected
                 onToggled: function() {
-                    realModel.selectAllExisting(checked)
+                    realModel.selectAllConflicting(checked)
                 }
             }
 
@@ -119,9 +119,9 @@ ApplicationWindow {
 
                 font.pixelSize: Style.fontPixelSizeResolveConflictsDialog
 
-                checked: realModel.allConflictingSelected
+                checked: realModel.allExistingsSelected
                 onToggled: function() {
-                    realModel.selectAllConflicting(checked)
+                    realModel.selectAllExisting(checked)
                 }
             }
         }
index 3d455d87292692d2ac81cce90f29f746930b1d50..2ddbf0225786dcd43fffa97c032bef4fd45fa44c 100644 (file)
@@ -327,9 +327,9 @@ ConflictSolver::Solution SyncConflictsModel::ConflictInfo::solution() const
     if (mConflictSelected == ConflictSolution::SolutionSelected && mExistingSelected == ConflictSolution::SolutionSelected) {
         result = ConflictSolver::KeepBothVersions;
     } else if (mConflictSelected == ConflictSolution::SolutionDeselected && mExistingSelected == ConflictSolution::SolutionSelected) {
-        result = ConflictSolver::KeepLocalVersion;
-    } else if (mConflictSelected == ConflictSolution::SolutionSelected && mExistingSelected == ConflictSolution::SolutionDeselected) {
         result = ConflictSolver::KeepRemoteVersion;
+    } else if (mConflictSelected == ConflictSolution::SolutionSelected && mExistingSelected == ConflictSolution::SolutionDeselected) {
+        result = ConflictSolver::KeepLocalVersion;
     }
 
     return result;