Modernise FolderWatcher::changeDetected

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

diff --git a/src/gui/folderwatcher.cpp b/src/gui/folderwatcher.cpp
index 44b56d391ca5b4ba22e0a027e873c63b2cb17367..868d85370c974c15730200077f797f10adbb4265 100644 (file)
--- a/src/gui/folderwatcher.cpp
+++ b/src/gui/folderwatcher.cpp
@@ -160,7 +160,7 @@ void FolderWatcher::changeDetected(const QStringList &paths)
     //   - why do we skip the file altogether instead of e.g. reducing the upload frequency?
 
     // Check if the same path was reported within the last second.
-    QSet<QString> pathsSet = paths.toSet();
+    const auto pathsSet = paths.toSet();
     if (pathsSet == _lastPaths && _timer.elapsed() < 1000) {
         // the same path was reported within the last second. Skip.
         return;
@@ -172,8 +172,7 @@ void FolderWatcher::changeDetected(const QStringList &paths)
     QSet<QString> unlockedFiles;
     QSet<QString> lockedFiles;
 
-    for (int i = 0; i < paths.size(); ++i) {
-        QString path = paths[i];
+    for (const auto &path : paths) {
         if (!_testNotificationPath.isEmpty()
             && Utility::fileNamesEqual(path, _testNotificationPath)) {
             _testNotificationPath.clear();
@@ -194,7 +193,7 @@ void FolderWatcher::changeDetected(const QStringList &paths)
 
         qCDebug(lcFolderWatcher) << "Locked files:" << lockedFiles.values();
 
-    // ------- handle ignores:
+        // ------- handle ignores:
         if (pathIsIgnored(path)) {
             continue;
         }
@@ -215,7 +214,7 @@ void FolderWatcher::changeDetected(const QStringList &paths)
     }
 
     qCInfo(lcFolderWatcher) << "Detected changes in paths:" << changedPaths;
-    foreach (const QString &path, changedPaths) {
+    for (const auto &path : changedPaths) {
         emit pathChanged(path);
     }
 }