x86/EPT: consider page order when checking for APIC MFN
authorJan Beulich <jbeulich@suse.com>
Fri, 2 May 2014 08:48:48 +0000 (10:48 +0200)
committerJan Beulich <jbeulich@suse.com>
Fri, 2 May 2014 08:48:48 +0000 (10:48 +0200)
This was overlooked in 3d90d6e6 ("x86/EPT: split super pages upon
mismatching memory types").

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Tim Deegan <tim@xen.org>
xen/arch/x86/hvm/mtrr.c

index d494fedbd582519bfa8201c913b54fb7d86e3aa9..894de5f54c4e38d39c781546bf888a23cc51b711 100644 (file)
@@ -816,15 +816,18 @@ int epte_get_entry_emt(struct domain *d, unsigned long gfn, mfn_t mfn,
           !has_arch_pdevs(d)) )
     {
         ASSERT(!direct_mmio ||
-               mfn_x(mfn) == d->arch.hvm_domain.vmx.apic_access_mfn);
+               !((mfn_x(mfn) ^ d->arch.hvm_domain.vmx.apic_access_mfn) >>
+                 order));
         *ipat = 1;
         return MTRR_TYPE_WRBACK;
     }
 
     if ( direct_mmio )
     {
-        if ( mfn_x(mfn) != d->arch.hvm_domain.vmx.apic_access_mfn )
+        if ( (mfn_x(mfn) ^ d->arch.hvm_domain.vmx.apic_access_mfn) >> order )
             return MTRR_TYPE_UNCACHABLE;
+        if ( order )
+            return -1;
         *ipat = 1;
         return MTRR_TYPE_WRBACK;
     }