filechooserwidget: Rename callback
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Sat, 22 Oct 2022 15:49:31 +0000 (12:49 -0300)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Tue, 13 Dec 2022 17:45:15 +0000 (14:45 -0300)
It's shared between both column and grid views now.

gtk/gtkfilechooserwidget.c
gtk/ui/gtkfilechooserwidget.ui

index 85f5494e33584f9271394a69fda77ed77c01cc5b..0ed294309f04dce108cd8fea1f315ea3bc69e82f 100644 (file)
@@ -6151,11 +6151,13 @@ browse_files_view_keynav_failed_cb (GtkWidget        *widget,
   return FALSE;
 }
 
-/* Callback used when a row in the file list is activated */
+/* Callback used when a row in the file list is activated. 'view' may
+ * be either a GtkColumnView, or a GtkGridView.
+ */
 static void
-column_view_row_activated_cb (GtkColumnView        *column_view,
-                              guint                 position,
-                              GtkFileChooserWidget *self)
+browse_files_view_row_activated_cb (GtkWidget            *view,
+                                    guint                 position,
+                                    GtkFileChooserWidget *self)
 {
   GFileInfo *info;
 
@@ -6171,9 +6173,9 @@ column_view_row_activated_cb (GtkColumnView        *column_view,
            self->action == GTK_FILE_CHOOSER_ACTION_SAVE)
     {
       /* prevent recursion */
-      g_signal_handlers_block_by_func (column_view, column_view_row_activated_cb, self);
+      g_signal_handlers_block_by_func (view, browse_files_view_row_activated_cb, self);
       gtk_widget_activate_default (GTK_WIDGET (self));
-      g_signal_handlers_unblock_by_func (column_view, column_view_row_activated_cb, self);
+      g_signal_handlers_unblock_by_func (view, browse_files_view_row_activated_cb, self);
     }
 
   g_clear_object (&info);
@@ -6817,6 +6819,7 @@ gtk_file_chooser_widget_class_init (GtkFileChooserWidgetClass *class)
   gtk_widget_class_bind_template_child (widget_class, GtkFileChooserWidget, box);
 
   /* And a *lot* of callbacks to bind ... */
+  gtk_widget_class_bind_template_callback (widget_class, browse_files_view_row_activated_cb);
   gtk_widget_class_bind_template_callback (widget_class, browse_files_view_keynav_failed_cb);
   gtk_widget_class_bind_template_callback (widget_class, filter_combo_changed);
   gtk_widget_class_bind_template_callback (widget_class, path_bar_clicked);
@@ -6838,7 +6841,6 @@ gtk_file_chooser_widget_class_init (GtkFileChooserWidgetClass *class)
   gtk_widget_class_bind_template_callback (widget_class, column_view_get_location);
   gtk_widget_class_bind_template_callback (widget_class, column_view_get_size);
   gtk_widget_class_bind_template_callback (widget_class, column_view_get_tooltip_text);
-  gtk_widget_class_bind_template_callback (widget_class, column_view_row_activated_cb);
 
   gtk_widget_class_set_css_name (widget_class, I_("filechooser"));
 
index b0d98f9fc9fda678916c6a335b5a3b2db13aab30..2dfaebb4740ec63e10a37556d27bba76be63de8f 100644 (file)
                                             <style>
                                               <class name="complex"/>
                                             </style>
-                                            <signal name="activate" handler="column_view_row_activated_cb" swapped="no"/>
+                                            <signal name="activate" handler="browse_files_view_row_activated_cb" swapped="no"/>
                                             <signal name="keynav-failed" handler="browse_files_view_keynav_failed_cb"/>
                                             <child>
                                               <object class="GtkColumnViewColumn" id="column_view_name_column">
     </child>
   </object>
   <object class="GtkGridView" id="browse_files_grid_view">
-    <signal name="activate" handler="column_view_row_activated_cb" swapped="no"/>
+    <signal name="activate" handler="browse_files_view_row_activated_cb" swapped="no"/>
     <signal name="keynav-failed" handler="browse_files_view_keynav_failed_cb"/>
     <binding name="enable-rubberband">
       <lookup name="enable-rubberband">browse_files_column_view</lookup>