lib/repo-finder: Squash memory leak
authorColin Walters <walters@verbum.org>
Sat, 26 Aug 2023 16:18:48 +0000 (12:18 -0400)
committerColin Walters <walters@verbum.org>
Sat, 26 Aug 2023 16:23:26 +0000 (12:23 -0400)
We want to free this value on each iteration; it's moved below
if the value is used.

src/libostree/ostree-repo-finder-mount.c

index 195830904679333db809954c9c3f86ac1366b18b..3f92b278117b58dd8ceb8638a172a38978bef61b 100644 (file)
@@ -438,7 +438,6 @@ ostree_repo_finder_mount_resolve_async (OstreeRepoFinder *finder,
         {
           const OstreeCollectionRef *ref = refs[i];
           g_autofree gchar *resolved_repo_uri = NULL;
-          g_autoptr (UriAndKeyring) resolved_repo = NULL;
 
           for (gsize j = 0; j < repos_refs->len; j++)
             {
@@ -484,7 +483,8 @@ ostree_repo_finder_mount_resolve_async (OstreeRepoFinder *finder,
                        ref->collection_id, ref->ref_name, mount_name, resolved_repo_uri,
                        keyring_remote->keyring, keyring_remote->name);
 
-              resolved_repo = uri_and_keyring_new (resolved_repo_uri, keyring_remote);
+              g_autoptr (UriAndKeyring) resolved_repo
+                  = uri_and_keyring_new (resolved_repo_uri, keyring_remote);
 
               supported_ref_to_checksum = g_hash_table_lookup (repo_to_refs, resolved_repo);