Add early return checks for setter methods

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

diff --git a/src/gui/fileactivitylistmodel.cpp b/src/gui/fileactivitylistmodel.cpp
index 2dde4924f46c77f20712b61cc625e6d5a4c69e8a..2f0c83d4994f2a2abf6576062a603ea545c8b410 100644 (file)
--- a/src/gui/fileactivitylistmodel.cpp
+++ b/src/gui/fileactivitylistmodel.cpp
@@ -34,6 +34,10 @@ QString FileActivityListModel::localPath() const
 
 void FileActivityListModel::setLocalPath(const QString &localPath)
 {
+    if(localPath == _localPath) {
+        return;
+    }
+
     _localPath = localPath;
     Q_EMIT localPathChanged();
 

diff --git a/src/gui/filedetails/shareemodel.cpp b/src/gui/filedetails/shareemodel.cpp
index ddc9d7ac8a8d099c0c9270e44a700c4e7dc4a84f..c4be699a7abce03cc81263bc5e38203ca8bc9e96 100644 (file)
--- a/src/gui/filedetails/shareemodel.cpp
+++ b/src/gui/filedetails/shareemodel.cpp
@@ -82,11 +82,15 @@ QVariant ShareeModel::data(const QModelIndex &index, const int role) const
 
 AccountState *ShareeModel::accountState() const
 {
-    return _accountState.data();
+    return _accountState;
 }
 
 void ShareeModel::setAccountState(AccountState *accountState)
 {
+    if (accountState == _accountState) {
+        return;
+    }
+
     _accountState = accountState;
     Q_EMIT accountStateChanged();
 }
@@ -98,6 +102,10 @@ bool ShareeModel::shareItemIsFolder() const
 
 void ShareeModel::setShareItemIsFolder(const bool shareItemIsFolder)
 {
+    if (shareItemIsFolder == _shareItemIsFolder) {
+        return;
+    }
+
     _shareItemIsFolder = shareItemIsFolder;
     Q_EMIT shareItemIsFolderChanged();
 }
@@ -109,6 +117,10 @@ QString ShareeModel::searchString() const
 
 void ShareeModel::setSearchString(const QString &searchString)
 {
+    if (searchString == _searchString) {
+        return;
+    }
+
     _searchString = searchString;
     Q_EMIT searchStringChanged();
 
@@ -127,6 +139,10 @@ ShareeModel::LookupMode ShareeModel::lookupMode() const
 
 void ShareeModel::setLookupMode(const ShareeModel::LookupMode lookupMode)
 {
+    if (lookupMode == _lookupMode) {
+        return;
+    }
+
     _lookupMode = lookupMode;
     Q_EMIT lookupModeChanged();
 }

diff --git a/src/gui/filedetails/shareemodel.h b/src/gui/filedetails/shareemodel.h
index 8029ee76563d3b95247862e6c35e737f2c2b649c..b09624ced10bfc9ca6e0d393e3e974ae6f377e38 100644 (file)
--- a/src/gui/filedetails/shareemodel.h
+++ b/src/gui/filedetails/shareemodel.h
@@ -87,7 +87,7 @@ private:
 
     QTimer _userStoppedTypingTimer;
 
-    AccountStatePtr _accountState;
+    AccountState *_accountState;
     QString _searchString;
     bool _shareItemIsFolder = false;
     bool _fetchOngoing = false;

diff --git a/src/gui/filedetails/sharemodel.cpp b/src/gui/filedetails/sharemodel.cpp
index 07294fc9356733ac90964d08e58cde6b2bef6fcb..cb511f038def151386b89d8a40f45bf25baaf1b9 100644 (file)
--- a/src/gui/filedetails/sharemodel.cpp
+++ b/src/gui/filedetails/sharemodel.cpp
@@ -899,6 +899,10 @@ QString ShareModel::localPath() const
 
 void ShareModel::setLocalPath(const QString &localPath)
 {
+    if (localPath == _localPath) {
+        return;
+    }
+
     _localPath = localPath;
     Q_EMIT localPathChanged();
     updateData();
@@ -911,6 +915,10 @@ AccountState *ShareModel::accountState() const
 
 void ShareModel::setAccountState(AccountState *accountState)
 {
+    if (accountState == _accountState) {
+        return;
+    }
+
     _accountState = accountState;
 
     // Change the server and account-related properties